[dpdk-test-report] |WARNING| pw65433 [RFC PATCH 1/5] graph: introduce graph subsystem

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/65433

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#93: 
Abstracting the data processing functions as “nodes” and “link” them

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1320: FILE: lib/librte_graph/graph_private.h:20:
+		RTE_FMT("GRAPH: %s():%u " RTE_FMT_HEAD(__VA_ARGS__,)           \
 		                                                  ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1322: FILE: lib/librte_graph/graph_private.h:22:
+			RTE_FMT_TAIL(__VA_ARGS__,)))
 			                        ^

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1328: FILE: lib/librte_graph/graph_private.h:28:
+#define id_check(id, id_max) do {					       \
+	if ((id) >= (id_max)) {						       \
+		rte_errno = EINVAL;					       \
+		goto fail;						       \
+	}								       \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1335: FILE: lib/librte_graph/graph_private.h:35:
+#define set_err(err, where, fmt, ...) do {				       \
+	graph_err(fmt, ##__VA_ARGS__);					       \
+	rte_errno = err;						       \
+	goto where;							       \
+} while (0)

WARNING:LONG_LINE: line over 90 characters
#1461: FILE: lib/librte_graph/graph_stats.c:42:
+#define boarder() fprintf(f, "+-------------------------------+---------------+---------------+---------------+---------------+---------------+-----------+
")

WARNING:LONG_LINE: line over 90 characters
#1467: FILE: lib/librte_graph/graph_stats.c:48:
+	fprintf(f, "%-32s%-16s%-16s%-16s%-16s%-16s%-16s
", "|Node", "|calls", "|objs", "|realloc_count", "|objs/call", "|objs/sec(10E6)", "|cycles/call|");

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2460: FILE: lib/librte_graph/rte_graph.h:197:
+#define RTE_NODE_REGISTER(node)						       \
+RTE_INIT(rte_node_register_##node)					       \
+{									       \
+	node.parent_id = RTE_NODE_ID_INVALID;				       \
+	node.id = __rte_node_register(&node);				       \
+}

ERROR:SPACING: space required after that close brace '}'
#2638: FILE: lib/librte_graph/rte_graph_worker.h:40:
+}__rte_cache_aligned;

total: 4 errors, 5 warnings, 2669 lines checked
Please only put __rte_experimental tags in headers (b/lib/librte_graph/graph.c)
__rte_experimental must appear alone on the line immediately preceding the return type of a function.
Please only put __rte_experimental tags in headers (b/lib/librte_graph/graph.c)
__rte_experimental must appear alone on the line immediately preceding the return type of a function.