[dpdk-test-report] |WARNING| pw65436 [RFC PATCH 5/5] example/l3fwd_graph: l3fwd using graph architecture

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jan 31 18:04:56 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/65436

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#138: FILE: examples/l3fwd-graph/Makefile:8:
+SRCS-y := main.c $

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#323: FILE: examples/l3fwd-graph/main.c:129:
+static struct lcore_params * lcore_params = lcore_params_array_default;

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(ipv4_l3fwd_lpm_route_array)
#355: FILE: examples/l3fwd-graph/main.c:161:
+	(sizeof(ipv4_l3fwd_lpm_route_array) / sizeof(ipv4_l3fwd_lpm_route_array[0]))

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#391: FILE: examples/l3fwd-graph/main.c:197:
+		if ((socketid = rte_lcore_to_socket_id(lcore) != 0) &&

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#393: FILE: examples/l3fwd-graph/main.c:199:
+			printf("warning: lcore %hhu is on socket %d with numa off 
",

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#450: FILE: examples/l3fwd-graph/main.c:256:
+				(unsigned)nb_rx_queue + 1, (unsigned)lcore);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#450: FILE: examples/l3fwd-graph/main.c:256:
+				(unsigned)nb_rx_queue + 1, (unsigned)lcore);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#452: FILE: examples/l3fwd-graph/main.c:258:
+			return -1;
+		} else {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#539: FILE: examples/l3fwd-graph/main.c:345:
+	unsigned size;

ERROR:SPACING: space required after that ',' (ctx:VxV)
#543: FILE: examples/l3fwd-graph/main.c:349:
+	while ((p = strchr(p0,'(')) != NULL) {
 	                     ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#545: FILE: examples/l3fwd-graph/main.c:351:
+		if((p0 = strchr(p,')')) == NULL)
 		                 ^

ERROR:SPACING: space required before the open parenthesis '('
#545: FILE: examples/l3fwd-graph/main.c:351:
+		if((p0 = strchr(p,')')) == NULL)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#545: FILE: examples/l3fwd-graph/main.c:351:
+		if((p0 = strchr(p,')')) == NULL)

ERROR:SPACING: space required before the open parenthesis '('
#549: FILE: examples/l3fwd-graph/main.c:355:
+		if(size >= sizeof(s))

ERROR:SPACING: space required before the open brace '{'
#555: FILE: examples/l3fwd-graph/main.c:361:
+		for (i = 0; i < _NUM_FLD; i++){

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#625: FILE: examples/l3fwd-graph/main.c:431:
+	 * conflict with short options */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#655: FILE: examples/l3fwd-graph/main.c:461:
+	(unsigned)8192)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#762: FILE: examples/l3fwd-graph/main.c:568:
+	unsigned lcore_id;

ERROR:SPACING: space required after that ',' (ctx:VxV)
#873: FILE: examples/l3fwd-graph/main.c:679:
+	const char topLeft[] = { 27, '[', '1', ';', '1', 'H','


More information about the test-report mailing list