[dpdk-test-report] |WARNING| pw73982 [PATCH v4 06/11] eal: replace pci-whitelist/pci-blacklist options

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Jul 14 07:41:17 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/73982

_coding style issues_


WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#81: 
Replace pci-whitelist with pci-include and pci-blacklist with

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#81: 
Replace pci-whitelist with pci-include and pci-blacklist with

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#127: FILE: lib/librte_eal/common/eal_common_options.c:92:
+^I{OPT_PCI_EXCLUDE, ^I1, NULL, OPT_PCI_EXCLUDE_NUM^I  },$

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#138: FILE: lib/librte_eal/common/eal_common_options.c:109:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#138: FILE: lib/librte_eal/common/eal_common_options.c:109:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#139: FILE: lib/librte_eal/common/eal_common_options.c:110:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#139: FILE: lib/librte_eal/common/eal_common_options.c:110:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#159: FILE: lib/librte_eal/common/eal_common_options.c:1429:
+		fprintf(stderr, "Option -b, --blacklist is deprecated, use -x, --pci-exclude option instead
");

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#160: FILE: lib/librte_eal/common/eal_common_options.c:1430:
+		/* fallthrough */

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#178: FILE: lib/librte_eal/common/eal_common_options.c:1443:
+		fprintf(stderr, "Option -w, --whitelist is deprecated, use -i, --pci-include option instead
");

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#179: FILE: lib/librte_eal/common/eal_common_options.c:1444:
+		/* fallthrough */

WARNING:LONG_LINE: line over 100 characters
#221: FILE: lib/librte_eal/common/eal_common_options.c:1951:
+	       "                      [NOTE: " OPT_PCI_INCLUDE " cannot be used with "OPT_PCI_EXCLUDE" option]
"

ERROR:TRAILING_WHITESPACE: trailing whitespace
#244: FILE: lib/librte_eal/common/eal_options.h:26:
+^I$

total: 1 errors, 12 warnings, 139 lines checked


More information about the test-report mailing list