[dpdk-test-report] |WARNING| pw74923 [PATCH v5] net/ice: fix GTPU down/uplink and extension conflict

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/74923

_coding style issues_


WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv4.rotate'
#155: FILE: drivers/net/ice/ice_ethdev.c:2479:
+			if (ICE_HASH_CFG_IS_ROTATING(pf->gtpu_hash_ctx.
+						ipv4.rotate)) {

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv4.rotate'
#161: FILE: drivers/net/ice/ice_ethdev.c:2485:
+				ICE_HASH_CFG_ROTATE_STOP(pf->gtpu_hash_ctx.
+						ipv4.rotate);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv6.rotate'
#166: FILE: drivers/net/ice/ice_ethdev.c:2490:
+			if (ICE_HASH_CFG_IS_ROTATING(pf->gtpu_hash_ctx.
+						ipv6.rotate)) {

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv6.rotate'
#172: FILE: drivers/net/ice/ice_ethdev.c:2496:
+				ICE_HASH_CFG_ROTATE_STOP(pf->gtpu_hash_ctx.
+						ipv6.rotate);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv4.rotate'
#177: FILE: drivers/net/ice/ice_ethdev.c:2501:
+			if (ICE_HASH_CFG_IS_ROTATING(pf->gtpu_hash_ctx.
+						ipv4.rotate)) {

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv4.rotate'
#183: FILE: drivers/net/ice/ice_ethdev.c:2507:
+				ICE_HASH_CFG_ROTATE_STOP(pf->gtpu_hash_ctx.
+						ipv4.rotate);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv6.rotate'
#188: FILE: drivers/net/ice/ice_ethdev.c:2512:
+			if (ICE_HASH_CFG_IS_ROTATING(pf->gtpu_hash_ctx.
+						ipv6.rotate)) {

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv6.rotate'
#194: FILE: drivers/net/ice/ice_ethdev.c:2518:
+				ICE_HASH_CFG_ROTATE_STOP(pf->gtpu_hash_ctx.
+						ipv6.rotate);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv4.rotate'
#224: FILE: drivers/net/ice/ice_ethdev.c:2548:
+				ICE_HASH_CFG_ROTATE_START(pf->gtpu_hash_ctx.
+							ipv4.rotate);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv6.rotate'
#240: FILE: drivers/net/ice/ice_ethdev.c:2564:
+				ICE_HASH_CFG_ROTATE_START(pf->gtpu_hash_ctx.
+							ipv6.rotate);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv4.rotate'
#256: FILE: drivers/net/ice/ice_ethdev.c:2580:
+				ICE_HASH_CFG_ROTATE_START(pf->gtpu_hash_ctx.
+							ipv4.rotate);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'pf->gtpu_hash_ctx.ipv6.rotate'
#272: FILE: drivers/net/ice/ice_ethdev.c:2596:
+				ICE_HASH_CFG_ROTATE_START(pf->gtpu_hash_ctx.
+							ipv6.rotate);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#745: FILE: drivers/net/ice/ice_ethdev.h:361:
+#define ICE_HASH_CFG_VALID(p)		\
+	((p)->hash_fld != 0 && (p)->pkt_hdr != 0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#748: FILE: drivers/net/ice/ice_ethdev.h:364:
+#define ICE_HASH_CFG_RESET(p) do {	\
+	(p)->hash_fld = 0;		\
+	(p)->pkt_hdr = 0;		\
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'value' may be better as '(value)' to avoid precedence issues
#753: FILE: drivers/net/ice/ice_ethdev.h:369:
+#define ICE_HASH_CFG_IS_ROTATING(value)		\
+	(value == true)

CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#754: FILE: drivers/net/ice/ice_ethdev.h:370:
+	(value == true)

total: 0 errors, 12 warnings, 4 checks, 689 lines checked