[dpdk-test-report] |WARNING| pw66354 [PATCH 4/4] if_proxy: add example application

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66354

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#296: FILE: examples/l3fwd-ifpx/l3fwd.c:84:
+RTE_STD_C11

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#398: FILE: examples/l3fwd-ifpx/l3fwd.c:186:
+#if 0 // FIXME - either remove this or add IP fragmentation

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#611: FILE: examples/l3fwd-ifpx/l3fwd.c:399:
+#if 0

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#632: FILE: examples/l3fwd-ifpx/l3fwd.c:420:
+	unsigned i;

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#634: FILE: examples/l3fwd-ifpx/l3fwd.c:422:
+#if 0

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#683: FILE: examples/l3fwd-ifpx/l3fwd.c:471:
+	unsigned i;

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#1062: FILE: examples/l3fwd-ifpx/l3fwd.c:850:
+	while (rte_ring_dequeue(lconf->ev_queue, (void**)&ev) == 0) {

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#1110: FILE: examples/l3fwd-ifpx/l3fwd.c:898:
+	return rte_jhash_1word(*(const uint32_t*)key, init_val);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1247: FILE: examples/l3fwd-ifpx/l3fwd.c:1035:
+	unsigned lcore_id;

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1595: FILE: examples/l3fwd-ifpx/main.c:150:
+		if ((socketid = rte_lcore_to_socket_id(lcore)) != 0) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1669: FILE: examples/l3fwd-ifpx/main.c:224:
+				(unsigned)nb_rx_queue + 1, (unsigned)lcore);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1669: FILE: examples/l3fwd-ifpx/main.c:224:
+				(unsigned)nb_rx_queue + 1, (unsigned)lcore);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1739: FILE: examples/l3fwd-ifpx/main.c:294:
+	unsigned size;

ERROR:SPACING: space required after that ',' (ctx:VxV)
#1743: FILE: examples/l3fwd-ifpx/main.c:298:
+	while ((p = strchr(p0,'(')) != NULL) {
 	                     ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#1745: FILE: examples/l3fwd-ifpx/main.c:300:
+		if((p0 = strchr(p,')')) == NULL)
 		                 ^

ERROR:SPACING: space required before the open parenthesis '('
#1745: FILE: examples/l3fwd-ifpx/main.c:300:
+		if((p0 = strchr(p,')')) == NULL)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1745: FILE: examples/l3fwd-ifpx/main.c:300:
+		if((p0 = strchr(p,')')) == NULL)

ERROR:SPACING: space required before the open parenthesis '('
#1749: FILE: examples/l3fwd-ifpx/main.c:304:
+		if(size >= sizeof(s))

ERROR:SPACING: space required before the open brace '{'
#1755: FILE: examples/l3fwd-ifpx/main.c:310:
+		for (i = 0; i < _NUM_FLD; i++){

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1794: FILE: examples/l3fwd-ifpx/main.c:349:
+	 * conflict with short options */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1818: FILE: examples/l3fwd-ifpx/main.c:373:
+	(unsigned)8192)

ERROR:CODE_INDENT: code indent should use tabs where possible
#1890: FILE: examples/l3fwd-ifpx/main.c:445:
+^I^I        "Signal %d received, preparing to exit...
", signum);$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1926: FILE: examples/l3fwd-ifpx/main.c:481:
+	unsigned nb_ports;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1929: FILE: examples/l3fwd-ifpx/main.c:484:
+	unsigned lcore_id;

ERROR:SPACING: space prohibited before that close parenthesis ')'
#2072: FILE: examples/l3fwd-ifpx/main.c:627:
+			lcore_id );

ERROR:SPACING: space required before the open parenthesis '('
#2074: FILE: examples/l3fwd-ifpx/main.c:629:
+		for(queue = 0; queue < lconf->n_rx_queue; ++queue) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#2091: FILE: examples/l3fwd-ifpx/main.c:646:
+^I^I^I                             nb_rxd, SOCKET_ID_ANY,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2092: FILE: examples/l3fwd-ifpx/main.c:647:
+^I^I^I                             &rxq_conf,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2093: FILE: examples/l3fwd-ifpx/main.c:648:
+^I^I^I                             pktmbuf_pool);$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2105: FILE: examples/l3fwd-ifpx/main.c:660:
+		if ((enabled_port_mask & (1 << portid)) == 0) {
+			continue;
+		}

total: 15 errors, 15 warnings, 2043 lines checked