[dpdk-test-report] |WARNING| pw66500 [PATCH 5/5] net/sfc/base: handle manual and auto filter clashes in EF10

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66500

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#131: FILE: drivers/net/sfc/base/ef10_filter.c:607:
+static	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#132: FILE: drivers/net/sfc/base/ef10_filter.c:608:
+ef10_filter_add_lookup_equal_spec(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#144: FILE: drivers/net/sfc/base/ef10_filter.c:620:
+		return (0);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#177: FILE: drivers/net/sfc/base/ef10_filter.c:653:
+				break;
+			} else {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#198: FILE: drivers/net/sfc/base/ef10_filter.c:674:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#203: FILE: drivers/net/sfc/base/ef10_filter.c:679:
+ef10_filter_add_select_action(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#264: FILE: drivers/net/sfc/base/ef10_filter.c:740:
+ef10_filter_add_execute_action(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#334: FILE: drivers/net/sfc/base/ef10_filter.c:810:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#339: FILE: drivers/net/sfc/base/ef10_filter.c:815:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#467: FILE: drivers/net/sfc/base/ef10_filter.c:925:
+		EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*new_spec), new_spec);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#551: FILE: drivers/net/sfc/base/ef10_filter.c:968:
+		EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec),

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#561: FILE: drivers/net/sfc/base/ef10_filter.c:976:
+		EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), overridden_spec);

WARNING:TYPO_SPELLING: 'overriden' may be misspelled - perhaps 'overridden'?
#632: FILE: drivers/net/sfc/base/ef10_filter.c:1062:
+		 * Applied filter stays, but overriden filter is removed since

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#639: FILE: drivers/net/sfc/base/ef10_filter.c:1069:
+			EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec),

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#681: FILE: drivers/net/sfc/base/ef10_filter.c:1101:
+		EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), spec);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#698: FILE: drivers/net/sfc/base/ef10_filter.c:1120:
+ef10_filter_delete_auto(

WARNING:TYPO_SPELLING: 'overriden' may be misspelled - perhaps 'overridden'?
#708: FILE: drivers/net/sfc/base/ef10_filter.c:1130:
+	 * that is overriden by it.

CHECK:SPACING: No space is necessary after a cast
#712: FILE: drivers/net/sfc/base/ef10_filter.c:1134:
+	(void) ef10_filter_delete_internal(enp, filter_idx,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '['
#794: FILE: drivers/net/sfc/base/ef10_filter.c:1689:
+		    &table->eft_encap_filter_indexes[

total: 4 errors, 8 warnings, 7 checks, 814 lines checked