[dpdk-test-report] |WARNING| pw66761 [PATCH 3/4] net/vhost: leverage DMA engines to accelerate Tx operations

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66761

_coding style issues_


CHECK:BRACES: Unbalanced braces around else statement
#303: FILE: drivers/net/vhost/rte_eth_vhost.c:735:
+	else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#618: FILE: drivers/net/vhost/virtio_net.c:54:
+		if ((vhost_need_event(vhost_used_event(vr), new, old) &&
+		     (vr->callfd >= 0)) || unlikely(!signalled_used_valid))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vr->callfd >= 0'
#622: FILE: drivers/net/vhost/virtio_net.c:58:
+		if (!(vr->avail->flags & VRING_AVAIL_F_NO_INTERRUPT) &&
+		    (vr->callfd >= 0))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects?
#779: FILE: drivers/net/vhost/virtio_net.c:215:
+#define ASSIGN_UNLESS_EQUAL(var, val) do {	\
+	if ((var) != (val))			\
+		(var) = (val);			\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#779: FILE: drivers/net/vhost/virtio_net.c:215:
+#define ASSIGN_UNLESS_EQUAL(var, val) do {	\
+	if ((var) != (val))			\
+		(var) = (val);			\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vr' - possible side-effects?
#1372: FILE: drivers/net/vhost/virtio_net.h:35:
+#define vhost_used_event(vr) \
+	(*(volatile uint16_t*)&(vr)->avail->ring[(vr)->size])

total: 0 errors, 0 warnings, 6 checks, 1339 lines checked