[dpdk-test-report] |WARNING| pw66789 [PATCH 05/33] net/bnxt: add initial tf core session close support

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Mar 17 16:41:54 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66789

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects?
#513: FILE: drivers/net/bnxt/tf_core/bitalloc.h:26:
+#define BITALLOC_SIZEOF(size)                                    \
+	(sizeof(struct bitalloc) *				 \
+	 (((sizeof(struct bitalloc) +				 \
+	    sizeof(struct bitalloc) - 1 +			 \
+	    (sizeof(bitalloc_word_t) *				 \
+	     ((BA_L0(size) - 1) +				 \
+	      ((BA_L0(size) == 1) ? 0 : (BA_L1(size) + 1)) +	 \
+	      ((BA_L1(size) == 1) ? 0 : (BA_L2(size) + 1)) +	 \
+	      ((BA_L2(size) == 1) ? 0 : (BA_L3(size) + 1)) +	 \
+	      ((BA_L3(size) == 1) ? 0 : (BA_L4(size) + 1)))))) / \
+	  sizeof(struct bitalloc)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'query' - possible side-effects?
#724: FILE: drivers/net/bnxt/tf_core/tf_msg.c:23:
+#define TF_HW_RESP_TO_QUERY(query, index, response, element) do {            \
+	(query)->hw_query[index].min =                                       \
+		tfp_le_to_cpu_16(response. element ## _min);                 \
+	(query)->hw_query[index].max =                                       \
+		tfp_le_to_cpu_16(response. element ## _max);                 \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#724: FILE: drivers/net/bnxt/tf_core/tf_msg.c:23:
+#define TF_HW_RESP_TO_QUERY(query, index, response, element) do {            \
+	(query)->hw_query[index].min =                                       \
+		tfp_le_to_cpu_16(response. element ## _min);                 \
+	(query)->hw_query[index].max =                                       \
+		tfp_le_to_cpu_16(response. element ## _max);                 \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects?
#724: FILE: drivers/net/bnxt/tf_core/tf_msg.c:23:
+#define TF_HW_RESP_TO_QUERY(query, index, response, element) do {            \
+	(query)->hw_query[index].min =                                       \
+		tfp_le_to_cpu_16(response. element ## _min);                 \
+	(query)->hw_query[index].max =                                       \
+		tfp_le_to_cpu_16(response. element ## _max);                 \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw_entry' - possible side-effects?
#740: FILE: drivers/net/bnxt/tf_core/tf_msg.c:39:
+#define TF_HW_FREE_TO_REQ(hw_entry, index, request, element) do {            \
+	request.element ## _start =                                          \
+		tfp_cpu_to_le_16(hw_entry[index].start);                     \
+	request.element ## _stride =                                         \
+		tfp_cpu_to_le_16(hw_entry[index].stride);                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#740: FILE: drivers/net/bnxt/tf_core/tf_msg.c:39:
+#define TF_HW_FREE_TO_REQ(hw_entry, index, request, element) do {            \
+	request.element ## _start =                                          \
+		tfp_cpu_to_le_16(hw_entry[index].start);                     \
+	request.element ## _stride =                                         \
+		tfp_cpu_to_le_16(hw_entry[index].stride);                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'request' - possible side-effects?
#740: FILE: drivers/net/bnxt/tf_core/tf_msg.c:39:
+#define TF_HW_FREE_TO_REQ(hw_entry, index, request, element) do {            \
+	request.element ## _start =                                          \
+		tfp_cpu_to_le_16(hw_entry[index].start);                     \
+	request.element ## _stride =                                         \
+		tfp_cpu_to_le_16(hw_entry[index].stride);                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw_entry' - possible side-effects?
#751: FILE: drivers/net/bnxt/tf_core/tf_msg.c:50:
+#define TF_HW_RESP_TO_ALLOC(hw_entry, index, response, element) do {         \
+	hw_entry[index].start =                                              \
+		tfp_le_to_cpu_16(response.element ## _start);                \
+	hw_entry[index].stride =                                             \
+		tfp_le_to_cpu_16(response.element ## _stride);               \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#751: FILE: drivers/net/bnxt/tf_core/tf_msg.c:50:
+#define TF_HW_RESP_TO_ALLOC(hw_entry, index, response, element) do {         \
+	hw_entry[index].start =                                              \
+		tfp_le_to_cpu_16(response.element ## _start);                \
+	hw_entry[index].stride =                                             \
+		tfp_le_to_cpu_16(response.element ## _stride);               \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects?
#751: FILE: drivers/net/bnxt/tf_core/tf_msg.c:50:
+#define TF_HW_RESP_TO_ALLOC(hw_entry, index, response, element) do {         \
+	hw_entry[index].start =                                              \
+		tfp_le_to_cpu_16(response.element ## _start);                \
+	hw_entry[index].stride =                                             \
+		tfp_le_to_cpu_16(response.element ## _stride);               \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'query' - possible side-effects?
#762: FILE: drivers/net/bnxt/tf_core/tf_msg.c:61:
+#define TF_SRAM_RESP_TO_QUERY(query, index, response, element) do {          \
+	(query)->sram_query[index].min =                                     \
+		tfp_le_to_cpu_16(response.element ## _min);                  \
+	(query)->sram_query[index].max =                                     \
+		tfp_le_to_cpu_16(response.element ## _max);                  \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#762: FILE: drivers/net/bnxt/tf_core/tf_msg.c:61:
+#define TF_SRAM_RESP_TO_QUERY(query, index, response, element) do {          \
+	(query)->sram_query[index].min =                                     \
+		tfp_le_to_cpu_16(response.element ## _min);                  \
+	(query)->sram_query[index].max =                                     \
+		tfp_le_to_cpu_16(response.element ## _max);                  \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects?
#762: FILE: drivers/net/bnxt/tf_core/tf_msg.c:61:
+#define TF_SRAM_RESP_TO_QUERY(query, index, response, element) do {          \
+	(query)->sram_query[index].min =                                     \
+		tfp_le_to_cpu_16(response.element ## _min);                  \
+	(query)->sram_query[index].max =                                     \
+		tfp_le_to_cpu_16(response.element ## _max);                  \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sram_entry' - possible side-effects?
#779: FILE: drivers/net/bnxt/tf_core/tf_msg.c:78:
+#define TF_SRAM_FREE_TO_REQ(sram_entry, index, request, element) do {        \
+	request.element ## _start =                                          \
+		tfp_cpu_to_le_16(sram_entry[index].start);                   \
+	request.element ## _stride =                                         \
+		tfp_cpu_to_le_16(sram_entry[index].stride);                  \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#779: FILE: drivers/net/bnxt/tf_core/tf_msg.c:78:
+#define TF_SRAM_FREE_TO_REQ(sram_entry, index, request, element) do {        \
+	request.element ## _start =                                          \
+		tfp_cpu_to_le_16(sram_entry[index].start);                   \
+	request.element ## _stride =                                         \
+		tfp_cpu_to_le_16(sram_entry[index].stride);                  \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'request' - possible side-effects?
#779: FILE: drivers/net/bnxt/tf_core/tf_msg.c:78:
+#define TF_SRAM_FREE_TO_REQ(sram_entry, index, request, element) do {        \
+	request.element ## _start =                                          \
+		tfp_cpu_to_le_16(sram_entry[index].start);                   \
+	request.element ## _stride =                                         \
+		tfp_cpu_to_le_16(sram_entry[index].stride);                  \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sram_entry' - possible side-effects?
#790: FILE: drivers/net/bnxt/tf_core/tf_msg.c:89:
+#define TF_SRAM_RESP_TO_ALLOC(sram_entry, index, response, element) do {     \
+	sram_entry[index].start =                                            \
+		tfp_le_to_cpu_16(response.element ## _start);                \
+	sram_entry[index].stride =                                           \
+		tfp_le_to_cpu_16(response.element ## _stride);               \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#790: FILE: drivers/net/bnxt/tf_core/tf_msg.c:89:
+#define TF_SRAM_RESP_TO_ALLOC(sram_entry, index, response, element) do {     \
+	sram_entry[index].start =                                            \
+		tfp_le_to_cpu_16(response.element ## _start);                \
+	sram_entry[index].stride =                                           \
+		tfp_le_to_cpu_16(response.element ## _stride);               \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects?
#790: FILE: drivers/net/bnxt/tf_core/tf_msg.c:89:
+#define TF_SRAM_RESP_TO_ALLOC(sram_entry, index, response, element) do {     \
+	sram_entry[index].start =                                            \
+		tfp_le_to_cpu_16(response.element ## _start);                \
+	sram_entry[index].stride =                                           \
+		tfp_le_to_cpu_16(response.element ## _stride);               \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfs' - possible side-effects?
#1272: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40:
+#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \
+		(rc) = 0;						\
+		if ((direction) == TF_DIR_RX) {				\
+			*(session_pool) = (tfs)->pool_name ## _RX;	\
+		} else if ((direction) == TF_DIR_TX) {			\
+			*(session_pool) = (tfs)->pool_name ## _TX;	\
+		} else {						\
+			rc = -1;					\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'direction' - possible side-effects?
#1272: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40:
+#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \
+		(rc) = 0;						\
+		if ((direction) == TF_DIR_RX) {				\
+			*(session_pool) = (tfs)->pool_name ## _RX;	\
+		} else if ((direction) == TF_DIR_TX) {			\
+			*(session_pool) = (tfs)->pool_name ## _TX;	\
+		} else {						\
+			rc = -1;					\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'session_pool' - possible side-effects?
#1272: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40:
+#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \
+		(rc) = 0;						\
+		if ((direction) == TF_DIR_RX) {				\
+			*(session_pool) = (tfs)->pool_name ## _RX;	\
+		} else if ((direction) == TF_DIR_TX) {			\
+			*(session_pool) = (tfs)->pool_name ## _TX;	\
+		} else {						\
+			rc = -1;					\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rc' - possible side-effects?
#1272: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40:
+#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \
+		(rc) = 0;						\
+		if ((direction) == TF_DIR_RX) {				\
+			*(session_pool) = (tfs)->pool_name ## _RX;	\
+		} else if ((direction) == TF_DIR_TX) {			\
+			*(session_pool) = (tfs)->pool_name ## _TX;	\
+		} else {						\
+			rc = -1;					\
+		}							\
+	} while (0)

total: 0 errors, 0 warnings, 23 checks, 1233 lines checked


More information about the test-report mailing list