[dpdk-test-report] |WARNING| pw66982 [RFC] ring: make ring implementation non-inlined

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 20 17:42:31 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/66982

_coding style issues_


WARNING:TYPO_SPELLING: 'noticable' may be misspelled - perhaps 'noticeable'?
#68: 
though for SP/SC and/or small transfers it is more then noticable

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1521: FILE: lib/librte_ring/ring_impl.c:26:
+ * single and multi producer enqueue functions */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1528: FILE: lib/librte_ring/ring_impl.c:33:
+		for (i = 0; i < (n & ((~(unsigned)0x3))); i+=4, idx+=4) { \

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#1528: FILE: lib/librte_ring/ring_impl.c:33:
+		for (i = 0; i < (n & ((~(unsigned)0x3))); i+=4, idx+=4) { \
 		                                           ^

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#1528: FILE: lib/librte_ring/ring_impl.c:33:
+		for (i = 0; i < (n & ((~(unsigned)0x3))); i+=4, idx+=4) { \
 		                                                   ^

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1552: FILE: lib/librte_ring/ring_impl.c:57:
+ * single and multi consumer dequeue functions */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1559: FILE: lib/librte_ring/ring_impl.c:64:
+		for (i = 0; i < (n & (~(unsigned)0x3)); i+=4, idx+=4) {\

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#1559: FILE: lib/librte_ring/ring_impl.c:64:
+		for (i = 0; i < (n & (~(unsigned)0x3)); i+=4, idx+=4) {\
 		                                         ^

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#1559: FILE: lib/librte_ring/ring_impl.c:64:
+		for (i = 0; i < (n & (~(unsigned)0x3)); i+=4, idx+=4) {\
 		                                                 ^

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1599: FILE: lib/librte_ring/ring_impl.c:104:
+ *
+  * @param r

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1600: FILE: lib/librte_ring/ring_impl.c:105:
+  * @param r
+ *   A pointer to the ring structure.

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#2076: FILE: lib/librte_ring/ring_impl.c:581:
+void rte_ring_list_dump(FILE *f);
                              ^

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void * const' should also have an identifier name
#2581: FILE: lib/librte_ring/rte_ring.h:216:
+unsigned int

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void * const' should also have an identifier name
#2597: FILE: lib/librte_ring/rte_ring.h:235:
+unsigned int

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void * const' should also have an identifier name
#2613: FILE: lib/librte_ring/rte_ring.h:258:
+unsigned int

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void * const' should also have an identifier name
#2860: FILE: lib/librte_ring/rte_ring.h:565:
+unsigned

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void * const' should also have an identifier name
#2876: FILE: lib/librte_ring/rte_ring.h:584:
+unsigned

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void * const' should also have an identifier name
#2892: FILE: lib/librte_ring/rte_ring.h:607:
+unsigned

total: 5 errors, 13 warnings, 3338 lines checked
ERROR: symbol rte_ring_count is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_dequeue is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_dequeue_bulk is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_dequeue_bulk_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_dequeue_burst is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_dequeue_burst_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_dequeue_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_empty is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_enqueue is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_enqueue_bulk is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_enqueue_bulk_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_enqueue_burst is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_enqueue_burst_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_enqueue_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_free_count is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_full is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_get_capacity is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_get_cons_sync_type is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_get_memzone is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_get_name is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_get_prod_sync_type is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_get_size is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mc_dequeue is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mc_dequeue_bulk is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mc_dequeue_bulk_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mc_dequeue_burst is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mc_dequeue_burst_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mc_dequeue_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mp_enqueue is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mp_enqueue_bulk is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mp_enqueue_bulk_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mp_enqueue_burst is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mp_enqueue_burst_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_mp_enqueue_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sc_dequeue is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sc_dequeue_bulk is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sc_dequeue_bulk_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sc_dequeue_burst is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sc_dequeue_burst_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sc_dequeue_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sp_enqueue is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sp_enqueue_bulk is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sp_enqueue_bulk_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sp_enqueue_burst is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sp_enqueue_burst_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map
ERROR: symbol rte_ring_sp_enqueue_elem is added in the DPDK_20.0 section, but is expected to be added in the EXPERIMENTAL section of the version map


More information about the test-report mailing list