[dpdk-test-report] |WARNING| pw83555 [PATCH 34/37] net/txgbe: add security session create operation

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Nov 3 11:20:32 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/83555

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#99: FILE: drivers/net/txgbe/txgbe_ipsec.c:16:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#99: FILE: drivers/net/txgbe/txgbe_ipsec.c:16:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#173: FILE: drivers/net/txgbe/txgbe_ipsec.c:90:
+		if (ic_session->dst_ip.type == IPv6) {

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#176: FILE: drivers/net/txgbe/txgbe_ipsec.c:93:
+		} else if (ic_session->dst_ip.type == IPv4) {

WARNING:REPEATED_WORD: Possible repeated word: 'crypto'
#401: FILE: drivers/net/txgbe/txgbe_ipsec.h:42:
+/** inline crypto crypto private session structure */

total: 0 errors, 1 warnings, 4 checks, 355 lines checked


More information about the test-report mailing list