[dpdk-test-report] |WARNING| pw79623 [PATCH v2 06/56] net/txgbe: add HW infrastructure and dummy function

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Oct 5 14:12:53 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79623

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#85: FILE: drivers/net/txgbe/base/txgbe_dummy.h:10:
+#define TUP(x) x##_unused __attribute__((unused))

WARNING:RETURN_VOID: void function return statements are not generally useful
#110: FILE: drivers/net/txgbe/base/txgbe_dummy.h:35:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#120: FILE: drivers/net/txgbe/base/txgbe_dummy.h:45:
+static inline s32 txgbe_rom_readw_buffer_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, void *TUP3)

WARNING:LONG_LINE: line over 100 characters
#140: FILE: drivers/net/txgbe/base/txgbe_dummy.h:65:
+static inline s32 txgbe_rom_writew_buffer_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, void *TUP3)

WARNING:LONG_LINE: line over 100 characters
#152: FILE: drivers/net/txgbe/base/txgbe_dummy.h:77:
+static inline s32 txgbe_rom_write_buffer_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, void *TUP3)

WARNING:RETURN_VOID: void function return statements are not generally useful
#193: FILE: drivers/net/txgbe/base/txgbe_dummy.h:118:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#261: FILE: drivers/net/txgbe/base/txgbe_dummy.h:186:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#265: FILE: drivers/net/txgbe/base/txgbe_dummy.h:190:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#273: FILE: drivers/net/txgbe/base/txgbe_dummy.h:198:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#289: FILE: drivers/net/txgbe/base/txgbe_dummy.h:214:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#293: FILE: drivers/net/txgbe/base/txgbe_dummy.h:218:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#297: FILE: drivers/net/txgbe/base/txgbe_dummy.h:222:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#306: FILE: drivers/net/txgbe/base/txgbe_dummy.h:231:
+static inline s32 txgbe_mac_check_link_dummy(struct txgbe_hw *TUP0, u32 *TUP1, bool *TUP3, bool TUP4)

WARNING:LONG_LINE: line over 100 characters
#310: FILE: drivers/net/txgbe/base/txgbe_dummy.h:235:
+static inline s32 txgbe_mac_get_link_capabilities_dummy(struct txgbe_hw *TUP0, u32 *TUP1, bool *TUP2)

WARNING:RETURN_VOID: void function return statements are not generally useful
#317: FILE: drivers/net/txgbe/base/txgbe_dummy.h:242:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#321: FILE: drivers/net/txgbe/base/txgbe_dummy.h:246:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#342: FILE: drivers/net/txgbe/base/txgbe_dummy.h:267:
+static inline s32 txgbe_mac_set_rar_dummy(struct txgbe_hw *TUP0, u32 TUP1, u8 *TUP2, u32 TUP3, u32 TUP4)

WARNING:LONG_LINE: line over 100 characters
#374: FILE: drivers/net/txgbe/base/txgbe_dummy.h:299:
+static inline s32 txgbe_mac_update_uc_addr_list_dummy(struct txgbe_hw *TUP0, u8 *TUP1, u32 TUP2, txgbe_mc_addr_itr TUP3)

WARNING:LONG_LINE: line over 100 characters
#378: FILE: drivers/net/txgbe/base/txgbe_dummy.h:303:
+static inline s32 txgbe_mac_update_mc_addr_list_dummy(struct txgbe_hw *TUP0, u8 *TUP1, u32 TUP2, txgbe_mc_addr_itr TUP3, bool TUP4)

WARNING:LONG_LINE: line over 100 characters
#394: FILE: drivers/net/txgbe/base/txgbe_dummy.h:319:
+static inline s32 txgbe_mac_set_vfta_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, bool TUP3, bool TUP4)

WARNING:LONG_LINE: line over 100 characters
#398: FILE: drivers/net/txgbe/base/txgbe_dummy.h:323:
+static inline s32 txgbe_mac_set_vlvf_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, bool TUP3, u32 *TUP4, u32 TUP5, bool TUP6)

WARNING:RETURN_VOID: void function return statements are not generally useful
#409: FILE: drivers/net/txgbe/base/txgbe_dummy.h:334:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#410: FILE: drivers/net/txgbe/base/txgbe_dummy.h:335:
+static inline void txgbe_mac_set_vlan_anti_spoofing_dummy(struct txgbe_hw *TUP0, bool TUP1, int TUP2)

WARNING:RETURN_VOID: void function return statements are not generally useful
#413: FILE: drivers/net/txgbe/base/txgbe_dummy.h:338:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#433: FILE: drivers/net/txgbe/base/txgbe_dummy.h:358:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#434: FILE: drivers/net/txgbe/base/txgbe_dummy.h:359:
+static inline s32 txgbe_mac_set_fw_drv_ver_dummy(struct txgbe_hw *TUP0, u8 TUP1, u8 TUP2, u8 TUP3, u8 TUP4, u16 TUP5, const char *TUP6)

WARNING:RETURN_VOID: void function return statements are not generally useful
#449: FILE: drivers/net/txgbe/base/txgbe_dummy.h:374:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#453: FILE: drivers/net/txgbe/base/txgbe_dummy.h:378:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#457: FILE: drivers/net/txgbe/base/txgbe_dummy.h:382:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#458: FILE: drivers/net/txgbe/base/txgbe_dummy.h:383:
+static inline void txgbe_mac_set_source_address_pruning_dummy(struct txgbe_hw *TUP0, bool TUP1, unsigned int TUP2)

WARNING:RETURN_VOID: void function return statements are not generally useful
#461: FILE: drivers/net/txgbe/base/txgbe_dummy.h:386:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#462: FILE: drivers/net/txgbe/base/txgbe_dummy.h:387:
+static inline void txgbe_mac_set_ethertype_anti_spoofing_dummy(struct txgbe_hw *TUP0, bool TUP1, int TUP2)

WARNING:RETURN_VOID: void function return statements are not generally useful
#465: FILE: drivers/net/txgbe/base/txgbe_dummy.h:390:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#482: FILE: drivers/net/txgbe/base/txgbe_dummy.h:407:
+static inline s32 txgbe_mac_read_iosf_sb_reg_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, u32 *TUP3)

WARNING:LONG_LINE: line over 100 characters
#486: FILE: drivers/net/txgbe/base/txgbe_dummy.h:411:
+static inline s32 txgbe_mac_write_iosf_sb_reg_dummy(struct txgbe_hw *TUP0, u32 TUP1, u32 TUP2, u32 TUP3)

WARNING:RETURN_VOID: void function return statements are not generally useful
#493: FILE: drivers/net/txgbe/base/txgbe_dummy.h:418:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#497: FILE: drivers/net/txgbe/base/txgbe_dummy.h:422:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#501: FILE: drivers/net/txgbe/base/txgbe_dummy.h:426:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#505: FILE: drivers/net/txgbe/base/txgbe_dummy.h:430:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#591: FILE: drivers/net/txgbe/base/txgbe_dummy.h:516:
+	return;
+}

WARNING:LONG_LINE: line over 100 characters
#608: FILE: drivers/net/txgbe/base/txgbe_dummy.h:533:
+static inline s32 txgbe_phy_read_i2c_byte_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u8 TUP2, u8 *TUP3)

WARNING:LONG_LINE: line over 100 characters
#612: FILE: drivers/net/txgbe/base/txgbe_dummy.h:537:
+static inline s32 txgbe_phy_write_i2c_byte_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u8 TUP2, u8 TUP3)

WARNING:LONG_LINE: line over 100 characters
#622: FILE: drivers/net/txgbe/base/txgbe_dummy.h:547:
+static inline s32 txgbe_link_read_link_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u16 TUP2, u16 *TUP3)

WARNING:LONG_LINE: line over 100 characters
#630: FILE: drivers/net/txgbe/base/txgbe_dummy.h:555:
+static inline s32 txgbe_link_write_link_unlocked_dummy(struct txgbe_hw *TUP0, u8 TUP1, u16 TUP2, u16 TUP3)

WARNING:RETURN_VOID: void function return statements are not generally useful
#639: FILE: drivers/net/txgbe/base/txgbe_dummy.h:564:
+	return;
+}

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#859: FILE: drivers/net/txgbe/base/txgbe_type.h:152:
+	s32 (*read_link)(struct txgbe_hw *, u8 addr, u16 reg, u16 *val);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#860: FILE: drivers/net/txgbe/base/txgbe_type.h:153:
+	s32 (*read_link_unlocked)(struct txgbe_hw *, u8 addr, u16 reg,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#862: FILE: drivers/net/txgbe/base/txgbe_type.h:155:
+	s32 (*write_link)(struct txgbe_hw *, u8 addr, u16 reg, u16 val);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#863: FILE: drivers/net/txgbe/base/txgbe_type.h:156:
+	s32 (*write_link_unlocked)(struct txgbe_hw *, u8 addr, u16 reg,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#870: FILE: drivers/net/txgbe/base/txgbe_type.h:163:
+	s32 (*init_params)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#871: FILE: drivers/net/txgbe/base/txgbe_type.h:164:
+	s32 (*read16)(struct txgbe_hw *, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#871: FILE: drivers/net/txgbe/base/txgbe_type.h:164:
+	s32 (*read16)(struct txgbe_hw *, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#871: FILE: drivers/net/txgbe/base/txgbe_type.h:164:
+	s32 (*read16)(struct txgbe_hw *, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#872: FILE: drivers/net/txgbe/base/txgbe_type.h:165:
+	s32 (*readw_sw)(struct txgbe_hw *, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#872: FILE: drivers/net/txgbe/base/txgbe_type.h:165:
+	s32 (*readw_sw)(struct txgbe_hw *, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#872: FILE: drivers/net/txgbe/base/txgbe_type.h:165:
+	s32 (*readw_sw)(struct txgbe_hw *, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#873: FILE: drivers/net/txgbe/base/txgbe_type.h:166:
+	s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#873: FILE: drivers/net/txgbe/base/txgbe_type.h:166:
+	s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#873: FILE: drivers/net/txgbe/base/txgbe_type.h:166:
+	s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#873: FILE: drivers/net/txgbe/base/txgbe_type.h:166:
+	s32 (*readw_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#874: FILE: drivers/net/txgbe/base/txgbe_type.h:167:
+	s32 (*read32)(struct txgbe_hw *, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#874: FILE: drivers/net/txgbe/base/txgbe_type.h:167:
+	s32 (*read32)(struct txgbe_hw *, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#874: FILE: drivers/net/txgbe/base/txgbe_type.h:167:
+	s32 (*read32)(struct txgbe_hw *, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#875: FILE: drivers/net/txgbe/base/txgbe_type.h:168:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#875: FILE: drivers/net/txgbe/base/txgbe_type.h:168:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#875: FILE: drivers/net/txgbe/base/txgbe_type.h:168:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#875: FILE: drivers/net/txgbe/base/txgbe_type.h:168:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#876: FILE: drivers/net/txgbe/base/txgbe_type.h:169:
+	s32 (*write16)(struct txgbe_hw *, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#876: FILE: drivers/net/txgbe/base/txgbe_type.h:169:
+	s32 (*write16)(struct txgbe_hw *, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#876: FILE: drivers/net/txgbe/base/txgbe_type.h:169:
+	s32 (*write16)(struct txgbe_hw *, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#877: FILE: drivers/net/txgbe/base/txgbe_type.h:170:
+	s32 (*writew_sw)(struct txgbe_hw *, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#877: FILE: drivers/net/txgbe/base/txgbe_type.h:170:
+	s32 (*writew_sw)(struct txgbe_hw *, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#877: FILE: drivers/net/txgbe/base/txgbe_type.h:170:
+	s32 (*writew_sw)(struct txgbe_hw *, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#878: FILE: drivers/net/txgbe/base/txgbe_type.h:171:
+	s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#878: FILE: drivers/net/txgbe/base/txgbe_type.h:171:
+	s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#878: FILE: drivers/net/txgbe/base/txgbe_type.h:171:
+	s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#878: FILE: drivers/net/txgbe/base/txgbe_type.h:171:
+	s32 (*writew_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#879: FILE: drivers/net/txgbe/base/txgbe_type.h:172:
+	s32 (*write32)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#879: FILE: drivers/net/txgbe/base/txgbe_type.h:172:
+	s32 (*write32)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#879: FILE: drivers/net/txgbe/base/txgbe_type.h:172:
+	s32 (*write32)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#880: FILE: drivers/net/txgbe/base/txgbe_type.h:173:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#880: FILE: drivers/net/txgbe/base/txgbe_type.h:173:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#880: FILE: drivers/net/txgbe/base/txgbe_type.h:173:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#880: FILE: drivers/net/txgbe/base/txgbe_type.h:173:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#881: FILE: drivers/net/txgbe/base/txgbe_type.h:174:
+	s32 (*validate_checksum)(struct txgbe_hw *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#881: FILE: drivers/net/txgbe/base/txgbe_type.h:174:
+	s32 (*validate_checksum)(struct txgbe_hw *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#882: FILE: drivers/net/txgbe/base/txgbe_type.h:175:
+	s32 (*update_checksum)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#883: FILE: drivers/net/txgbe/base/txgbe_type.h:176:
+	s32 (*calc_checksum)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#888: FILE: drivers/net/txgbe/base/txgbe_type.h:181:
+	s32 (*init_params)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#889: FILE: drivers/net/txgbe/base/txgbe_type.h:182:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#889: FILE: drivers/net/txgbe/base/txgbe_type.h:182:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#889: FILE: drivers/net/txgbe/base/txgbe_type.h:182:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#889: FILE: drivers/net/txgbe/base/txgbe_type.h:182:
+	s32 (*read_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#890: FILE: drivers/net/txgbe/base/txgbe_type.h:183:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#890: FILE: drivers/net/txgbe/base/txgbe_type.h:183:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#890: FILE: drivers/net/txgbe/base/txgbe_type.h:183:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#890: FILE: drivers/net/txgbe/base/txgbe_type.h:183:
+	s32 (*write_buffer)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#897: FILE: drivers/net/txgbe/base/txgbe_type.h:190:
+	s32 (*init_hw)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#898: FILE: drivers/net/txgbe/base/txgbe_type.h:191:
+	s32 (*reset_hw)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#899: FILE: drivers/net/txgbe/base/txgbe_type.h:192:
+	s32 (*start_hw)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#900: FILE: drivers/net/txgbe/base/txgbe_type.h:193:
+	s32 (*stop_hw)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#901: FILE: drivers/net/txgbe/base/txgbe_type.h:194:
+	s32 (*clear_hw_cntrs)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#902: FILE: drivers/net/txgbe/base/txgbe_type.h:195:
+	void (*enable_relaxed_ordering)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#903: FILE: drivers/net/txgbe/base/txgbe_type.h:196:
+	u64 (*get_supported_physical_layer)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#904: FILE: drivers/net/txgbe/base/txgbe_type.h:197:
+	s32 (*get_mac_addr)(struct txgbe_hw *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#904: FILE: drivers/net/txgbe/base/txgbe_type.h:197:
+	s32 (*get_mac_addr)(struct txgbe_hw *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#905: FILE: drivers/net/txgbe/base/txgbe_type.h:198:
+	s32 (*get_san_mac_addr)(struct txgbe_hw *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#905: FILE: drivers/net/txgbe/base/txgbe_type.h:198:
+	s32 (*get_san_mac_addr)(struct txgbe_hw *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#906: FILE: drivers/net/txgbe/base/txgbe_type.h:199:
+	s32 (*set_san_mac_addr)(struct txgbe_hw *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#906: FILE: drivers/net/txgbe/base/txgbe_type.h:199:
+	s32 (*set_san_mac_addr)(struct txgbe_hw *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#907: FILE: drivers/net/txgbe/base/txgbe_type.h:200:
+	s32 (*get_device_caps)(struct txgbe_hw *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#907: FILE: drivers/net/txgbe/base/txgbe_type.h:200:
+	s32 (*get_device_caps)(struct txgbe_hw *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#908: FILE: drivers/net/txgbe/base/txgbe_type.h:201:
+	s32 (*get_wwn_prefix)(struct txgbe_hw *, u16 *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#908: FILE: drivers/net/txgbe/base/txgbe_type.h:201:
+	s32 (*get_wwn_prefix)(struct txgbe_hw *, u16 *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#908: FILE: drivers/net/txgbe/base/txgbe_type.h:201:
+	s32 (*get_wwn_prefix)(struct txgbe_hw *, u16 *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#909: FILE: drivers/net/txgbe/base/txgbe_type.h:202:
+	s32 (*get_fcoe_boot_status)(struct txgbe_hw *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#909: FILE: drivers/net/txgbe/base/txgbe_type.h:202:
+	s32 (*get_fcoe_boot_status)(struct txgbe_hw *, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw*' should also have an identifier name
#910: FILE: drivers/net/txgbe/base/txgbe_type.h:203:
+	s32 (*read_analog_reg8)(struct txgbe_hw*, u32, u8*);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#910: FILE: drivers/net/txgbe/base/txgbe_type.h:203:
+	s32 (*read_analog_reg8)(struct txgbe_hw*, u32, u8*);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8*' should also have an identifier name
#910: FILE: drivers/net/txgbe/base/txgbe_type.h:203:
+	s32 (*read_analog_reg8)(struct txgbe_hw*, u32, u8*);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw*' should also have an identifier name
#911: FILE: drivers/net/txgbe/base/txgbe_type.h:204:
+	s32 (*write_analog_reg8)(struct txgbe_hw*, u32, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#911: FILE: drivers/net/txgbe/base/txgbe_type.h:204:
+	s32 (*write_analog_reg8)(struct txgbe_hw*, u32, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#911: FILE: drivers/net/txgbe/base/txgbe_type.h:204:
+	s32 (*write_analog_reg8)(struct txgbe_hw*, u32, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#912: FILE: drivers/net/txgbe/base/txgbe_type.h:205:
+	s32 (*setup_sfp)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#913: FILE: drivers/net/txgbe/base/txgbe_type.h:206:
+	s32 (*enable_rx_dma)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#913: FILE: drivers/net/txgbe/base/txgbe_type.h:206:
+	s32 (*enable_rx_dma)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#914: FILE: drivers/net/txgbe/base/txgbe_type.h:207:
+	s32 (*disable_sec_rx_path)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#915: FILE: drivers/net/txgbe/base/txgbe_type.h:208:
+	s32 (*enable_sec_rx_path)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#916: FILE: drivers/net/txgbe/base/txgbe_type.h:209:
+	s32 (*disable_sec_tx_path)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#917: FILE: drivers/net/txgbe/base/txgbe_type.h:210:
+	s32 (*enable_sec_tx_path)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#918: FILE: drivers/net/txgbe/base/txgbe_type.h:211:
+	s32 (*acquire_swfw_sync)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#918: FILE: drivers/net/txgbe/base/txgbe_type.h:211:
+	s32 (*acquire_swfw_sync)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#919: FILE: drivers/net/txgbe/base/txgbe_type.h:212:
+	void (*release_swfw_sync)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#919: FILE: drivers/net/txgbe/base/txgbe_type.h:212:
+	void (*release_swfw_sync)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#920: FILE: drivers/net/txgbe/base/txgbe_type.h:213:
+	void (*init_swfw_sync)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#921: FILE: drivers/net/txgbe/base/txgbe_type.h:214:
+	u64 (*autoc_read)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#922: FILE: drivers/net/txgbe/base/txgbe_type.h:215:
+	void (*autoc_write)(struct txgbe_hw *, u64);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u64' should also have an identifier name
#922: FILE: drivers/net/txgbe/base/txgbe_type.h:215:
+	void (*autoc_write)(struct txgbe_hw *, u64);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#923: FILE: drivers/net/txgbe/base/txgbe_type.h:216:
+	s32 (*prot_autoc_read)(struct txgbe_hw *, bool *, u64 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name
#923: FILE: drivers/net/txgbe/base/txgbe_type.h:216:
+	s32 (*prot_autoc_read)(struct txgbe_hw *, bool *, u64 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u64 *' should also have an identifier name
#923: FILE: drivers/net/txgbe/base/txgbe_type.h:216:
+	s32 (*prot_autoc_read)(struct txgbe_hw *, bool *, u64 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#924: FILE: drivers/net/txgbe/base/txgbe_type.h:217:
+	s32 (*prot_autoc_write)(struct txgbe_hw *, bool, u64);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#924: FILE: drivers/net/txgbe/base/txgbe_type.h:217:
+	s32 (*prot_autoc_write)(struct txgbe_hw *, bool, u64);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u64' should also have an identifier name
#924: FILE: drivers/net/txgbe/base/txgbe_type.h:217:
+	s32 (*prot_autoc_write)(struct txgbe_hw *, bool, u64);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#928: FILE: drivers/net/txgbe/base/txgbe_type.h:221:
+	void (*disable_tx_laser)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#929: FILE: drivers/net/txgbe/base/txgbe_type.h:222:
+	void (*enable_tx_laser)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#930: FILE: drivers/net/txgbe/base/txgbe_type.h:223:
+	void (*flap_tx_laser)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#931: FILE: drivers/net/txgbe/base/txgbe_type.h:224:
+	s32 (*setup_link)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#931: FILE: drivers/net/txgbe/base/txgbe_type.h:224:
+	s32 (*setup_link)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#931: FILE: drivers/net/txgbe/base/txgbe_type.h:224:
+	s32 (*setup_link)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#932: FILE: drivers/net/txgbe/base/txgbe_type.h:225:
+	s32 (*setup_mac_link)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#932: FILE: drivers/net/txgbe/base/txgbe_type.h:225:
+	s32 (*setup_mac_link)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#932: FILE: drivers/net/txgbe/base/txgbe_type.h:225:
+	s32 (*setup_mac_link)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#933: FILE: drivers/net/txgbe/base/txgbe_type.h:226:
+	s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#933: FILE: drivers/net/txgbe/base/txgbe_type.h:226:
+	s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name
#933: FILE: drivers/net/txgbe/base/txgbe_type.h:226:
+	s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#933: FILE: drivers/net/txgbe/base/txgbe_type.h:226:
+	s32 (*check_link)(struct txgbe_hw *, u32 *, bool *, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#934: FILE: drivers/net/txgbe/base/txgbe_type.h:227:
+	s32 (*get_link_capabilities)(struct txgbe_hw *, u32 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#934: FILE: drivers/net/txgbe/base/txgbe_type.h:227:
+	s32 (*get_link_capabilities)(struct txgbe_hw *, u32 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name
#934: FILE: drivers/net/txgbe/base/txgbe_type.h:227:
+	s32 (*get_link_capabilities)(struct txgbe_hw *, u32 *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#936: FILE: drivers/net/txgbe/base/txgbe_type.h:229:
+	void (*set_rate_select_speed)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#936: FILE: drivers/net/txgbe/base/txgbe_type.h:229:
+	void (*set_rate_select_speed)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#939: FILE: drivers/net/txgbe/base/txgbe_type.h:232:
+	void (*setup_pba)(struct txgbe_hw *, int, u32, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#939: FILE: drivers/net/txgbe/base/txgbe_type.h:232:
+	void (*setup_pba)(struct txgbe_hw *, int, u32, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#939: FILE: drivers/net/txgbe/base/txgbe_type.h:232:
+	void (*setup_pba)(struct txgbe_hw *, int, u32, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#939: FILE: drivers/net/txgbe/base/txgbe_type.h:232:
+	void (*setup_pba)(struct txgbe_hw *, int, u32, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#942: FILE: drivers/net/txgbe/base/txgbe_type.h:235:
+	s32 (*led_on)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#942: FILE: drivers/net/txgbe/base/txgbe_type.h:235:
+	s32 (*led_on)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#943: FILE: drivers/net/txgbe/base/txgbe_type.h:236:
+	s32 (*led_off)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#943: FILE: drivers/net/txgbe/base/txgbe_type.h:236:
+	s32 (*led_off)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#944: FILE: drivers/net/txgbe/base/txgbe_type.h:237:
+	s32 (*blink_led_start)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#944: FILE: drivers/net/txgbe/base/txgbe_type.h:237:
+	s32 (*blink_led_start)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#945: FILE: drivers/net/txgbe/base/txgbe_type.h:238:
+	s32 (*blink_led_stop)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#945: FILE: drivers/net/txgbe/base/txgbe_type.h:238:
+	s32 (*blink_led_stop)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#946: FILE: drivers/net/txgbe/base/txgbe_type.h:239:
+	s32 (*init_led_link_act)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#949: FILE: drivers/net/txgbe/base/txgbe_type.h:242:
+	s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#949: FILE: drivers/net/txgbe/base/txgbe_type.h:242:
+	s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#949: FILE: drivers/net/txgbe/base/txgbe_type.h:242:
+	s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#949: FILE: drivers/net/txgbe/base/txgbe_type.h:242:
+	s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#949: FILE: drivers/net/txgbe/base/txgbe_type.h:242:
+	s32 (*set_rar)(struct txgbe_hw *, u32, u8 *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#950: FILE: drivers/net/txgbe/base/txgbe_type.h:243:
+	s32 (*set_uc_addr)(struct txgbe_hw *, u32, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#950: FILE: drivers/net/txgbe/base/txgbe_type.h:243:
+	s32 (*set_uc_addr)(struct txgbe_hw *, u32, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#950: FILE: drivers/net/txgbe/base/txgbe_type.h:243:
+	s32 (*set_uc_addr)(struct txgbe_hw *, u32, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#951: FILE: drivers/net/txgbe/base/txgbe_type.h:244:
+	s32 (*clear_rar)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#951: FILE: drivers/net/txgbe/base/txgbe_type.h:244:
+	s32 (*clear_rar)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#952: FILE: drivers/net/txgbe/base/txgbe_type.h:245:
+	s32 (*insert_mac_addr)(struct txgbe_hw *, u8 *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#952: FILE: drivers/net/txgbe/base/txgbe_type.h:245:
+	s32 (*insert_mac_addr)(struct txgbe_hw *, u8 *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#952: FILE: drivers/net/txgbe/base/txgbe_type.h:245:
+	s32 (*insert_mac_addr)(struct txgbe_hw *, u8 *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#953: FILE: drivers/net/txgbe/base/txgbe_type.h:246:
+	s32 (*set_vmdq)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#953: FILE: drivers/net/txgbe/base/txgbe_type.h:246:
+	s32 (*set_vmdq)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#953: FILE: drivers/net/txgbe/base/txgbe_type.h:246:
+	s32 (*set_vmdq)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#954: FILE: drivers/net/txgbe/base/txgbe_type.h:247:
+	s32 (*set_vmdq_san_mac)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#954: FILE: drivers/net/txgbe/base/txgbe_type.h:247:
+	s32 (*set_vmdq_san_mac)(struct txgbe_hw *, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#955: FILE: drivers/net/txgbe/base/txgbe_type.h:248:
+	s32 (*clear_vmdq)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#955: FILE: drivers/net/txgbe/base/txgbe_type.h:248:
+	s32 (*clear_vmdq)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#955: FILE: drivers/net/txgbe/base/txgbe_type.h:248:
+	s32 (*clear_vmdq)(struct txgbe_hw *, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#956: FILE: drivers/net/txgbe/base/txgbe_type.h:249:
+	s32 (*init_rx_addrs)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#957: FILE: drivers/net/txgbe/base/txgbe_type.h:250:
+	s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#957: FILE: drivers/net/txgbe/base/txgbe_type.h:250:
+	s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#957: FILE: drivers/net/txgbe/base/txgbe_type.h:250:
+	s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'txgbe_mc_addr_itr' should also have an identifier name
#957: FILE: drivers/net/txgbe/base/txgbe_type.h:250:
+	s32 (*update_uc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#959: FILE: drivers/net/txgbe/base/txgbe_type.h:252:
+	s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#959: FILE: drivers/net/txgbe/base/txgbe_type.h:252:
+	s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#959: FILE: drivers/net/txgbe/base/txgbe_type.h:252:
+	s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'txgbe_mc_addr_itr' should also have an identifier name
#959: FILE: drivers/net/txgbe/base/txgbe_type.h:252:
+	s32 (*update_mc_addr_list)(struct txgbe_hw *, u8 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#961: FILE: drivers/net/txgbe/base/txgbe_type.h:254:
+	s32 (*enable_mc)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#962: FILE: drivers/net/txgbe/base/txgbe_type.h:255:
+	s32 (*disable_mc)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#963: FILE: drivers/net/txgbe/base/txgbe_type.h:256:
+	s32 (*clear_vfta)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#964: FILE: drivers/net/txgbe/base/txgbe_type.h:257:
+	s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#964: FILE: drivers/net/txgbe/base/txgbe_type.h:257:
+	s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#964: FILE: drivers/net/txgbe/base/txgbe_type.h:257:
+	s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#964: FILE: drivers/net/txgbe/base/txgbe_type.h:257:
+	s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#964: FILE: drivers/net/txgbe/base/txgbe_type.h:257:
+	s32 (*set_vfta)(struct txgbe_hw *, u32, u32, bool, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#965: FILE: drivers/net/txgbe/base/txgbe_type.h:258:
+	s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#965: FILE: drivers/net/txgbe/base/txgbe_type.h:258:
+	s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#965: FILE: drivers/net/txgbe/base/txgbe_type.h:258:
+	s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#965: FILE: drivers/net/txgbe/base/txgbe_type.h:258:
+	s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#965: FILE: drivers/net/txgbe/base/txgbe_type.h:258:
+	s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#965: FILE: drivers/net/txgbe/base/txgbe_type.h:258:
+	s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#965: FILE: drivers/net/txgbe/base/txgbe_type.h:258:
+	s32 (*set_vlvf)(struct txgbe_hw *, u32, u32, bool, u32 *, u32,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#967: FILE: drivers/net/txgbe/base/txgbe_type.h:260:
+	s32 (*init_uta_tables)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#968: FILE: drivers/net/txgbe/base/txgbe_type.h:261:
+	void (*set_mac_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#968: FILE: drivers/net/txgbe/base/txgbe_type.h:261:
+	void (*set_mac_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#968: FILE: drivers/net/txgbe/base/txgbe_type.h:261:
+	void (*set_mac_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#969: FILE: drivers/net/txgbe/base/txgbe_type.h:262:
+	void (*set_vlan_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#969: FILE: drivers/net/txgbe/base/txgbe_type.h:262:
+	void (*set_vlan_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#969: FILE: drivers/net/txgbe/base/txgbe_type.h:262:
+	void (*set_vlan_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#970: FILE: drivers/net/txgbe/base/txgbe_type.h:263:
+	s32 (*update_xcast_mode)(struct txgbe_hw *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#970: FILE: drivers/net/txgbe/base/txgbe_type.h:263:
+	s32 (*update_xcast_mode)(struct txgbe_hw *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#971: FILE: drivers/net/txgbe/base/txgbe_type.h:264:
+	s32 (*set_rlpml)(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#971: FILE: drivers/net/txgbe/base/txgbe_type.h:264:
+	s32 (*set_rlpml)(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#974: FILE: drivers/net/txgbe/base/txgbe_type.h:267:
+	s32 (*fc_enable)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#975: FILE: drivers/net/txgbe/base/txgbe_type.h:268:
+	s32 (*setup_fc)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#976: FILE: drivers/net/txgbe/base/txgbe_type.h:269:
+	void (*fc_autoneg)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#979: FILE: drivers/net/txgbe/base/txgbe_type.h:272:
+	s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#979: FILE: drivers/net/txgbe/base/txgbe_type.h:272:
+	s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#979: FILE: drivers/net/txgbe/base/txgbe_type.h:272:
+	s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#979: FILE: drivers/net/txgbe/base/txgbe_type.h:272:
+	s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#979: FILE: drivers/net/txgbe/base/txgbe_type.h:272:
+	s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#979: FILE: drivers/net/txgbe/base/txgbe_type.h:272:
+	s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const char *' should also have an identifier name
#979: FILE: drivers/net/txgbe/base/txgbe_type.h:272:
+	s32 (*set_fw_drv_ver)(struct txgbe_hw *, u8, u8, u8, u8, u16,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#981: FILE: drivers/net/txgbe/base/txgbe_type.h:274:
+	s32 (*get_thermal_sensor_data)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#986: FILE: drivers/net/txgbe/base/txgbe_type.h:279:
+	void (*set_source_address_pruning)(struct txgbe_hw *, bool,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#986: FILE: drivers/net/txgbe/base/txgbe_type.h:279:
+	void (*set_source_address_pruning)(struct txgbe_hw *, bool,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name
#986: FILE: drivers/net/txgbe/base/txgbe_type.h:279:
+	void (*set_source_address_pruning)(struct txgbe_hw *, bool,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#988: FILE: drivers/net/txgbe/base/txgbe_type.h:281:
+	void (*set_ethertype_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#988: FILE: drivers/net/txgbe/base/txgbe_type.h:281:
+	void (*set_ethertype_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#988: FILE: drivers/net/txgbe/base/txgbe_type.h:281:
+	void (*set_ethertype_anti_spoofing)(struct txgbe_hw *, bool, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#993: FILE: drivers/net/txgbe/base/txgbe_type.h:286:
+	s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#993: FILE: drivers/net/txgbe/base/txgbe_type.h:286:
+	s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#993: FILE: drivers/net/txgbe/base/txgbe_type.h:286:
+	s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#993: FILE: drivers/net/txgbe/base/txgbe_type.h:286:
+	s32 (*read_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#994: FILE: drivers/net/txgbe/base/txgbe_type.h:287:
+	s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#994: FILE: drivers/net/txgbe/base/txgbe_type.h:287:
+	s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#994: FILE: drivers/net/txgbe/base/txgbe_type.h:287:
+	s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#994: FILE: drivers/net/txgbe/base/txgbe_type.h:287:
+	s32 (*write_iosf_sb_reg)(struct txgbe_hw *, u32, u32, u32);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1008: FILE: drivers/net/txgbe/base/txgbe_type.h:301:
+	u32 (*get_media_type)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1009: FILE: drivers/net/txgbe/base/txgbe_type.h:302:
+	s32 (*identify)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1010: FILE: drivers/net/txgbe/base/txgbe_type.h:303:
+	s32 (*identify_sfp)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1011: FILE: drivers/net/txgbe/base/txgbe_type.h:304:
+	s32 (*init)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1012: FILE: drivers/net/txgbe/base/txgbe_type.h:305:
+	s32 (*reset)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1013: FILE: drivers/net/txgbe/base/txgbe_type.h:306:
+	s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1013: FILE: drivers/net/txgbe/base/txgbe_type.h:306:
+	s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1013: FILE: drivers/net/txgbe/base/txgbe_type.h:306:
+	s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#1013: FILE: drivers/net/txgbe/base/txgbe_type.h:306:
+	s32 (*read_reg)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1014: FILE: drivers/net/txgbe/base/txgbe_type.h:307:
+	s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1014: FILE: drivers/net/txgbe/base/txgbe_type.h:307:
+	s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1014: FILE: drivers/net/txgbe/base/txgbe_type.h:307:
+	s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1014: FILE: drivers/net/txgbe/base/txgbe_type.h:307:
+	s32 (*write_reg)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1015: FILE: drivers/net/txgbe/base/txgbe_type.h:308:
+	s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1015: FILE: drivers/net/txgbe/base/txgbe_type.h:308:
+	s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1015: FILE: drivers/net/txgbe/base/txgbe_type.h:308:
+	s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#1015: FILE: drivers/net/txgbe/base/txgbe_type.h:308:
+	s32 (*read_reg_mdi)(struct txgbe_hw *, u32, u32, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1016: FILE: drivers/net/txgbe/base/txgbe_type.h:309:
+	s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1016: FILE: drivers/net/txgbe/base/txgbe_type.h:309:
+	s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1016: FILE: drivers/net/txgbe/base/txgbe_type.h:309:
+	s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1016: FILE: drivers/net/txgbe/base/txgbe_type.h:309:
+	s32 (*write_reg_mdi)(struct txgbe_hw *, u32, u32, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1017: FILE: drivers/net/txgbe/base/txgbe_type.h:310:
+	s32 (*setup_link)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1018: FILE: drivers/net/txgbe/base/txgbe_type.h:311:
+	s32 (*setup_internal_link)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1019: FILE: drivers/net/txgbe/base/txgbe_type.h:312:
+	s32 (*setup_link_speed)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#1019: FILE: drivers/net/txgbe/base/txgbe_type.h:312:
+	s32 (*setup_link_speed)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool' should also have an identifier name
#1019: FILE: drivers/net/txgbe/base/txgbe_type.h:312:
+	s32 (*setup_link_speed)(struct txgbe_hw *, u32, bool);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1020: FILE: drivers/net/txgbe/base/txgbe_type.h:313:
+	s32 (*check_link)(struct txgbe_hw *, u32 *, bool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#1020: FILE: drivers/net/txgbe/base/txgbe_type.h:313:
+	s32 (*check_link)(struct txgbe_hw *, u32 *, bool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'bool *' should also have an identifier name
#1020: FILE: drivers/net/txgbe/base/txgbe_type.h:313:
+	s32 (*check_link)(struct txgbe_hw *, u32 *, bool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1021: FILE: drivers/net/txgbe/base/txgbe_type.h:314:
+	s32 (*get_firmware_version)(struct txgbe_hw *, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#1021: FILE: drivers/net/txgbe/base/txgbe_type.h:314:
+	s32 (*get_firmware_version)(struct txgbe_hw *, u32 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1022: FILE: drivers/net/txgbe/base/txgbe_type.h:315:
+	s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1022: FILE: drivers/net/txgbe/base/txgbe_type.h:315:
+	s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1022: FILE: drivers/net/txgbe/base/txgbe_type.h:315:
+	s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#1022: FILE: drivers/net/txgbe/base/txgbe_type.h:315:
+	s32 (*read_i2c_byte)(struct txgbe_hw *, u8, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1023: FILE: drivers/net/txgbe/base/txgbe_type.h:316:
+	s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1023: FILE: drivers/net/txgbe/base/txgbe_type.h:316:
+	s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1023: FILE: drivers/net/txgbe/base/txgbe_type.h:316:
+	s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1023: FILE: drivers/net/txgbe/base/txgbe_type.h:316:
+	s32 (*write_i2c_byte)(struct txgbe_hw *, u8, u8, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1024: FILE: drivers/net/txgbe/base/txgbe_type.h:317:
+	s32 (*read_i2c_sff8472)(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1024: FILE: drivers/net/txgbe/base/txgbe_type.h:317:
+	s32 (*read_i2c_sff8472)(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#1024: FILE: drivers/net/txgbe/base/txgbe_type.h:317:
+	s32 (*read_i2c_sff8472)(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1025: FILE: drivers/net/txgbe/base/txgbe_type.h:318:
+	s32 (*read_i2c_eeprom)(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1025: FILE: drivers/net/txgbe/base/txgbe_type.h:318:
+	s32 (*read_i2c_eeprom)(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#1025: FILE: drivers/net/txgbe/base/txgbe_type.h:318:
+	s32 (*read_i2c_eeprom)(struct txgbe_hw *, u8, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1026: FILE: drivers/net/txgbe/base/txgbe_type.h:319:
+	s32 (*write_i2c_eeprom)(struct txgbe_hw *, u8, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1026: FILE: drivers/net/txgbe/base/txgbe_type.h:319:
+	s32 (*write_i2c_eeprom)(struct txgbe_hw *, u8, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8' should also have an identifier name
#1026: FILE: drivers/net/txgbe/base/txgbe_type.h:319:
+	s32 (*write_i2c_eeprom)(struct txgbe_hw *, u8, u8);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1027: FILE: drivers/net/txgbe/base/txgbe_type.h:320:
+	void (*i2c_bus_clear)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1028: FILE: drivers/net/txgbe/base/txgbe_type.h:321:
+	s32 (*check_overtemp)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1029: FILE: drivers/net/txgbe/base/txgbe_type.h:322:
+	s32 (*set_phy_power)(struct txgbe_hw *, bool on);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1030: FILE: drivers/net/txgbe/base/txgbe_type.h:323:
+	s32 (*enter_lplu)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1032: FILE: drivers/net/txgbe/base/txgbe_type.h:325:
+	s32 (*read_i2c_byte_unlocked)(struct txgbe_hw *, u8 offset, u8 addr,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1034: FILE: drivers/net/txgbe/base/txgbe_type.h:327:
+	s32 (*write_i2c_byte_unlocked)(struct txgbe_hw *, u8 offset, u8 addr,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1044: FILE: drivers/net/txgbe/base/txgbe_type.h:337:
+	s32  (*read)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#1044: FILE: drivers/net/txgbe/base/txgbe_type.h:337:
+	s32  (*read)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1044: FILE: drivers/net/txgbe/base/txgbe_type.h:337:
+	s32  (*read)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1044: FILE: drivers/net/txgbe/base/txgbe_type.h:337:
+	s32  (*read)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1045: FILE: drivers/net/txgbe/base/txgbe_type.h:338:
+	s32  (*write)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#1045: FILE: drivers/net/txgbe/base/txgbe_type.h:338:
+	s32  (*write)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1045: FILE: drivers/net/txgbe/base/txgbe_type.h:338:
+	s32  (*write)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1045: FILE: drivers/net/txgbe/base/txgbe_type.h:338:
+	s32  (*write)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1046: FILE: drivers/net/txgbe/base/txgbe_type.h:339:
+	s32  (*read_posted)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#1046: FILE: drivers/net/txgbe/base/txgbe_type.h:339:
+	s32  (*read_posted)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1046: FILE: drivers/net/txgbe/base/txgbe_type.h:339:
+	s32  (*read_posted)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1046: FILE: drivers/net/txgbe/base/txgbe_type.h:339:
+	s32  (*read_posted)(struct txgbe_hw *, u32 *, u16,  u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1047: FILE: drivers/net/txgbe/base/txgbe_type.h:340:
+	s32  (*write_posted)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#1047: FILE: drivers/net/txgbe/base/txgbe_type.h:340:
+	s32  (*write_posted)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1047: FILE: drivers/net/txgbe/base/txgbe_type.h:340:
+	s32  (*write_posted)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1047: FILE: drivers/net/txgbe/base/txgbe_type.h:340:
+	s32  (*write_posted)(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1048: FILE: drivers/net/txgbe/base/txgbe_type.h:341:
+	s32  (*check_for_msg)(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1048: FILE: drivers/net/txgbe/base/txgbe_type.h:341:
+	s32  (*check_for_msg)(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1049: FILE: drivers/net/txgbe/base/txgbe_type.h:342:
+	s32  (*check_for_ack)(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1049: FILE: drivers/net/txgbe/base/txgbe_type.h:342:
+	s32  (*check_for_ack)(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#1050: FILE: drivers/net/txgbe/base/txgbe_type.h:343:
+	s32  (*check_for_rst)(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#1050: FILE: drivers/net/txgbe/base/txgbe_type.h:343:
+	s32  (*check_for_rst)(struct txgbe_hw *, u16);

total: 1 errors, 331 warnings, 0 checks, 985 lines checked
Warning in drivers/net/txgbe/base/txgbe_dummy.h:
Using compiler attribute directly


More information about the test-report mailing list