[dpdk-test-report] |WARNING| pw79625 [PATCH v2 08/56] net/txgbe: add HW init and reset operation
checkpatch at dpdk.org
checkpatch at dpdk.org
Mon Oct 5 14:13:04 CEST 2020
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79625
_coding style issues_
WARNING:TYPO_SPELLING: 'adn' may be misspelled - perhaps 'and'?
#60:
Add hardware init function adn reset operation in mac layer.
WARNING:BRACES: braces {} are not necessary for single statement blocks
#180: FILE: drivers/net/txgbe/base/txgbe_hw.c:127:
+ for (i = 0; i < poll; i++) {
+ usec_delay(100);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#226: FILE: drivers/net/txgbe/base/txgbe_hw.c:288:
+ if (i == 10) {
+ err = TXGBE_ERR_FLASH_LOADING_FAILED;
+ }
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#270: FILE: drivers/net/txgbe/base/txgbe_hw.c:332:
+ if (hw->phy.reset_disable == false)
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#318: FILE: drivers/net/txgbe/base/txgbe_hw.c:380:
+ if (hw->mac.orig_link_settings_stored == false) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_copper'
#444: FILE: drivers/net/txgbe/txgbe_ethdev.c:110:
+ if (err && (hw->phy.media_type == txgbe_media_type_copper)) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#452: FILE: drivers/net/txgbe/txgbe_ethdev.c:118:
+ if (err == TXGBE_ERR_EEPROM_VERSION) {
[...]
+ } else if (err == TXGBE_ERR_SFP_NOT_SUPPORTED)
[...]
total: 0 errors, 3 warnings, 4 checks, 374 lines checked
More information about the test-report
mailing list