[dpdk-test-report] |WARNING| pw82125 [PATCH v8 3/5] eal: replace pci-whitelist/pci-blacklist options

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Oct 25 22:16:51 CET 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/82125

_coding style issues_


WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#64: 
Subject: [dpdk-dev] [PATCH v8 3/5] eal: replace pci-whitelist/pci-blacklist

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#64: 
Subject: [dpdk-dev] [PATCH v8 3/5] eal: replace pci-whitelist/pci-blacklist

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#80: 
Replace -w / --pci-whitelist with -a / --allow options

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#81: 
and --pci-blacklist with --block.

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#113: FILE: lib/librte_eal/common/eal_common_options.c:67:
+	"w:" /* pci-whitelist (deprecated) */

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#134: FILE: lib/librte_eal/common/eal_common_options.c:111:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#134: FILE: lib/librte_eal/common/eal_common_options.c:111:
+	{OPT_PCI_BLACKLIST,     1, NULL, OPT_PCI_BLACKLIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#135: FILE: lib/librte_eal/common/eal_common_options.c:112:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#135: FILE: lib/librte_eal/common/eal_common_options.c:112:
+	{OPT_PCI_WHITELIST,     1, NULL, OPT_PCI_WHITELIST_NUM    },

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#149: FILE: lib/librte_eal/common/eal_common_options.c:1460:
+	case OPT_PCI_BLACKLIST_NUM:

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#151: FILE: lib/librte_eal/common/eal_common_options.c:1462:
+			"Option --pci-blacklist is deprecated, use -b, --block instead
");

WARNING:BRACES: braces {} are not necessary for single statement blocks
#161: FILE: lib/librte_eal/common/eal_common_options.c:1468:
+		if (eal_option_device_add(RTE_DEVTYPE_BLOCKED, optarg) < 0) {
 			return -1;
 		}

WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#170: FILE: lib/librte_eal/common/eal_common_options.c:1476:
+			"Option -w, --pci-whitelist is deprecated, use -a, --allow option instead
");

WARNING:BRACES: braces {} are not necessary for single statement blocks
#179: FILE: lib/librte_eal/common/eal_common_options.c:1482:
+		if (eal_option_device_add(RTE_DEVTYPE_ALLOWED, optarg) < 0) {
 			return -1;
 		}

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#249: FILE: lib/librte_eal/common/eal_options.h:98:
+#define OPT_PCI_BLACKLIST     "pci-blacklist"

WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#249: FILE: lib/librte_eal/common/eal_options.h:98:
+#define OPT_PCI_BLACKLIST     "pci-blacklist"

WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#250: FILE: lib/librte_eal/common/eal_options.h:99:
+	OPT_PCI_BLACKLIST_NUM,

total: 0 errors, 17 warnings, 144 lines checked


More information about the test-report mailing list