[dpdk-test-report] |WARNING| pw76048 [PATCH V1] testpmd: add eeprom/module eeprom display

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 01:18:33 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76048

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: app/test-pmd/cmdline.c:7600:
+       cmdline_fixed_string_t show;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: app/test-pmd/cmdline.c:7601:
+       cmdline_fixed_string_t type;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#98: FILE: app/test-pmd/cmdline.c:7602:
+        uint16_t portnum;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#98: FILE: app/test-pmd/cmdline.c:7602:
+        uint16_t portnum;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#102: FILE: app/test-pmd/cmdline.c:7606:
+               __rte_unused struct cmdline *cl,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#102: FILE: app/test-pmd/cmdline.c:7606:
+               __rte_unused struct cmdline *cl,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#103: FILE: app/test-pmd/cmdline.c:7607:
+               __rte_unused void *data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#103: FILE: app/test-pmd/cmdline.c:7607:
+               __rte_unused void *data)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: app/test-pmd/cmdline.c:7609:
+       struct cmd_showeeprom_result *res = parsed_result;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#107: FILE: app/test-pmd/cmdline.c:7611:
+       if (!strcmp(res->type, "eeprom"))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#107: FILE: app/test-pmd/cmdline.c:7611:
+       if (!strcmp(res->type, "eeprom"))
+               port_eeprom_display(res->portnum);

ERROR:CODE_INDENT: code indent should use tabs where possible
#108: FILE: app/test-pmd/cmdline.c:7612:
+               port_eeprom_display(res->portnum);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: app/test-pmd/cmdline.c:7612:
+               port_eeprom_display(res->portnum);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#109: FILE: app/test-pmd/cmdline.c:7613:
+       else if (!strcmp(res->type, "module_eeprom"))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#109: FILE: app/test-pmd/cmdline.c:7613:
+       else if (!strcmp(res->type, "module_eeprom"))
+               port_module_eeprom_display(res->portnum);

ERROR:CODE_INDENT: code indent should use tabs where possible
#110: FILE: app/test-pmd/cmdline.c:7614:
+               port_module_eeprom_display(res->portnum);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: app/test-pmd/cmdline.c:7614:
+               port_module_eeprom_display(res->portnum);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: app/test-pmd/cmdline.c:7618:
+       TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, show, "show");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: app/test-pmd/cmdline.c:7620:
+       TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, type, "eeprom#module_eeprom");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: app/test-pmd/cmdline.c:7622:
+       TOKEN_NUM_INITIALIZER(struct cmd_showeeprom_result, portnum, UINT16);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: app/test-pmd/cmdline.c:7625:
+       .f = cmd_showeeprom_parsed,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: app/test-pmd/cmdline.c:7626:
+       .data = NULL,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: app/test-pmd/cmdline.c:7627:
+       .help_str = "show eeprom|module_eeprom <port_id>",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#124: FILE: app/test-pmd/cmdline.c:7628:
+       .tokens = {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#125: FILE: app/test-pmd/cmdline.c:7629:
+               (void *)&cmd_showeeprom_show,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#125: FILE: app/test-pmd/cmdline.c:7629:
+               (void *)&cmd_showeeprom_show,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: app/test-pmd/cmdline.c:7630:
+               (void *)&cmd_showeeprom_type,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: app/test-pmd/cmdline.c:7630:
+               (void *)&cmd_showeeprom_type,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: app/test-pmd/cmdline.c:7631:
+               (void *)&cmd_showeeprom_portnum,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: app/test-pmd/cmdline.c:7631:
+               (void *)&cmd_showeeprom_portnum,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: app/test-pmd/cmdline.c:7632:
+               NULL,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: app/test-pmd/cmdline.c:7632:
+               NULL,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#129: FILE: app/test-pmd/cmdline.c:7633:
+       },$

ERROR:CODE_INDENT: code indent should use tabs where possible
#140: FILE: app/test-pmd/cmdline.c:19368:
+        (cmdline_parse_inst_t *)&cmd_showeeprom,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#140: FILE: app/test-pmd/cmdline.c:19368:
+        (cmdline_parse_inst_t *)&cmd_showeeprom,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: app/test-pmd/config.c:717:
+       struct rte_dev_eeprom_info einfo;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: app/test-pmd/config.c:718:
+       int ret;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#166: FILE: app/test-pmd/config.c:720:
+       if (port_id_is_invalid(port_id, ENABLED_WARN)) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#166: FILE: app/test-pmd/config.c:720:
+       if (port_id_is_invalid(port_id, ENABLED_WARN)) {
+               print_valid_ports();

ERROR:CODE_INDENT: code indent should use tabs where possible
#167: FILE: app/test-pmd/config.c:721:
+               print_valid_ports();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#167: FILE: app/test-pmd/config.c:721:
+               print_valid_ports();$

ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: app/test-pmd/config.c:722:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: app/test-pmd/config.c:722:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#169: FILE: app/test-pmd/config.c:723:
+       }$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#171: FILE: app/test-pmd/config.c:725:
+       int len_eeprom = rte_eth_dev_get_eeprom_length(port_id); $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#171: FILE: app/test-pmd/config.c:725:
+       int len_eeprom = rte_eth_dev_get_eeprom_length(port_id); $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#172: FILE: app/test-pmd/config.c:726:
+       char buf[len_eeprom];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#174: FILE: app/test-pmd/config.c:728:
+       if (len_eeprom > 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#174: FILE: app/test-pmd/config.c:728:
+       if (len_eeprom > 0) {
+               printf("
Port: %d
Module EEPROM:
", port_id);

ERROR:CODE_INDENT: code indent should use tabs where possible
#175: FILE: app/test-pmd/config.c:729:
+               printf("
Port: %d
Module EEPROM:
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#175: FILE: app/test-pmd/config.c:729:
+               printf("
Port: %d
Module EEPROM:
", port_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#177: FILE: app/test-pmd/config.c:731:
+               einfo.offset = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#177: FILE: app/test-pmd/config.c:731:
+               einfo.offset = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#178: FILE: app/test-pmd/config.c:732:
+               einfo.length = len_eeprom;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: app/test-pmd/config.c:732:
+               einfo.length = len_eeprom;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#179: FILE: app/test-pmd/config.c:733:
+               einfo.data = buf;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#179: FILE: app/test-pmd/config.c:733:
+               einfo.data = buf;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#181: FILE: app/test-pmd/config.c:735:
+               ret = rte_eth_dev_get_eeprom(port_id, &einfo);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#181: FILE: app/test-pmd/config.c:735:
+               ret = rte_eth_dev_get_eeprom(port_id, &einfo);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#182: FILE: app/test-pmd/config.c:736:
+               if (ret != 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: app/test-pmd/config.c:736:
+               if (ret != 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#182: FILE: app/test-pmd/config.c:736:
+               if (ret != 0) {
+                       switch (ret) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: app/test-pmd/config.c:737:
+                       switch (ret) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: app/test-pmd/config.c:737:
+                       switch (ret) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#184: FILE: app/test-pmd/config.c:738:
+                       case -ENODEV:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: app/test-pmd/config.c:738:
+                       case -ENODEV:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#185: FILE: app/test-pmd/config.c:739:
+                               printf("port index %d invalid
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#185: FILE: app/test-pmd/config.c:739:
+                               printf("port index %d invalid
", port_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: app/test-pmd/config.c:740:
+                               break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: app/test-pmd/config.c:740:
+                               break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#187: FILE: app/test-pmd/config.c:741:
+                       case -ENOTSUP:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#187: FILE: app/test-pmd/config.c:741:
+                       case -ENOTSUP:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#188: FILE: app/test-pmd/config.c:742:
+                               printf("operation not supported by device
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: app/test-pmd/config.c:742:
+                               printf("operation not supported by device
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#189: FILE: app/test-pmd/config.c:743:
+                               break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: app/test-pmd/config.c:743:
+                               break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#190: FILE: app/test-pmd/config.c:744:
+                       case -EIO:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: app/test-pmd/config.c:744:
+                       case -EIO:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#191: FILE: app/test-pmd/config.c:745:
+                               printf("device Iis removed
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#191: FILE: app/test-pmd/config.c:745:
+                               printf("device Iis removed
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#192: FILE: app/test-pmd/config.c:746:
+                               break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#192: FILE: app/test-pmd/config.c:746:
+                               break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#193: FILE: app/test-pmd/config.c:747:
+                       default:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#194: FILE: app/test-pmd/config.c:748:
+                               printf("Unable to get module EEPROM: %d
", ret);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: app/test-pmd/config.c:748:
+                               printf("Unable to get module EEPROM: %d
", ret);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#195: FILE: app/test-pmd/config.c:749:
+                               break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: app/test-pmd/config.c:749:
+                               break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#196: FILE: app/test-pmd/config.c:750:
+                       }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: app/test-pmd/config.c:750:
+                       }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#197: FILE: app/test-pmd/config.c:751:
+                       return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: app/test-pmd/config.c:751:
+                       return;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#198: FILE: app/test-pmd/config.c:752:
+               }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: app/test-pmd/config.c:752:
+               }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#200: FILE: app/test-pmd/config.c:754:
+               rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: app/test-pmd/config.c:754:
+               rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: app/test-pmd/config.c:755:
+               printf("Finish -- Total EEPROM length: %i bytes
", len_eeprom);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: app/test-pmd/config.c:755:
+               printf("Finish -- Total EEPROM length: %i bytes
", len_eeprom);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: app/test-pmd/config.c:757:
+       } else if (len_eeprom == 0)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#203: FILE: app/test-pmd/config.c:757:
+       } else if (len_eeprom == 0)
+               printf("Port %d: Device does not have EEPROM
", port_id);

ERROR:CODE_INDENT: code indent should use tabs where possible
#204: FILE: app/test-pmd/config.c:758:
+               printf("Port %d: Device does not have EEPROM
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: app/test-pmd/config.c:758:
+               printf("Port %d: Device does not have EEPROM
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#205: FILE: app/test-pmd/config.c:759:
+       else if (len_eeprom == -ENOTSUP)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#205: FILE: app/test-pmd/config.c:759:
+       else if (len_eeprom == -ENOTSUP)
+               printf("Port %d: Operation not supported
", port_id);

ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: app/test-pmd/config.c:760:
+               printf("Port %d: Operation not supported
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: app/test-pmd/config.c:760:
+               printf("Port %d: Operation not supported
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: app/test-pmd/config.c:761:
+       else$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#207: FILE: app/test-pmd/config.c:761:
+       else
+               printf("Port %d: Error getting EEPROM
", port_id);

ERROR:CODE_INDENT: code indent should use tabs where possible
#208: FILE: app/test-pmd/config.c:762:
+               printf("Port %d: Error getting EEPROM
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: app/test-pmd/config.c:762:
+               printf("Port %d: Error getting EEPROM
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#214: FILE: app/test-pmd/config.c:768:
+       struct rte_eth_dev_module_info minfo;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: app/test-pmd/config.c:769:
+       struct rte_dev_eeprom_info einfo;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#216: FILE: app/test-pmd/config.c:770:
+       char buf[1024];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#217: FILE: app/test-pmd/config.c:771:
+       int ret;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#220: FILE: app/test-pmd/config.c:774:
+       if (port_id_is_invalid(port_id, ENABLED_WARN)) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#220: FILE: app/test-pmd/config.c:774:
+       if (port_id_is_invalid(port_id, ENABLED_WARN)) {
+               print_valid_ports();

ERROR:CODE_INDENT: code indent should use tabs where possible
#221: FILE: app/test-pmd/config.c:775:
+               print_valid_ports();$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: app/test-pmd/config.c:775:
+               print_valid_ports();$

ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: app/test-pmd/config.c:776:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: app/test-pmd/config.c:776:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#223: FILE: app/test-pmd/config.c:777:
+       }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#225: FILE: app/test-pmd/config.c:779:
+       ret = rte_eth_dev_get_module_info(port_id, &minfo);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: app/test-pmd/config.c:780:
+       if (ret != 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#226: FILE: app/test-pmd/config.c:780:
+       if (ret != 0) {
+               switch (ret) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#227: FILE: app/test-pmd/config.c:781:
+               switch (ret) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: app/test-pmd/config.c:781:
+               switch (ret) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: app/test-pmd/config.c:782:
+               case -ENODEV:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: app/test-pmd/config.c:782:
+               case -ENODEV:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#229: FILE: app/test-pmd/config.c:783:
+                       printf("port index %d invalid
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: app/test-pmd/config.c:783:
+                       printf("port index %d invalid
", port_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: app/test-pmd/config.c:784:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: app/test-pmd/config.c:784:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#231: FILE: app/test-pmd/config.c:785:
+               case -ENOTSUP:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#231: FILE: app/test-pmd/config.c:785:
+               case -ENOTSUP:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#232: FILE: app/test-pmd/config.c:786:
+                       printf("operation not supported by device
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#232: FILE: app/test-pmd/config.c:786:
+                       printf("operation not supported by device
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#233: FILE: app/test-pmd/config.c:787:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#233: FILE: app/test-pmd/config.c:787:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#234: FILE: app/test-pmd/config.c:788:
+               case -EIO:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: app/test-pmd/config.c:788:
+               case -EIO:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#235: FILE: app/test-pmd/config.c:789:
+                       printf("device Iis removed
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: app/test-pmd/config.c:789:
+                       printf("device Iis removed
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#236: FILE: app/test-pmd/config.c:790:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#236: FILE: app/test-pmd/config.c:790:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#237: FILE: app/test-pmd/config.c:791:
+               default:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#238: FILE: app/test-pmd/config.c:792:
+                       printf("Unable to get module info: %d
", ret);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: app/test-pmd/config.c:792:
+                       printf("Unable to get module info: %d
", ret);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#239: FILE: app/test-pmd/config.c:793:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#239: FILE: app/test-pmd/config.c:793:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: app/test-pmd/config.c:794:
+               }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#240: FILE: app/test-pmd/config.c:794:
+               }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#241: FILE: app/test-pmd/config.c:795:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#241: FILE: app/test-pmd/config.c:795:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#242: FILE: app/test-pmd/config.c:796:
+       }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#244: FILE: app/test-pmd/config.c:798:
+       einfo.offset = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: app/test-pmd/config.c:799:
+       einfo.length = minfo.eeprom_len;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#246: FILE: app/test-pmd/config.c:800:
+       einfo.data = buf;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#248: FILE: app/test-pmd/config.c:802:
+       ret = rte_eth_dev_get_module_eeprom(port_id, &einfo);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: app/test-pmd/config.c:803:
+       if (ret != 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#249: FILE: app/test-pmd/config.c:803:
+       if (ret != 0) {
+               switch (ret) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#250: FILE: app/test-pmd/config.c:804:
+               switch (ret) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#250: FILE: app/test-pmd/config.c:804:
+               switch (ret) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#251: FILE: app/test-pmd/config.c:805:
+               case -ENODEV:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#251: FILE: app/test-pmd/config.c:805:
+               case -ENODEV:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#252: FILE: app/test-pmd/config.c:806:
+                       printf("port index %d invalid
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#252: FILE: app/test-pmd/config.c:806:
+                       printf("port index %d invalid
", port_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#253: FILE: app/test-pmd/config.c:807:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#253: FILE: app/test-pmd/config.c:807:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#254: FILE: app/test-pmd/config.c:808:
+               case -ENOTSUP:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#254: FILE: app/test-pmd/config.c:808:
+               case -ENOTSUP:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#255: FILE: app/test-pmd/config.c:809:
+                       printf("operation not supported by device
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#255: FILE: app/test-pmd/config.c:809:
+                       printf("operation not supported by device
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#256: FILE: app/test-pmd/config.c:810:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#256: FILE: app/test-pmd/config.c:810:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#257: FILE: app/test-pmd/config.c:811:
+               case -EIO:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#257: FILE: app/test-pmd/config.c:811:
+               case -EIO:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#258: FILE: app/test-pmd/config.c:812:
+                       printf("device Iis removed
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#258: FILE: app/test-pmd/config.c:812:
+                       printf("device Iis removed
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#259: FILE: app/test-pmd/config.c:813:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#259: FILE: app/test-pmd/config.c:813:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#260: FILE: app/test-pmd/config.c:814:
+               default:$

ERROR:CODE_INDENT: code indent should use tabs where possible
#261: FILE: app/test-pmd/config.c:815:
+                       printf("Unable to get module EEPROM: %d
", ret);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: app/test-pmd/config.c:815:
+                       printf("Unable to get module EEPROM: %d
", ret);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#262: FILE: app/test-pmd/config.c:816:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#262: FILE: app/test-pmd/config.c:816:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: app/test-pmd/config.c:817:
+               }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: app/test-pmd/config.c:817:
+               }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#264: FILE: app/test-pmd/config.c:818:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#264: FILE: app/test-pmd/config.c:818:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#265: FILE: app/test-pmd/config.c:819:
+       }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#267: FILE: app/test-pmd/config.c:821:
+       printf("
Port: %d
EEPROM:
", port_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#268: FILE: app/test-pmd/config.c:822:
+       rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);$

total: 72 errors, 119 warnings, 185 lines checked


More information about the test-report mailing list