[dpdk-test-report] |WARNING| pw76211 [PATCH v1 08/42] net/txgbe: add HW reset operation

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 01:26:57 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76211

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#190: FILE: drivers/net/txgbe/base/txgbe_hw.c:174:
+	for (i = 0; i < poll; i++) {
+		usec_delay(100);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#265: FILE: drivers/net/txgbe/base/txgbe_hw.c:327:
+		if (i == 10) {
+			err = TXGBE_ERR_FLASH_LOADING_FAILED;
+		}

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#315: FILE: drivers/net/txgbe/base/txgbe_hw.c:377:
+	if (hw->phy.reset_disable == false)

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#365: FILE: drivers/net/txgbe/base/txgbe_hw.c:427:
+	if (hw->mac.orig_link_settings_stored == false) {

total: 0 errors, 2 warnings, 2 checks, 382 lines checked


More information about the test-report mailing list