[dpdk-test-report] |WARNING| pw76223 [PATCH v1 20/42] net/txgbe: add RX and TX stop

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 01:27:48 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76223

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#58: 
Add receive and transmit units stop for specified queue, release mbufs and free queues.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#222: FILE: drivers/net/txgbe/txgbe_rxtx.c:178:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#272: FILE: drivers/net/txgbe/txgbe_rxtx.c:228:
+	unsigned i;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:245:
+	for (i = 0; i < len; i++) {
+		rxq->rx_ring[i] = zeroed_desc;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#298: FILE: drivers/net/txgbe/txgbe_rxtx.c:254:
+	for (i = rxq->nb_rx_desc; i < len; ++i) {
+		rxq->sw_ring[i].mbuf = &rxq->fake_mbuf;
+	}

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#310: FILE: drivers/net/txgbe/txgbe_rxtx.c:266:
+
+}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#315: FILE: drivers/net/txgbe/txgbe_rxtx.c:271:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#343: FILE: drivers/net/txgbe/txgbe_rxtx.c:298:
+	unsigned i;

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#552: FILE: drivers/net/txgbe/txgbe_rxtx.h:98:
+	struct rte_mbuf *rx_stage[RTE_PMD_TXGBE_RX_MAX_BURST*2];
 	                                                    ^

total: 0 errors, 7 warnings, 2 checks, 468 lines checked


More information about the test-report mailing list