[dpdk-test-report] |WARNING| pw76226 [PATCH v1 23/42] net/txgbe: fill simple transmit function

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76226

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->sw_ring[txq->tx_next_dd - (txq->tx_free_thresh - 1)]
#105: FILE: drivers/net/txgbe/txgbe_rxtx.c:59:
+	txep = &(txq->sw_ring[txq->tx_next_dd - (txq->tx_free_thresh - 1)]);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->tx_ring[txq->tx_tail]
#185: FILE: drivers/net/txgbe/txgbe_rxtx.c:139:
+	volatile struct txgbe_tx_desc *txdp = &(txq->tx_ring[txq->tx_tail]);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->sw_ring[txq->tx_tail]
#186: FILE: drivers/net/txgbe/txgbe_rxtx.c:140:
+	struct txgbe_tx_entry *txep = &(txq->sw_ring[txq->tx_tail]);

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#188: FILE: drivers/net/txgbe/txgbe_rxtx.c:142:
+	const int N_PER_LOOP_MASK = N_PER_LOOP-1;
 	                                      ^

CHECK:SPACING: No space is necessary after a cast
#196: FILE: drivers/net/txgbe/txgbe_rxtx.c:150:
+	mainpart = (nb_pkts & ((uint32_t) ~N_PER_LOOP_MASK));

CHECK:SPACING: No space is necessary after a cast
#197: FILE: drivers/net/txgbe/txgbe_rxtx.c:151:
+	leftover = (nb_pkts & ((uint32_t)  N_PER_LOOP_MASK));

WARNING:BRACES: braces {} are not necessary for single statement blocks
#200: FILE: drivers/net/txgbe/txgbe_rxtx.c:154:
+		for (j = 0; j < N_PER_LOOP; ++j) {
+			(txep + i + j)->mbuf = *(pkts + i + j);
+		}

CHECK:SPACING: No space is necessary after a cast
#267: FILE: drivers/net/txgbe/txgbe_rxtx.c:221:
+		   (unsigned) txq->port_id, (unsigned) txq->queue_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#267: FILE: drivers/net/txgbe/txgbe_rxtx.c:221:
+		   (unsigned) txq->port_id, (unsigned) txq->queue_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#267: FILE: drivers/net/txgbe/txgbe_rxtx.c:221:
+		   (unsigned) txq->port_id, (unsigned) txq->queue_id,

CHECK:SPACING: No space is necessary after a cast
#268: FILE: drivers/net/txgbe/txgbe_rxtx.c:222:
+		   (unsigned) txq->tx_tail, (unsigned) nb_pkts);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#268: FILE: drivers/net/txgbe/txgbe_rxtx.c:222:
+		   (unsigned) txq->tx_tail, (unsigned) nb_pkts);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#268: FILE: drivers/net/txgbe/txgbe_rxtx.c:222:
+		   (unsigned) txq->tx_tail, (unsigned) nb_pkts);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around tx_pkts[nb_tx]
#296: FILE: drivers/net/txgbe/txgbe_rxtx.c:247:
+		ret = tx_xmit_pkts(tx_queue, &(tx_pkts[nb_tx]), n);

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#318: FILE: drivers/net/txgbe/txgbe_rxtx.h:55:
+ * Transmit Descriptor
+******************************************************************************/

total: 0 errors, 6 warnings, 9 checks, 340 lines checked