[dpdk-test-report] |WARNING| pw76232 [PATCH v1 29/42] net/txgbe: add queue stats mapping and enable RX DMA unit

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 01:28:32 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76232

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#59: 
Add queue stats mapping set, complete receive and transmit unit with DMA and sec path.

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACRX1024toMAXL>
#148: FILE: drivers/net/txgbe/base/txgbe_hw.c:178:
+	rd64(hw, TXGBE_MACRX1024toMAXL);

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACTX1024toMAXL>
#154: FILE: drivers/net/txgbe/base/txgbe_hw.c:184:
+	rd64(hw, TXGBE_MACTX1024toMAXL);

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#223: FILE: drivers/net/txgbe/base/txgbe_hw.c:253:
+	if (TXGBE_PWR_LANID_SWAP == TXGBE_PWR_LANID(reg))

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#269: FILE: drivers/net/txgbe/base/txgbe_hw.c:453:
+			break;
+		else

WARNING:BRACES: braces {} are not necessary for single statement blocks
#455: FILE: drivers/net/txgbe/base/txgbe_hw.c:1767:
+	if ((value & 0x3) != SR_PCS_CTRL2_TYPE_SEL_X) {
+		hw->link_status = TXGBE_LINK_STATUS_NONE;
+	}

WARNING:TYPO_SPELLING: 'transmiter' may be misspelled - perhaps 'transmitter'?
#499: FILE: drivers/net/txgbe/base/txgbe_hw.c:1811:
+	/* enable mac transmiter */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#502: FILE: drivers/net/txgbe/base/txgbe_hw.c:1814:
+	for (i = 0; i < 4; i++) {
+		wr32m(hw, TXGBE_IVAR(i), 0x80808080, 0);
+	}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#521: FILE: drivers/net/txgbe/base/txgbe_hw.c:1989:
+{
+

total: 0 errors, 6 warnings, 3 checks, 560 lines checked


More information about the test-report mailing list