[dpdk-test-report] |WARNING| pw76236 [PATCH v1 33/42] net/txgbe: add EEPROM info get operation

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76236

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#129: FILE: drivers/net/txgbe/base/txgbe_hw.c:752:
+			return 0;
+		} else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0'
#202: FILE: drivers/net/txgbe/base/txgbe_hw.c:1171:
+	if ((alt_san_mac_blk_offset == 0) ||
+	    (alt_san_mac_blk_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0xFFFF'
#202: FILE: drivers/net/txgbe/base/txgbe_hw.c:1171:
+	if ((alt_san_mac_blk_offset == 0) ||
+	    (alt_san_mac_blk_offset == 0xFFFF))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#215: FILE: drivers/net/txgbe/base/txgbe_hw.c:1184:
+	if (hw->rom.read16(hw, offset, wwnn_prefix)) {
+		DEBUGOUT("eeprom read at offset %d failed", offset);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#370: FILE: drivers/net/txgbe/txgbe_ethdev.c:333:
+	if (hw->mac.acquire_swfw_sync(hw, mask) < 0) {
+		PMD_DRV_LOG(DEBUG, "SWFW common locks released");
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first > hw->rom.word_size'
#422: FILE: drivers/net/txgbe/txgbe_ethdev.c:2200:
+	if ((first > hw->rom.word_size) ||
+	    ((first + length) > hw->rom.word_size))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'first > hw->rom.word_size'
#442: FILE: drivers/net/txgbe/txgbe_ethdev.c:2220:
+	if ((first > hw->rom.word_size) ||
+	    ((first + length) > hw->rom.word_size))

total: 0 errors, 3 warnings, 4 checks, 427 lines checked