[dpdk-test-report] |WARNING| pw76239 [PATCH v1 36/42] net/txgbe: add flow control support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76239

_coding style issues_


WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#172: FILE: drivers/net/txgbe/base/txgbe_hw.c:120:
+		/* fall through - only backplane uses autoc */

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#249: FILE: drivers/net/txgbe/base/txgbe_hw.c:197:
+		goto out;
+		break;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water > max_high_water'
#735: FILE: drivers/net/txgbe/txgbe_ethdev.c:2525:
+	if ((fc_conf->high_water > max_high_water) ||
+	    (fc_conf->high_water < fc_conf->low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water < fc_conf->low_water'
#735: FILE: drivers/net/txgbe/txgbe_ethdev.c:2525:
+	if ((fc_conf->high_water > max_high_water) ||
+	    (fc_conf->high_water < fc_conf->low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#752: FILE: drivers/net/txgbe/txgbe_ethdev.c:2542:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED'
#752: FILE: drivers/net/txgbe/txgbe_ethdev.c:2542:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) {

total: 0 errors, 2 warnings, 4 checks, 689 lines checked