[dpdk-test-report] |WARNING| pw78259 [PATCH 11/60] common/sfc_efx/base: factor out helper to get board config

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Sep 22 10:52:40 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78259

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#175: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1875:
+	if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#192: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1892:
+	if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#196: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1896:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#221: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1921:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#271: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1971:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#282: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1982:
+	if ((rc = efx_mcdi_nic_board_cfg(enp)) != 0)

total: 6 errors, 0 warnings, 255 lines checked


More information about the test-report mailing list