[dpdk-test-report] |WARNING| pw78276 [PATCH 33/60] common/sfc_efx/base: implement Tx control path for Riverhead

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78276

_coding style issues_


WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#258: FILE: drivers/common/sfc_efx/base/rhead_impl.h:396:
+	__inout			unsigned int *addedp);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#290: FILE: drivers/common/sfc_efx/base/rhead_impl.h:428:
+	__inout		unsigned int *addedp);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#298: FILE: drivers/common/sfc_efx/base/rhead_impl.h:436:
+	__inout_ecount(TX_NQSTATS)	efsys_stat_t *stat);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#362: FILE: drivers/common/sfc_efx/base/rhead_tx.c:51:
+	if ((rc = efx_mcdi_init_txq(enp, ndescs, eep->ee_index, label, index,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#372: FILE: drivers/common/sfc_efx/base/rhead_tx.c:61:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#377: FILE: drivers/common/sfc_efx/base/rhead_tx.c:66:
+	return (rc);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#394: FILE: drivers/common/sfc_efx/base/rhead_tx.c:83:
+	__inout			unsigned int *addedp)

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#404: FILE: drivers/common/sfc_efx/base/rhead_tx.c:93:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#429: FILE: drivers/common/sfc_efx/base/rhead_tx.c:118:
+	return (ENOTSUP);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#439: FILE: drivers/common/sfc_efx/base/rhead_tx.c:128:
+	if ((rc = efx_mcdi_fini_txq(enp, etp->et_index)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#442: FILE: drivers/common/sfc_efx/base/rhead_tx.c:131:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#454: FILE: drivers/common/sfc_efx/base/rhead_tx.c:143:
+	return (rc);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#471: FILE: drivers/common/sfc_efx/base/rhead_tx.c:160:
+	__inout			unsigned int *addedp)

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#481: FILE: drivers/common/sfc_efx/base/rhead_tx.c:170:
+	return (ENOTSUP);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#489: FILE: drivers/common/sfc_efx/base/rhead_tx.c:178:
+	__inout_ecount(TX_NQSTATS)	efsys_stat_t *stat)

total: 6 errors, 9 warnings, 368 lines checked