[dpdk-test-report] |WARNING| pw78287 [PATCH 42/60] common/sfc_efx/base: choose smallest Rx prefix on Riverhead

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Sep 22 10:57:13 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78287

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#219: FILE: drivers/common/sfc_efx/base/rhead_rx.c:317:
+	EFX_STATIC_ASSERT(sizeof (idsp[0]) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#223: FILE: drivers/common/sfc_efx/base/rhead_rx.c:321:
+	    *nids * sizeof (idsp[0]));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#225: FILE: drivers/common/sfc_efx/base/rhead_rx.c:323:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#234: FILE: drivers/common/sfc_efx/base/rhead_rx.c:332:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#261: FILE: drivers/common/sfc_efx/base/rhead_rx.c:359:
+	return (efx_mcdi_to_rx_prefix_field[mcdi_idx]);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#297: FILE: drivers/common/sfc_efx/base/rhead_rx.c:395:
+	return (efx_rx_prefix_field_to_mcdi[field]);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: drivers/common/sfc_efx/base/rhead_rx.c:411:
+				return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#320: FILE: drivers/common/sfc_efx/base/rhead_rx.c:418:
+	return (0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#379: FILE: drivers/common/sfc_efx/base/rhead_rx.c:477:
+	memset(erplp, 0, sizeof (*erplp));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#420: FILE: drivers/common/sfc_efx/base/rhead_rx.c:518:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#440: FILE: drivers/common/sfc_efx/base/rhead_rx.c:538:
+	memset(erplp, 0, sizeof (*erplp));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#479: FILE: drivers/common/sfc_efx/base/rhead_rx.c:577:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#505: FILE: drivers/common/sfc_efx/base/rhead_rx.c:634:
+	if ((rc = rhead_rx_choose_prefix_id(enp,

total: 8 errors, 5 warnings, 406 lines checked


More information about the test-report mailing list