[dpdk-test-report] |WARNING| pw78375 [PATCH v2 50/60] common/sfc_efx/base: support UDP tunnel operations for EF100

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78375

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#173: FILE: drivers/common/sfc_efx/base/efx_mcdi.h:392:
+#define	MCDI_IN_SET_WORD_NATIVE(_emr, _ofst, _value)			\
+	MCDI_IN2((_emr), efx_word_t, _ofst)->ew_u16[0] = (_value)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#176: FILE: drivers/common/sfc_efx/base/efx_mcdi.h:395:
+#define	MCDI_IN_SET_DWORD_NATIVE(_emr, _ofst, _value)			\
+	MCDI_IN2((_emr), efx_dword_t, _ofst)->ed_u32[0] = (_value)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#381: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:72:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#418: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:109:
+	EFX_STATIC_ASSERT(sizeof (spec->evers_loc_host) ==

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#451: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:142:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#462: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:153:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#505: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:196:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#513: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:204:
+	memset(spec, 0, sizeof (*spec));

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#526: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:217:
+	__inout		efx_tunnel_udp_entry_t *etuep)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#531: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:222:
+	return (efx_mcdi_vnic_encap_rule_add(enp, &spec, &etuep->etue_handle));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#539: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:230:
+	return (efx_mcdi_vnic_encap_rule_remove(enp, etuep->etue_handle));

WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#546: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:237:
+	efx_tunnel_cfg_t *etcp = &enp->en_tunnel_cfg;

WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#561: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:252:
+	memcpy(&etc, etcp, sizeof (etc));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#561: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:252:
+	memcpy(&etc, etcp, sizeof (etc));

WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#599: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:290:
+	for (i = 0, j = 0; i < etcp->etc_udp_entries_num; i++) {

WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#600: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:291:
+		efx_tunnel_udp_entry_t *cur_entry = &etcp->etc_udp_entries[i];

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#612: FILE: drivers/common/sfc_efx/base/rhead_tunnel.c:303:
+	return (0);

total: 9 errors, 8 warnings, 495 lines checked