[dpdk-test-report] |WARNING| pw78394 [PATCH 1/2] net/bonding: fix a possible unbalance packet receiving

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Sep 22 12:29:48 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78394

_coding style issues_


WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#43: 
Current Rx round robin policy for the slaves has two issue:

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#45: 
1. active_slave in bond_dev_private is shared by multiple PMDS

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#46: 
which maybe cause some slave Rx hungry, for example, there

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#47: 
is two PMD and two slave port, both PMDs start to receive, and

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#48: 
see that active_slave is 0, and receive from slave 0, after

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#48: 
see that active_slave is 0, and receive from slave 0, after

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#49: 
complete, they increase active_slave by one, totally active_slave

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#49: 
complete, they increase active_slave by one, totally active_slave

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#51: 
from slave 0 again, at last, slave 1 maybe drop packets during

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#51: 
from slave 0 again, at last, slave 1 maybe drop packets during

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#54: 
2. active_slave is shared and written by multiple PMD in RX path

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#58: 
so move active_slave from bond_dev_private to bond_rx_queue

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#77: FILE: drivers/net/bonding/eth_bond_private.h:53:
+	/**< Next active_slave to poll */

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#78: FILE: drivers/net/bonding/eth_bond_private.h:54:
+	uint16_t active_slave;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#116: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:72:
+	active_slave = bd_rx_q->active_slave;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#116: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:72:
+	active_slave = bd_rx_q->active_slave;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#126: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:89:
+	if (++bd_rx_q->active_slave >= slave_count)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#126: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:89:
+	if (++bd_rx_q->active_slave >= slave_count)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#127: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:90:
+		bd_rx_q->active_slave = 0;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#136: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:306:
+	idx = bd_rx_q->active_slave;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#139: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:308:
+		bd_rx_q->active_slave = 0;

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#149: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:370:
+	if (++bd_rx_q->active_slave >= slave_count)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#149: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:370:
+	if (++bd_rx_q->active_slave >= slave_count)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#150: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:371:
+		bd_rx_q->active_slave = 0;

total: 0 errors, 24 warnings, 0 checks, 66 lines checked


More information about the test-report mailing list