[dpdk-test-report] |WARNING| pw78673 [PATCH] eal/windows: Switched to an external pthreads library, pulled in as a meson subproject
checkpatch at dpdk.org
checkpatch at dpdk.org
Thu Sep 24 13:12:52 CEST 2020
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78673
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#139:
The Windows EAL build now pulls in the pthreads4w project as an external subproject. The pthreads4w subproject does not currently provide a meson build so the project has been patched with one.
WARNING:TYPO_SPELLING: 'auxillary' may be misspelled - perhaps 'auxiliary'?
#149:
Added the source file librte_eal\windows\windows_eal_impl.c. This source file serves as a location for the implementation of auxillary functionality provided by the Windows EAL that would otherwise be provided by the UNIX runtime.
ERROR:TRAILING_WHITESPACE: trailing whitespace
#236: FILE: lib/librte_eal/windows/eal.c:368:
+^I * real-time thread priority and real-time process class set. $
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#516: FILE: lib/librte_eal/windows/include/rte_os.h:51:
+void RTE_CPU_ANDNOT(cpu_set_t * dst, cpu_set_t * src);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#516: FILE: lib/librte_eal/windows/include/rte_os.h:51:
+void RTE_CPU_ANDNOT(cpu_set_t * dst, cpu_set_t * src);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#517: FILE: lib/librte_eal/windows/include/rte_os.h:52:
+void RTE_CPU_COPY(cpu_set_t * from, cpu_set_t *to);
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#669: FILE: lib/librte_eal/windows/windows_eal_impl.c:23:
+ do
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#673: FILE: lib/librte_eal/windows/windows_eal_impl.c:27:
+ if ((masked_so_far + 8) > system_info.dwNumberOfProcessors)
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#690: FILE: lib/librte_eal/windows/windows_eal_impl.c:44:
+ for (set_index = 0;
+ set_index < _countof(dst->cpuset);
+ set_index++)
+ {
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 8 errors, 2 warnings, 333 lines checked
Warning in lib/librte_eal/windows/eal.c:
Using rte_panic/rte_exit
More information about the test-report
mailing list