[dpdk-test-report] |WARNING| pw78718 [PATCH v3 42/60] common/sfc_efx/base: choose smallest Rx prefix on Riverhead

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Sep 24 14:21:36 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78718

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#220: FILE: drivers/common/sfc_efx/base/rhead_rx.c:317:
+	EFX_STATIC_ASSERT(sizeof (idsp[0]) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#224: FILE: drivers/common/sfc_efx/base/rhead_rx.c:321:
+	    *nids * sizeof (idsp[0]));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#226: FILE: drivers/common/sfc_efx/base/rhead_rx.c:323:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#235: FILE: drivers/common/sfc_efx/base/rhead_rx.c:332:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#262: FILE: drivers/common/sfc_efx/base/rhead_rx.c:359:
+	return (efx_mcdi_to_rx_prefix_field[mcdi_idx]);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#298: FILE: drivers/common/sfc_efx/base/rhead_rx.c:395:
+	return (efx_rx_prefix_field_to_mcdi[field]);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#314: FILE: drivers/common/sfc_efx/base/rhead_rx.c:411:
+				return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#321: FILE: drivers/common/sfc_efx/base/rhead_rx.c:418:
+	return (0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#380: FILE: drivers/common/sfc_efx/base/rhead_rx.c:477:
+	memset(erplp, 0, sizeof (*erplp));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#421: FILE: drivers/common/sfc_efx/base/rhead_rx.c:518:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#441: FILE: drivers/common/sfc_efx/base/rhead_rx.c:538:
+	memset(erplp, 0, sizeof (*erplp));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#480: FILE: drivers/common/sfc_efx/base/rhead_rx.c:577:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#506: FILE: drivers/common/sfc_efx/base/rhead_rx.c:634:
+	if ((rc = rhead_rx_choose_prefix_id(enp,

total: 8 errors, 5 warnings, 406 lines checked


More information about the test-report mailing list