[dpdk-test-report] |WARNING| pw79367 [PATCH v2] pci: support both PIO and MMIO BAR for legacy virtio on x86

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79367

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#67: 
>From c13f981e287254cd0877cc7b98ee2dd7b80c3b69 Mon Sep 17 00:00:00 2001

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#70: 
Subject: [PATCH v2] pci:Â  support both PIO and MMIO BAR for legacy virtio on

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#234: FILE: drivers/bus/pci/linux/pci.c:686:
rte_pci_device *device,

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#311: FILE: drivers/bus/pci/linux/pci.c:699:
 Â Â Â Â  Â Â Â  if (pci_vfio_is_enabled())
+Â Â Â  Â Â Â  Â Â Â  ret = pci_uio_ioport_map(dev, bar, p);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#362: FILE: drivers/bus/pci/linux/pci.c:763:
 Â Â Â Â  Â Â Â  if (pci_vfio_is_enabled())
+Â Â Â  Â Â Â  Â Â Â  ret = pci_uio_ioport_unmap(p);

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#388: FILE: drivers/bus/pci/linux/pci_uio.c:376:
+Â Â Â  FILE *f = NULL;
             ^

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#408: FILE: drivers/bus/pci/linux/pci_uio.c:391:
+Â Â Â  if (f == NULL) {
+Â Â Â  Â Â Â  RTE_LOG(ERR, EAL, "Cannot open sysfs resource: %s
",

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#417: FILE: drivers/bus/pci/linux/pci_uio.c:397:
+Â Â Â  for (i = 0; i < bar + 1; i++) {
+Â Â Â  Â Â Â  if (fgets(buf, sizeof(buf), f) == NULL) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#418: FILE: drivers/bus/pci/linux/pci_uio.c:398:
+Â Â Â  Â Â Â  if (fgets(buf, sizeof(buf), f) == NULL) {
+Â Â Â  Â Â Â  Â Â Â  RTE_LOG(ERR, EAL, "Cannot read sysfs resource
");

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#423: FILE: drivers/bus/pci/linux/pci_uio.c:403:
+Â Â Â  if (pci_parse_one_sysfs_resource(buf, sizeof(buf), &phys_addr,
[...]
+Â Â Â  Â Â Â  goto error;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#434: FILE: drivers/bus/pci/linux/pci_uio.c:407:
+Â Â Â  if (flags & IORESOURCE_IO) {
+Â Â Â  Â Â Â  iobar = 1;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#437: FILE: drivers/bus/pci/linux/pci_uio.c:410:
+Â Â Â  Â Â Â  RTE_LOG(INFO, EAL, "%s(): PIO BAR %08lx detected
", __func__, $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#439: FILE: drivers/bus/pci/linux/pci_uio.c:411:
+Â Â Â  } else if (flags & IORESOURCE_MEM) {
+Â Â Â  Â Â Â  iobar = 0;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#442: FILE: drivers/bus/pci/linux/pci_uio.c:414:
+Â Â Â  Â Â Â  RTE_LOG(INFO, EAL, "%s(): MMIO BAR %08lx detected
", __func__, $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#444: FILE: drivers/bus/pci/linux/pci_uio.c:415:
+Â Â Â  } else {
+Â Â Â  Â Â Â  RTE_LOG(ERR, EAL, "%s(): unknown BAR type
", __func__);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#449: FILE: drivers/bus/pci/linux/pci_uio.c:420:
+Â Â Â  if (iobar && rte_eal_iopl_init() != 0) {
+Â Â Â  Â Â Â  RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for 

ERROR:TRAILING_WHITESPACE: trailing whitespace
#450: FILE: drivers/bus/pci/linux/pci_uio.c:421:
+Â Â Â  Â Â Â  RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for $

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#480: FILE: drivers/bus/pci/linux/pci_uio.c:443:
+Â Â Â  RTE_LOG(DEBUG, EAL, "PCI IO port found start=0x%lx
", base);
                                                    ^

total: 7 errors, 11 warnings, 363 lines checked