[dpdk-test-report] |WARNING| pw97172 [RFC 6/7] eth: make drivers to use new API for Rx queue count

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Aug 20 18:30:36 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97172

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#241: FILE: lib/ethdev/ethdev_driver.h:1966:
+#define _RTE_ETH_RX_QCNT_DEF(fn) \
+_RTE_ETH_RX_QCNT_PROTO(fn) \
+{ \
+	int rc; \
+       	rc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \
+	if (rc != 0) \
+		return rc; \
+	return fn(&rte_eth_devices[port_id], queue_id); \
+}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#241: FILE: lib/ethdev/ethdev_driver.h:1966:
+#define _RTE_ETH_RX_QCNT_DEF(fn) \
+_RTE_ETH_RX_QCNT_PROTO(fn) \
+{ \
+	int rc; \
+       	rc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \
+	if (rc != 0) \
+		return rc; \
+	return fn(&rte_eth_devices[port_id], queue_id); \
+}

ERROR:CODE_INDENT: code indent should use tabs where possible
#245: FILE: lib/ethdev/ethdev_driver.h:1970:
+       ^Irc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#245: FILE: lib/ethdev/ethdev_driver.h:1970:
+       ^Irc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#245: FILE: lib/ethdev/ethdev_driver.h:1970:
+       ^Irc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \$

total: 2 errors, 3 warnings, 225 lines checked
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)


More information about the test-report mailing list