[dpdk-test-report] |WARNING| pw97222 [PATCH RFC 1/1] vhost: add DMADEV support for async datapath

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Aug 23 11:55:49 CEST 2021
Previous message (by thread): [dpdk-test-report] |WARNING| pw97220 [PATCH v5 2/2] net: added macro to extract MAC address bytes
Next message (by thread): [dpdk-test-report] |WARNING| pw97223 [PATCH] RFC: ethdev: add reassembly offload
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97222

_coding style issues_


WARNING:SPACING: missing space after struct definition
#336: FILE: lib/vhost/vhost.h:129:
+struct enq_info_t{

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#337: FILE: lib/vhost/vhost.h:130:
+    uint8_t pkt_rcvd; //Make this atomic$

ERROR:C99_COMMENTS: do not use C99 // comments
#337: FILE: lib/vhost/vhost.h:130:
+    uint8_t pkt_rcvd; //Make this atomic

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#342: FILE: lib/vhost/vhost.h:135:
+ * to guarantee correct behaviour. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#344: FILE: lib/vhost/vhost.h:137:
+    struct enq_info_t enq_info[DMA_COMPLETION_RING_SIZE];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#345: FILE: lib/vhost/vhost.h:138:
+    uint16_t count;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#346: FILE: lib/vhost/vhost.h:139:
+    uint16_t read_idx;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#347: FILE: lib/vhost/vhost.h:140:
+    uint16_t write_idx;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#392: FILE: lib/vhost/virtio_net.c:1597:
+    return dma_compl->count == DMA_COMPLETION_RING_SIZE;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#399: FILE: lib/vhost/virtio_net.c:1604:
+    return dma_compl->count == 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#407: FILE: lib/vhost/virtio_net.c:1612:
+                    const struct rte_vhost_iov_iter *src_ptr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#407: FILE: lib/vhost/virtio_net.c:1612:
+                    const struct rte_vhost_iov_iter *src_ptr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#408: FILE: lib/vhost/virtio_net.c:1613:
+                    const struct rte_vhost_iov_iter *dst_ptr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#408: FILE: lib/vhost/virtio_net.c:1613:
+                    const struct rte_vhost_iov_iter *dst_ptr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#409: FILE: lib/vhost/virtio_net.c:1614:
+                    const uint16_t nr_segs,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#409: FILE: lib/vhost/virtio_net.c:1614:
+                    const uint16_t nr_segs,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#410: FILE: lib/vhost/virtio_net.c:1615:
+                    struct enq_info_t *slot_addr)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#410: FILE: lib/vhost/virtio_net.c:1615:
+                    struct enq_info_t *slot_addr)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#412: FILE: lib/vhost/virtio_net.c:1617:
+    uint16_t seg_idx = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#413: FILE: lib/vhost/virtio_net.c:1618:
+    struct enq_info_t *addr = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#414: FILE: lib/vhost/virtio_net.c:1619:
+    uint64_t dma_flags = RTE_DMA_OP_FLAG_LLC;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#415: FILE: lib/vhost/virtio_net.c:1620:
+    const uint16_t dmadev_ring_mask = VHOST_ASYNC_DMADEV_RING_SIZE-1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#417: FILE: lib/vhost/virtio_net.c:1622:
+    while (likely(seg_idx < nr_segs)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#418: FILE: lib/vhost/virtio_net.c:1623:
+        /* Fetch DMA source start addr. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#419: FILE: lib/vhost/virtio_net.c:1624:
+        const rte_iova_t s_base = (uintptr_t)(src_ptr->iov[seg_idx].iov_base);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#419: FILE: lib/vhost/virtio_net.c:1624:
+        const rte_iova_t s_base = (uintptr_t)(src_ptr->iov[seg_idx].iov_base);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#420: FILE: lib/vhost/virtio_net.c:1625:
+        const rte_iova_t dma_src_start_addr = src_ptr->offset + s_base;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#420: FILE: lib/vhost/virtio_net.c:1625:
+        const rte_iova_t dma_src_start_addr = src_ptr->offset + s_base;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#421: FILE: lib/vhost/virtio_net.c:1626:
+        /* Fetch DMA destination start addr. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#422: FILE: lib/vhost/virtio_net.c:1627:
+        const rte_iova_t d_base = (uintptr_t)(dst_ptr->iov[seg_idx].iov_base);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#422: FILE: lib/vhost/virtio_net.c:1627:
+        const rte_iova_t d_base = (uintptr_t)(dst_ptr->iov[seg_idx].iov_base);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#423: FILE: lib/vhost/virtio_net.c:1628:
+        const rte_iova_t dma_dst_start_addr = dst_ptr->offset + d_base;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#423: FILE: lib/vhost/virtio_net.c:1628:
+        const rte_iova_t dma_dst_start_addr = dst_ptr->offset + d_base;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#424: FILE: lib/vhost/virtio_net.c:1629:
+        /* Fetch packet segment length. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#425: FILE: lib/vhost/virtio_net.c:1630:
+        const uint32_t dma_src_len = src_ptr->iov[seg_idx].iov_len;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#425: FILE: lib/vhost/virtio_net.c:1630:
+        const uint32_t dma_src_len = src_ptr->iov[seg_idx].iov_len;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#426: FILE: lib/vhost/virtio_net.c:1631:
+        /* Check if this segment is the last. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#427: FILE: lib/vhost/virtio_net.c:1632:
+        if (seg_idx == nr_segs - 1) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#427: FILE: lib/vhost/virtio_net.c:1632:
+        if (seg_idx == nr_segs - 1) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#427: FILE: lib/vhost/virtio_net.c:1632:
+        if (seg_idx == nr_segs - 1) {
+            addr = slot_addr;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#427: FILE: lib/vhost/virtio_net.c:1632:
+        if (seg_idx == nr_segs - 1) {
+            addr = slot_addr;
+        }

ERROR:CODE_INDENT: code indent should use tabs where possible
#428: FILE: lib/vhost/virtio_net.c:1633:
+            addr = slot_addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#428: FILE: lib/vhost/virtio_net.c:1633:
+            addr = slot_addr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#429: FILE: lib/vhost/virtio_net.c:1634:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#429: FILE: lib/vhost/virtio_net.c:1634:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#431: FILE: lib/vhost/virtio_net.c:1636:
+        int enq_index = rte_dmadev_copy(dev_id,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#431: FILE: lib/vhost/virtio_net.c:1636:
+        int enq_index = rte_dmadev_copy(dev_id,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#432: FILE: lib/vhost/virtio_net.c:1637:
+                                        0,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#432: FILE: lib/vhost/virtio_net.c:1637:
+                                        0,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#433: FILE: lib/vhost/virtio_net.c:1638:
+                                        dma_src_start_addr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#433: FILE: lib/vhost/virtio_net.c:1638:
+                                        dma_src_start_addr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#434: FILE: lib/vhost/virtio_net.c:1639:
+                                        dma_dst_start_addr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#434: FILE: lib/vhost/virtio_net.c:1639:
+                                        dma_dst_start_addr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#435: FILE: lib/vhost/virtio_net.c:1640:
+                                        dma_src_len,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#435: FILE: lib/vhost/virtio_net.c:1640:
+                                        dma_src_len,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#436: FILE: lib/vhost/virtio_net.c:1641:
+                                        dma_flags);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#436: FILE: lib/vhost/virtio_net.c:1641:
+                                        dma_flags);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#437: FILE: lib/vhost/virtio_net.c:1642:
+        if (enq_index < 0)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#437: FILE: lib/vhost/virtio_net.c:1642:
+        if (enq_index < 0)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#437: FILE: lib/vhost/virtio_net.c:1642:
+        if (enq_index < 0)
+            break;

ERROR:CODE_INDENT: code indent should use tabs where possible
#438: FILE: lib/vhost/virtio_net.c:1643:
+            break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#438: FILE: lib/vhost/virtio_net.c:1643:
+            break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#439: FILE: lib/vhost/virtio_net.c:1644:
+        dmadev_enq_track[dev_id][enq_index & dmadev_ring_mask] = (void *)addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#439: FILE: lib/vhost/virtio_net.c:1644:
+        dmadev_enq_track[dev_id][enq_index & dmadev_ring_mask] = (void *)addr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#440: FILE: lib/vhost/virtio_net.c:1645:
+        seg_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#440: FILE: lib/vhost/virtio_net.c:1645:
+        seg_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#441: FILE: lib/vhost/virtio_net.c:1646:
+    }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#447: FILE: lib/vhost/virtio_net.c:1652:
+                  const struct rte_vhost_iov_iter *dst_ptr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#447: FILE: lib/vhost/virtio_net.c:1652:
+                  const struct rte_vhost_iov_iter *dst_ptr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#448: FILE: lib/vhost/virtio_net.c:1653:
+                  const uint16_t nr_segs)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#448: FILE: lib/vhost/virtio_net.c:1653:
+                  const uint16_t nr_segs)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#450: FILE: lib/vhost/virtio_net.c:1655:
+    uint16_t seg_idx = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#452: FILE: lib/vhost/virtio_net.c:1657:
+    while (likely(seg_idx < nr_segs)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#453: FILE: lib/vhost/virtio_net.c:1658:
+        /* Fetch source start addr. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#454: FILE: lib/vhost/virtio_net.c:1659:
+        const uintptr_t s_base = (uintptr_t)(src_ptr->iov[seg_idx].iov_base);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#454: FILE: lib/vhost/virtio_net.c:1659:
+        const uintptr_t s_base = (uintptr_t)(src_ptr->iov[seg_idx].iov_base);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#455: FILE: lib/vhost/virtio_net.c:1660:
+        const uintptr_t src_start_addr = src_ptr->offset + s_base;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#455: FILE: lib/vhost/virtio_net.c:1660:
+        const uintptr_t src_start_addr = src_ptr->offset + s_base;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#456: FILE: lib/vhost/virtio_net.c:1661:
+        /* Fetch destination start addr. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#457: FILE: lib/vhost/virtio_net.c:1662:
+        const uintptr_t d_base = (uintptr_t)(dst_ptr->iov[seg_idx].iov_base);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#457: FILE: lib/vhost/virtio_net.c:1662:
+        const uintptr_t d_base = (uintptr_t)(dst_ptr->iov[seg_idx].iov_base);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#458: FILE: lib/vhost/virtio_net.c:1663:
+        const uintptr_t dst_start_addr = dst_ptr->offset + d_base;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#458: FILE: lib/vhost/virtio_net.c:1663:
+        const uintptr_t dst_start_addr = dst_ptr->offset + d_base;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#459: FILE: lib/vhost/virtio_net.c:1664:
+        /* Fetch segment length. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#460: FILE: lib/vhost/virtio_net.c:1665:
+        const size_t src_len = src_ptr->iov[seg_idx].iov_len;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#460: FILE: lib/vhost/virtio_net.c:1665:
+        const size_t src_len = src_ptr->iov[seg_idx].iov_len;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#462: FILE: lib/vhost/virtio_net.c:1667:
+        rte_memcpy((void *) dst_start_addr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#462: FILE: lib/vhost/virtio_net.c:1667:
+        rte_memcpy((void *) dst_start_addr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#463: FILE: lib/vhost/virtio_net.c:1668:
+                   (void *) src_start_addr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#463: FILE: lib/vhost/virtio_net.c:1668:
+                   (void *) src_start_addr,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#464: FILE: lib/vhost/virtio_net.c:1669:
+                   src_len);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#464: FILE: lib/vhost/virtio_net.c:1669:
+                   src_len);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#465: FILE: lib/vhost/virtio_net.c:1670:
+        seg_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#465: FILE: lib/vhost/virtio_net.c:1670:
+        seg_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#466: FILE: lib/vhost/virtio_net.c:1671:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#473: FILE: lib/vhost/virtio_net.c:1678:
+    struct enq_info_t *slot_addr$

ERROR:CODE_INDENT: code indent should use tabs where possible
#474: FILE: lib/vhost/virtio_net.c:1679:
+                        = &(dma_compl->enq_info[dma_compl->write_idx]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#474: FILE: lib/vhost/virtio_net.c:1679:
+                        = &(dma_compl->enq_info[dma_compl->write_idx]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#475: FILE: lib/vhost/virtio_net.c:1680:
+    const uint16_t ring_mask = DMA_COMPLETION_RING_SIZE - 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#477: FILE: lib/vhost/virtio_net.c:1682:
+    dma_compl->write_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#478: FILE: lib/vhost/virtio_net.c:1683:
+    dma_compl->write_idx &= ring_mask;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#479: FILE: lib/vhost/virtio_net.c:1684:
+    dma_compl->count++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#480: FILE: lib/vhost/virtio_net.c:1685:
+    return slot_addr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#486: FILE: lib/vhost/virtio_net.c:1691:
+                        const int max_pkts)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#486: FILE: lib/vhost/virtio_net.c:1691:
+                        const int max_pkts)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#488: FILE: lib/vhost/virtio_net.c:1693:
+    uint32_t pkts;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#489: FILE: lib/vhost/virtio_net.c:1694:
+    int count = dma_compl->count;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#490: FILE: lib/vhost/virtio_net.c:1695:
+    int read_idx = dma_compl->read_idx;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#491: FILE: lib/vhost/virtio_net.c:1696:
+    uint8_t pkt_rcvd = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#492: FILE: lib/vhost/virtio_net.c:1697:
+    const uint16_t ring_mask = DMA_COMPLETION_RING_SIZE - 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#494: FILE: lib/vhost/virtio_net.c:1699:
+    for (pkts = 0; (pkts < (uint32_t)max_pkts) && (count > 0); pkts++) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#495: FILE: lib/vhost/virtio_net.c:1700:
+        read_idx &= ring_mask;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#495: FILE: lib/vhost/virtio_net.c:1700:
+        read_idx &= ring_mask;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#496: FILE: lib/vhost/virtio_net.c:1701:
+        pkt_rcvd = dma_compl->enq_info[read_idx].pkt_rcvd;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#496: FILE: lib/vhost/virtio_net.c:1701:
+        pkt_rcvd = dma_compl->enq_info[read_idx].pkt_rcvd;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#497: FILE: lib/vhost/virtio_net.c:1702:
+        if (!pkt_rcvd) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#497: FILE: lib/vhost/virtio_net.c:1702:
+        if (!pkt_rcvd) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#497: FILE: lib/vhost/virtio_net.c:1702:
+        if (!pkt_rcvd) {
+            break;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#497: FILE: lib/vhost/virtio_net.c:1702:
+        if (!pkt_rcvd) {
+            break;
+        }

ERROR:CODE_INDENT: code indent should use tabs where possible
#498: FILE: lib/vhost/virtio_net.c:1703:
+            break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#498: FILE: lib/vhost/virtio_net.c:1703:
+            break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#499: FILE: lib/vhost/virtio_net.c:1704:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#499: FILE: lib/vhost/virtio_net.c:1704:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#501: FILE: lib/vhost/virtio_net.c:1706:
+        dma_compl->enq_info[read_idx].pkt_rcvd = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#501: FILE: lib/vhost/virtio_net.c:1706:
+        dma_compl->enq_info[read_idx].pkt_rcvd = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#502: FILE: lib/vhost/virtio_net.c:1707:
+        count--;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#502: FILE: lib/vhost/virtio_net.c:1707:
+        count--;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#503: FILE: lib/vhost/virtio_net.c:1708:
+        read_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#503: FILE: lib/vhost/virtio_net.c:1708:
+        read_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#504: FILE: lib/vhost/virtio_net.c:1709:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#505: FILE: lib/vhost/virtio_net.c:1710:
+    dma_compl->count = count;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#506: FILE: lib/vhost/virtio_net.c:1711:
+    dma_compl->read_idx = read_idx;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#507: FILE: lib/vhost/virtio_net.c:1712:
+    return pkts;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#513: FILE: lib/vhost/virtio_net.c:1718:
+                     struct dma_completions_t *compl,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#513: FILE: lib/vhost/virtio_net.c:1718:
+                     struct dma_completions_t *compl,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#514: FILE: lib/vhost/virtio_net.c:1719:
+                     struct rte_vhost_async_desc *descs,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#514: FILE: lib/vhost/virtio_net.c:1719:
+                     struct rte_vhost_async_desc *descs,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#515: FILE: lib/vhost/virtio_net.c:1720:
+                     uint16_t count)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#515: FILE: lib/vhost/virtio_net.c:1720:
+                     uint16_t count)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#517: FILE: lib/vhost/virtio_net.c:1722:
+    uint16_t desc_idx = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#518: FILE: lib/vhost/virtio_net.c:1723:
+    struct enq_info_t *slot_addr = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#520: FILE: lib/vhost/virtio_net.c:1725:
+    if (is_compl_ring_full(compl)) {$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#520: FILE: lib/vhost/virtio_net.c:1725:
+    if (is_compl_ring_full(compl)) {
+        goto out;
+    }

ERROR:CODE_INDENT: code indent should use tabs where possible
#521: FILE: lib/vhost/virtio_net.c:1726:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#521: FILE: lib/vhost/virtio_net.c:1726:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#522: FILE: lib/vhost/virtio_net.c:1727:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#525: FILE: lib/vhost/virtio_net.c:1730:
+    uint16_t dmadev_space_left = rte_dmadev_burst_capacity(dev_id);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#526: FILE: lib/vhost/virtio_net.c:1731:
+    const int compl_space_left = DMA_COMPLETION_RING_SIZE - compl->count;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#527: FILE: lib/vhost/virtio_net.c:1732:
+    if (count > compl_space_left) {$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#527: FILE: lib/vhost/virtio_net.c:1732:
+    if (count > compl_space_left) {
+        count = compl_space_left;
+    }

ERROR:CODE_INDENT: code indent should use tabs where possible
#528: FILE: lib/vhost/virtio_net.c:1733:
+        count = compl_space_left;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#528: FILE: lib/vhost/virtio_net.c:1733:
+        count = compl_space_left;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#529: FILE: lib/vhost/virtio_net.c:1734:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#531: FILE: lib/vhost/virtio_net.c:1736:
+    while (desc_idx < count) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#532: FILE: lib/vhost/virtio_net.c:1737:
+        const struct rte_vhost_iov_iter *src_ptr = descs[desc_idx].src;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#532: FILE: lib/vhost/virtio_net.c:1737:
+        const struct rte_vhost_iov_iter *src_ptr = descs[desc_idx].src;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#533: FILE: lib/vhost/virtio_net.c:1738:
+        const struct rte_vhost_iov_iter *dst_ptr = descs[desc_idx].dst;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#533: FILE: lib/vhost/virtio_net.c:1738:
+        const struct rte_vhost_iov_iter *dst_ptr = descs[desc_idx].dst;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#534: FILE: lib/vhost/virtio_net.c:1739:
+        const uint16_t nr_segs = src_ptr->nr_segs;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#534: FILE: lib/vhost/virtio_net.c:1739:
+        const uint16_t nr_segs = src_ptr->nr_segs;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#535: FILE: lib/vhost/virtio_net.c:1740:
+        if (dmadev_space_left < nr_segs) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#535: FILE: lib/vhost/virtio_net.c:1740:
+        if (dmadev_space_left < nr_segs) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#535: FILE: lib/vhost/virtio_net.c:1740:
+        if (dmadev_space_left < nr_segs) {
+            goto ring_doorbell;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#535: FILE: lib/vhost/virtio_net.c:1740:
+        if (dmadev_space_left < nr_segs) {
+            goto ring_doorbell;
+        }

ERROR:CODE_INDENT: code indent should use tabs where possible
#536: FILE: lib/vhost/virtio_net.c:1741:
+            goto ring_doorbell;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#536: FILE: lib/vhost/virtio_net.c:1741:
+            goto ring_doorbell;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#537: FILE: lib/vhost/virtio_net.c:1742:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#537: FILE: lib/vhost/virtio_net.c:1742:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#538: FILE: lib/vhost/virtio_net.c:1743:
+        slot_addr = compl_slot_get_and_inc(compl);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#538: FILE: lib/vhost/virtio_net.c:1743:
+        slot_addr = compl_slot_get_and_inc(compl);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#539: FILE: lib/vhost/virtio_net.c:1744:
+        dmadev_enqueue_packet(dev_id, src_ptr, dst_ptr, nr_segs, slot_addr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#539: FILE: lib/vhost/virtio_net.c:1744:
+        dmadev_enqueue_packet(dev_id, src_ptr, dst_ptr, nr_segs, slot_addr);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#540: FILE: lib/vhost/virtio_net.c:1745:
+        dmadev_space_left -= nr_segs;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#540: FILE: lib/vhost/virtio_net.c:1745:
+        dmadev_space_left -= nr_segs;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#541: FILE: lib/vhost/virtio_net.c:1746:
+        desc_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#541: FILE: lib/vhost/virtio_net.c:1746:
+        desc_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#542: FILE: lib/vhost/virtio_net.c:1747:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#545: FILE: lib/vhost/virtio_net.c:1750:
+    if (desc_idx != 0) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#546: FILE: lib/vhost/virtio_net.c:1751:
+        /* Ring the doorbell. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#547: FILE: lib/vhost/virtio_net.c:1752:
+        rte_dmadev_submit(dev_id, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#547: FILE: lib/vhost/virtio_net.c:1752:
+        rte_dmadev_submit(dev_id, 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#548: FILE: lib/vhost/virtio_net.c:1753:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#551: FILE: lib/vhost/virtio_net.c:1756:
+    while (desc_idx < count) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#552: FILE: lib/vhost/virtio_net.c:1757:
+        const struct rte_vhost_iov_iter *src_ptr = descs[desc_idx].src;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#552: FILE: lib/vhost/virtio_net.c:1757:
+        const struct rte_vhost_iov_iter *src_ptr = descs[desc_idx].src;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#553: FILE: lib/vhost/virtio_net.c:1758:
+        const struct rte_vhost_iov_iter *dst_ptr = descs[desc_idx].dst;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#553: FILE: lib/vhost/virtio_net.c:1758:
+        const struct rte_vhost_iov_iter *dst_ptr = descs[desc_idx].dst;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#554: FILE: lib/vhost/virtio_net.c:1759:
+        slot_addr = compl_slot_get_and_inc(compl);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#554: FILE: lib/vhost/virtio_net.c:1759:
+        slot_addr = compl_slot_get_and_inc(compl);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#555: FILE: lib/vhost/virtio_net.c:1760:
+        sw_enqueue_packet(src_ptr, dst_ptr, src_ptr->nr_segs);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#555: FILE: lib/vhost/virtio_net.c:1760:
+        sw_enqueue_packet(src_ptr, dst_ptr, src_ptr->nr_segs);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#556: FILE: lib/vhost/virtio_net.c:1761:
+        slot_addr->pkt_rcvd = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#556: FILE: lib/vhost/virtio_net.c:1761:
+        slot_addr->pkt_rcvd = 1;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#557: FILE: lib/vhost/virtio_net.c:1762:
+        desc_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#557: FILE: lib/vhost/virtio_net.c:1762:
+        desc_idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#558: FILE: lib/vhost/virtio_net.c:1763:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#561: FILE: lib/vhost/virtio_net.c:1766:
+    return desc_idx;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#567: FILE: lib/vhost/virtio_net.c:1772:
+                              struct dma_completions_t *compl,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#567: FILE: lib/vhost/virtio_net.c:1772:
+                              struct dma_completions_t *compl,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#568: FILE: lib/vhost/virtio_net.c:1773:
+                              uint16_t max_pkts)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#568: FILE: lib/vhost/virtio_net.c:1773:
+                              uint16_t max_pkts)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#570: FILE: lib/vhost/virtio_net.c:1775:
+    bool error;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#571: FILE: lib/vhost/virtio_net.c:1776:
+    uint16_t last_idx;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#572: FILE: lib/vhost/virtio_net.c:1777:
+    uint32_t nr_pkts = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#573: FILE: lib/vhost/virtio_net.c:1778:
+    struct enq_info_t *slots;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#574: FILE: lib/vhost/virtio_net.c:1779:
+    const uint16_t mask = VHOST_ASYNC_DMADEV_RING_SIZE-1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#576: FILE: lib/vhost/virtio_net.c:1781:
+    if (unlikely(is_compl_ring_empty(compl))) {$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#576: FILE: lib/vhost/virtio_net.c:1781:
+    if (unlikely(is_compl_ring_empty(compl))) {
+        goto out;
+    }

ERROR:CODE_INDENT: code indent should use tabs where possible
#577: FILE: lib/vhost/virtio_net.c:1782:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#577: FILE: lib/vhost/virtio_net.c:1782:
+        goto out;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#578: FILE: lib/vhost/virtio_net.c:1783:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#581: FILE: lib/vhost/virtio_net.c:1786:
+    const int ret_segs = rte_dmadev_completed(dev_id,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#582: FILE: lib/vhost/virtio_net.c:1787:
+                                              0,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#582: FILE: lib/vhost/virtio_net.c:1787:
+                                              0,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#583: FILE: lib/vhost/virtio_net.c:1788:
+                                              MAX_PKT_BURST,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#583: FILE: lib/vhost/virtio_net.c:1788:
+                                              MAX_PKT_BURST,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#584: FILE: lib/vhost/virtio_net.c:1789:
+                                              &last_idx,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#584: FILE: lib/vhost/virtio_net.c:1789:
+                                              &last_idx,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#585: FILE: lib/vhost/virtio_net.c:1790:
+                                              &error);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#585: FILE: lib/vhost/virtio_net.c:1790:
+                                              &error);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#586: FILE: lib/vhost/virtio_net.c:1791:
+    if (unlikely(error)) {$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#586: FILE: lib/vhost/virtio_net.c:1791:
+    if (unlikely(error)) {
+        return -1;
+    }

ERROR:CODE_INDENT: code indent should use tabs where possible
#587: FILE: lib/vhost/virtio_net.c:1792:
+        return -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#587: FILE: lib/vhost/virtio_net.c:1792:
+        return -1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#588: FILE: lib/vhost/virtio_net.c:1793:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#590: FILE: lib/vhost/virtio_net.c:1795:
+    uint16_t idx = (last_idx - ret_segs + 1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#591: FILE: lib/vhost/virtio_net.c:1796:
+    for (int i = 0; i < ret_segs; i++) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#592: FILE: lib/vhost/virtio_net.c:1797:
+        slots = (struct enq_info_t* )dmadev_enq_track[dev_id][idx & mask];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#592: FILE: lib/vhost/virtio_net.c:1797:
+        slots = (struct enq_info_t* )dmadev_enq_track[dev_id][idx & mask];$

ERROR:POINTER_LOCATION: "(foo* )" should be "(foo *)"
#592: FILE: lib/vhost/virtio_net.c:1797:
+        slots = (struct enq_info_t* )dmadev_enq_track[dev_id][idx & mask];

ERROR:SPACING: space prohibited before that close parenthesis ')'
#592: FILE: lib/vhost/virtio_net.c:1797:
+        slots = (struct enq_info_t* )dmadev_enq_track[dev_id][idx & mask];

ERROR:CODE_INDENT: code indent should use tabs where possible
#593: FILE: lib/vhost/virtio_net.c:1798:
+        if (slots) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#593: FILE: lib/vhost/virtio_net.c:1798:
+        if (slots) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#593: FILE: lib/vhost/virtio_net.c:1798:
+        if (slots) {
[...]
+            slots->pkt_rcvd = 1;

WARNING:TYPO_SPELLING: 'recieved' may be misspelled - perhaps 'received'?
#594: FILE: lib/vhost/virtio_net.c:1799:
+            /* Mark the packet slot as recieved.

ERROR:CODE_INDENT: code indent should use tabs where possible
#594: FILE: lib/vhost/virtio_net.c:1799:
+            /* Mark the packet slot as recieved.$

ERROR:CODE_INDENT: code indent should use tabs where possible
#595: FILE: lib/vhost/virtio_net.c:1800:
+             * The slot could belong to another queue but writes are atomic. */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#595: FILE: lib/vhost/virtio_net.c:1800:
+             * The slot could belong to another queue but writes are atomic. */

ERROR:CODE_INDENT: code indent should use tabs where possible
#596: FILE: lib/vhost/virtio_net.c:1801:
+            slots->pkt_rcvd = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#596: FILE: lib/vhost/virtio_net.c:1801:
+            slots->pkt_rcvd = 1;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#597: FILE: lib/vhost/virtio_net.c:1802:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#597: FILE: lib/vhost/virtio_net.c:1802:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#598: FILE: lib/vhost/virtio_net.c:1803:
+        idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#598: FILE: lib/vhost/virtio_net.c:1803:
+        idx++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#599: FILE: lib/vhost/virtio_net.c:1804:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#601: FILE: lib/vhost/virtio_net.c:1806:
+    nr_pkts = count_completed_packets(compl, max_pkts);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#604: FILE: lib/vhost/virtio_net.c:1809:
+    return nr_pkts;$

total: 91 errors, 156 warnings, 762 lines checked
Warning in lib/vhost/virtio_net.c:
Declaring a variable inside for()
Previous message (by thread): [dpdk-test-report] |WARNING| pw97220 [PATCH v5 2/2] net: added macro to extract MAC address bytes
Next message (by thread): [dpdk-test-report] |WARNING| pw97223 [PATCH] RFC: ethdev: add reassembly offload
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list