[dpdk-test-report] |WARNING| pw97409 [PATCH v2] ethdev: add namespace

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Aug 27 03:25:44 CEST 2021
Previous message (by thread): [dpdk-test-report] |WARNING| pw97407 [PATCH v2] net/axgbe: fix potential unreleased lock problem
Next message (by thread): [dpdk-test-report] |WARNING| pw97409 [PATCH] [v2] ethdev: add namespace
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97409

_coding style issues_


WARNING:BAD_SIGN_OFF: 'Acked-by:' is the preferred signature form
#134: 
Acked-By: Tyler Retzlaff <roretzla at linux.microsoft.com>

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#1121: FILE: app/test-pmd/cmdline.c:7346:
+			{RTE_ETH_FC_NONE, RTE_ETH_FC_TX_PAUSE}, {RTE_ETH_FC_RX_PAUSE, RTE_ETH_FC_FULL}

WARNING:SUSPECT_COMMA_SEMICOLON: Possible comma where semicolon could be used
#2200: FILE: app/test/test_ethdev_link.c:32:
+	link_status.link_speed = RTE_ETH_SPEED_NUM_10M,
 	ret = rte_eth_link_to_str(text, sizeof(text), &link_status);

WARNING:TABSTOP: Statements should start on a tabstop
#5460: FILE: drivers/net/bonding/rte_eth_bond_api.c:589:
+		 if (link_props.link_status == RTE_ETH_LINK_UP) {

WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#7678: FILE: drivers/net/e1000/em_ethdev.c:602:
+	mask = RTE_ETH_VLAN_STRIP_MASK | RTE_ETH_VLAN_FILTER_MASK | \

ERROR:SPACING: space required before the open brace '{'
#7778: FILE: drivers/net/e1000/em_ethdev.c:1429:
+	if(mask & RTE_ETH_VLAN_STRIP_MASK){

ERROR:SPACING: space required before the open parenthesis '('
#7778: FILE: drivers/net/e1000/em_ethdev.c:1429:
+	if(mask & RTE_ETH_VLAN_STRIP_MASK){

ERROR:SPACING: space required before the open brace '{'
#7787: FILE: drivers/net/e1000/em_ethdev.c:1436:
+	if(mask & RTE_ETH_VLAN_FILTER_MASK){

ERROR:SPACING: space required before the open parenthesis '('
#7787: FILE: drivers/net/e1000/em_ethdev.c:1436:
+	if(mask & RTE_ETH_VLAN_FILTER_MASK){

WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#8063: FILE: drivers/net/e1000/igb_ethdev.c:1299:
+	mask = RTE_ETH_VLAN_STRIP_MASK | RTE_ETH_VLAN_FILTER_MASK | \

ERROR:SPACING: space required before the open brace '{'
#8251: FILE: drivers/net/e1000/igb_ethdev.c:2719:
+	if(mask & RTE_ETH_VLAN_STRIP_MASK){

ERROR:SPACING: space required before the open parenthesis '('
#8251: FILE: drivers/net/e1000/igb_ethdev.c:2719:
+	if(mask & RTE_ETH_VLAN_STRIP_MASK){

ERROR:SPACING: space required before the open brace '{'
#8260: FILE: drivers/net/e1000/igb_ethdev.c:2726:
+	if(mask & RTE_ETH_VLAN_FILTER_MASK){

ERROR:SPACING: space required before the open parenthesis '('
#8260: FILE: drivers/net/e1000/igb_ethdev.c:2726:
+	if(mask & RTE_ETH_VLAN_FILTER_MASK){

ERROR:SPACING: space required before the open brace '{'
#8269: FILE: drivers/net/e1000/igb_ethdev.c:2733:
+	if(mask & RTE_ETH_VLAN_EXTEND_MASK){

ERROR:SPACING: space required before the open parenthesis '('
#8269: FILE: drivers/net/e1000/igb_ethdev.c:2733:
+	if(mask & RTE_ETH_VLAN_EXTEND_MASK){

ERROR:CODE_INDENT: code indent should use tabs where possible
#8581: FILE: drivers/net/e1000/igb_rxtx.c:2231:
+                        (cfg->pool_map[i].vlan_id & RTE_ETH_VLAN_ID_MAX) | \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8581: FILE: drivers/net/e1000/igb_rxtx.c:2231:
+                        (cfg->pool_map[i].vlan_id & RTE_ETH_VLAN_ID_MAX) | \$

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#8597: FILE: drivers/net/e1000/igb_rxtx.c:2297:
 		switch (dev->data->dev_conf.rxmode.mq_mode) {
+			case RTE_ETH_MQ_RX_RSS:
[...]
+			case RTE_ETH_MQ_RX_VMDQ_ONLY:
[...]
+			case RTE_ETH_MQ_RX_NONE:

WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#14002: FILE: drivers/net/iavf/iavf_hash.c:438:
+	{iavf_pattern_eth_ipv4_gtpu,			RTE_ETH_RSS_IPV4,			&outer_ipv4_udp_tmplt},

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#14013: FILE: drivers/net/iavf/iavf_hash.c:480:
+	{iavf_pattern_eth_ipv4_gtpc,			RTE_ETH_RSS_IPV4,			&ipv4_udp_gtpc_tmplt},

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#14014: FILE: drivers/net/iavf/iavf_hash.c:481:
+	{iavf_pattern_eth_ecpri,			RTE_ETH_RSS_ECPRI,			&eth_ecpri_tmplt},

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#14015: FILE: drivers/net/iavf/iavf_hash.c:482:
+	{iavf_pattern_eth_ipv4_ecpri,			RTE_ETH_RSS_ECPRI,			&ipv4_ecpri_tmplt},

WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#14024: FILE: drivers/net/iavf/iavf_hash.c:500:
+	{iavf_pattern_eth_ipv6_gtpu,			RTE_ETH_RSS_IPV6,			&outer_ipv6_udp_tmplt},

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#14033: FILE: drivers/net/iavf/iavf_hash.c:542:
+	{iavf_pattern_eth_ipv6_gtpc,			RTE_ETH_RSS_IPV6,			&ipv6_udp_gtpc_tmplt},

WARNING:BRACES: braces {} are not necessary for single statement blocks
#17120: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:2154:
+	if (mask & RTE_ETH_VLAN_STRIP_MASK) {
 		ixgbe_vlan_hw_strip_config(dev);
 	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rxmode->max_rx_pkt_len >= IXGBE_MAX_JUMBO_FRAME_SIZE'
#17742: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:6269:
+	if ((rxmode->offloads & RTE_ETH_RX_OFFLOAD_JUMBO_FRAME) &&
 	    (rxmode->max_rx_pkt_len >= IXGBE_MAX_JUMBO_FRAME_SIZE))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'j < RTE_ETH_DCB_NUM_USER_PRIORITIES'
#18531: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:4223:
+			if ((mask & 0x1) && (j < RTE_ETH_DCB_NUM_USER_PRIORITIES))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#18540: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:4273:
+		for (; i < RTE_ETH_DCB_NUM_USER_PRIORITIES; i++) {
 			IXGBE_WRITE_REG(hw, IXGBE_RXPBSIZE(i), 0);
 		}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_VMDQ_DCB'
#18578: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:4360:
+	if ((dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_VMDQ_DCB) &&
+	    (dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB) &&
+	    (dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB_RSS))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB'
#18578: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:4360:
+	if ((dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_VMDQ_DCB) &&
+	    (dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB) &&
+	    (dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB_RSS))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB_RSS'
#18578: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:4360:
+	if ((dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_VMDQ_DCB) &&
+	    (dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB) &&
+	    (dev_conf->rxmode.mq_mode != RTE_ETH_MQ_RX_DCB_RSS))

ERROR:SPACING: space required after that ',' (ctx:VxV)
#19033: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.h:288:
+*    RTE_ETH_VMDQ_ACCEPT_UNTAG,RTE_ETH_VMDQ_ACCEPT_HASH_UC,
                               ^

ERROR:SPACING: space prohibited after that '*' (ctx:ExW)
#19034: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.h:289:
+*    RTE_ETH_VMDQ_ACCEPT_BROADCAST and RTE_ETH_VMDQ_ACCEPT_MULTICAST will be used
 ^

WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#28791: FILE: examples/link_status_interrupt/main.c:150:
+			   (link.link_duplex == RTE_ETH_LINK_FULL_DUPLEX ? \

ERROR:SPACING: space required before the open brace '{'
#29447: FILE: examples/vmdq_dcb/main.c:160:
+	for (i = 0; i < RTE_ETH_DCB_NUM_USER_PRIORITIES; i++){

total: 15 errors, 16 warnings, 27725 lines checked
Previous message (by thread): [dpdk-test-report] |WARNING| pw97407 [PATCH v2] net/axgbe: fix potential unreleased lock problem
Next message (by thread): [dpdk-test-report] |WARNING| pw97409 [PATCH] [v2] ethdev: add namespace
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list