|WARNING| pw105528 [PATCH v1 1/1] vhost: integrate dmadev in asynchronous datapath

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Dec 30 14:52:27 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105528

_coding style issues_


WARNING:TYPO_SPELLING: 'applcations' may be misspelled - perhaps 'applications'?
#179: FILE: doc/guides/prog_guide/vhost_lib.rst:420:
+enables applcations, like OVS, to save CPU cycles and hide memory copy

WARNING:BRACES: braces {} are not necessary for single statement blocks
#551: FILE: examples/vhost/main.c:212:
+		if (dma_config[i].dev_id == dev_id) {
+			return true;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#812: FILE: examples/vhost/main.c:1600:
+		if (ret == 0) {
+			dma_bind[vid].dmas[VIRTIO_RXQ].async_enabled = true;
 		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#855: FILE: examples/vhost/main.c:1794:
+	for (i = 0; i < RTE_DMADEV_DEFAULT_MAX; i++) {
+		dma_config[i].dev_id = INVALID_DMA_ID;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1295: FILE: lib/vhost/vhost.c:1826:
+		if (dma->max_vchans == 0) {
+			continue;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1299: FILE: lib/vhost/vhost.c:1830:
+		for (j = 0; j < dma->max_vchans; j++) {
+			rte_free(dma->vchans[j].metadata);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1329: FILE: lib/vhost/vhost.c:1860:
+		if (!rte_is_power_of_2(max_desc)) {
+			max_desc = rte_align32pow2(max_desc);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1501: FILE: lib/vhost/virtio_net.c:67:
+		if (rte_dma_burst_capacity(dma_id, vchan) < nr_segs) {
+			goto out;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1560: FILE: lib/vhost/virtio_net.c:126:
+	if (nr_copies == 0) {
+		goto out;
+	}

total: 0 errors, 9 warnings, 1324 lines checked


More information about the test-report mailing list