[dpdk-test-report] |WARNING| pw87839 [PATCH v3] log: support custom log function

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 16 10:35:50 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/87839

_coding style issues_


ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#130: FILE: lib/librte_eal/include/rte_log.h:116:
+rte_log_sink_set(rte_log_write_function* logf);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#162: FILE: lib/librte_eal/linux/eal_log.c:71:
+rte_log_sink_set(rte_log_write_function* logf)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/librte_eal/linux/eal_log.c:73:
+    console_log_func.write = logf;$

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#171: FILE: lib/librte_eal/linux/eal_log.c:80:
+rte_log_write_function*
+rte_log_sink_get(void) {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: lib/librte_eal/linux/eal_log.c:82:
+    return console_log_func.write;$

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#202: FILE: lib/librte_eal/windows/eal_log.c:23:
+rte_log_sink_set(rte_log_write_function* logf)

WARNING:RETURN_VOID: void function return statements are not generally useful
#206: FILE: lib/librte_eal/windows/eal_log.c:27:
+	return;
+}

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#211: FILE: lib/librte_eal/windows/eal_log.c:32:
+rte_log_write_function*
+rte_log_sink_get(void) {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: lib/librte_eal/windows/eal_log.c:34:
+    return NULL;$

total: 5 errors, 4 warnings, 89 lines checked


More information about the test-report mailing list