[dpdk-test-report] |WARNING| pw93918 [PATCH v8 06/10] eal: add thread lifetime management
checkpatch at dpdk.org
checkpatch at dpdk.org
Sat Jun 5 01:40:25 CEST 2021
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93918
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#60:
The *rte_thread_create()* function can optionally receive an rte_thread_attr_t
WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#170: FILE: lib/eal/common/rte_thread.c:235:
+ void **pres = NULL;
WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#173: FILE: lib/eal/common/rte_thread.c:238:
+ pres = &res;
WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#175: FILE: lib/eal/common/rte_thread.c:240:
+ ret = pthread_join(thread_id.opaque_id, pres);
WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#181: FILE: lib/eal/common/rte_thread.c:246:
+ if (pres != NULL)
WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#182: FILE: lib/eal/common/rte_thread.c:247:
+ *value_ptr = *(int *)(*pres);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#293: FILE: lib/eal/windows/rte_thread.c:18:
+ void* (*start_routine) (void*);
WARNING:SPACING: Unnecessary space before function pointer arguments
#293: FILE: lib/eal/windows/rte_thread.c:18:
+ void* (*start_routine) (void*);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'void*' should also have an identifier name
#293: FILE: lib/eal/windows/rte_thread.c:18:
+ void* (*start_routine) (void*);
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#350: FILE: lib/eal/windows/rte_thread.c:400:
+ ret = rte_convert_cpuset_to_affinity(&thread_attr->cpuset, &thread_affinity);
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#458: FILE: lib/eal/windows/rte_thread.c:508:
+ return ENOTSUP;
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 2 errors, 10 warnings, 369 lines checked
More information about the test-report
mailing list