[dpdk-test-report] |WARNING| pw88938 [PATCH 5/8] common/sfc_efx/base: add support to verify virtio features

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Mar 11 12:05:52 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88938

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#98: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+	efx_rc_t	(*evo_verify_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_device_type_t' should also have an identifier name
#98: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+	efx_rc_t	(*evo_verify_features)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#98: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+	efx_rc_t	(*evo_verify_features)(efx_nic_t *,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#141: FILE: drivers/common/sfc_efx/base/efx_virtio.c:325:
+	if ((rc = evop->evo_verify_features(enp, type, features)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#144: FILE: drivers/common/sfc_efx/base/efx_virtio.c:328:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#153: FILE: drivers/common/sfc_efx/base/efx_virtio.c:337:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#224: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:376:
+	return (rc);

total: 4 errors, 3 warnings, 137 lines checked


More information about the test-report mailing list