[dpdk-test-report] |WARNING| pw93560 [PATCH 11/58] net/bnxt: add hashing changes for Thor

checkpatch at dpdk.org checkpatch at dpdk.org
Sun May 30 11:03:01 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93560

_coding style issues_


WARNING:TYPO_SPELLING: 'bae' may be misspelled - perhaps 'base'?
#236: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_common.c:61:
+0x95bf4a82, 0xe2b87a14, 0x7bb12bae, 0x0cb61b38,

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crc' - possible side-effects?
#275: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_defs.h:63:
+#define ucrc32(ch, crc) (crc32tbl[((crc) ^ (ch)) & 0xff] ^ ((crc) >> 8))

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#308: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_p4.c:19:
+extern const uint32_t crc32tbl[];

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#450: FILE: drivers/net/bnxt/hcapi/cfa/hcapi_cfa_p58.c:19:
+extern const uint32_t crc32tbl[];

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#617: FILE: drivers/net/bnxt/tf_core/tf_device_p4.c:21:
+uint64_t hcapi_cfa_key_hash_p4(uint64_t *key_data,

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#637: FILE: drivers/net/bnxt/tf_core/tf_device_p58.c:21:
+uint64_t hcapi_cfa_key_hash_p58(uint64_t *key_data,

total: 0 errors, 5 warnings, 1 checks, 667 lines checked


More information about the test-report mailing list