|WARNING| pw104123 [PATCH] mempool: fix rte primary program coredump

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Nov 10 16:58:19 CET 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/104123

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#81: 
 #0  0x00007ffff5f2cc0b in bucket_stack_pop (stack=0xffff00010000) at /ofp/dpdk/drivers/mempool/bucket/rte_mempool_bucket.c:95

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#168: FILE: lib/librte_mempool/rte_mempool_ops.c

ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: lib/librte_mempool/rte_mempool_ops.c:78:
+                "dpaa2", "dpaa", "bucket",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: lib/librte_mempool/rte_mempool_ops.c:78:
+                "dpaa2", "dpaa", "bucket",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#184: FILE: lib/librte_mempool/rte_mempool_ops.c:79:
+        };$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: lib/librte_mempool/rte_mempool_ops.c:79:
+        };$

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#189: FILE: lib/librte_mempool/rte_mempool_ops.c:84:
+	uint32_t i = 0, j= 0;
 	                 ^

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#192: FILE: lib/librte_mempool/rte_mempool_ops.c:87:
+		const char* name = memops_name[i];

ERROR:SPACING: space required before the open parenthesis '('
#193: FILE: lib/librte_mempool/rte_mempool_ops.c:88:
+		if(name && strlen(name)) {

ERROR:SPACING: space required before the open parenthesis '('
#194: FILE: lib/librte_mempool/rte_mempool_ops.c:89:
+			for(j = 0; j < rte_mempool_ops_table.num_ops; j++) {

ERROR:SPACING: space required before the open parenthesis '('
#195: FILE: lib/librte_mempool/rte_mempool_ops.c:90:
+				if(strcmp(name, rte_mempool_ops_table.ops[j].name))

total: 8 errors, 3 warnings, 57 lines checked


More information about the test-report mailing list