[dpdk-test-report] |WARNING| pw100195 [PATCH 2/9] net/bnxt: support multi root capability flag

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Oct 1 08:01:23 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/100195

_coding style issues_


WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#62: 
capability is enabled in the hardware. DPDK HSI version updated

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#190: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10272:
+	#define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD \

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#194: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10275:
+		HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#343: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10557:
+	#define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_MASK \

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#345: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10559:
+	#define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_SFT \

WARNING:LONG_LINE: line length of 123 exceeds 100 columns
#352: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10566:
+	#define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD \

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#354: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10568:
+	#define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_LAST \

WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#355: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10569:
+		HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD

WARNING:REPEATED_WORD: Possible repeated word: 'the'
#466: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:12879:
+	 * If set to 0xFF... (All Fs), then the the configuration is

WARNING:REPEATED_WORD: Possible repeated word: 'block'
#494: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:13618:
+	 * block block. When this bit is ‘0’, this flag has no effect.

WARNING:REPEATED_WORD: Possible repeated word: 'block'
#503: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:13632:
+	 * block block. When this bit is ‘0’, this flag has no effect.

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#1233: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19044:
+	/* PTM Master timestamp value. */

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#1235: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19046:
+	/* PTM Master propagation delay */

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1285: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19096:
+	 * This bit must be '1' for the phc_master_fid field to be

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#1288: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19099:
+	#define HWRM_FUNC_PTP_EXT_CFG_INPUT_ENABLES_PHC_MASTER_FID \

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#1309: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19120:
+	 * This field is used to configure the Master function. Only this

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#1314: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19125:
+	 * the first function that makes the call to modify PHC as the Master.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1316: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19127:
+	uint16_t	phc_master_fid;

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#1319: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19130:
+	 * function becomes the Master function in case of failover from

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#1320: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19131:
+	 * Master function.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1322: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19133:
+	 * the last non-master function to make a call to condition PHC as

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1354: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19165:
+	 * current master to secondary fid.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1359: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19170:
+	 * at least 6 seconds, then secondary takes over as master to condition

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#1363: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19174:
+	 * happens. Admin or auto selected Master will always be used for

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1444: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19255:
+	 * Firmware returns the current PHC master function. This function

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1447: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19258:
+	uint16_t	phc_master_fid;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1454: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19265:
+	 * Firmware returns the last non-master/non-secondary function to

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1459: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19270:
+	 * Firmware returns the second last non-master/non-secondary function

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1464: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19275:
+	 * Timestamp indicating the last time a failover happened. The master

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1470: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19281:
+	 * Last failover happened from this function. This was the master

WARNING:TYPO_SPELLING: 'chooose' may be misspelled - perhaps 'choose'?
#1795: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20316:
+	 * The user must chooose a value that is not conflicting with

WARNING:TYPO_SPELLING: 'chooose' may be misspelled - perhaps 'choose'?
#1804: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20575:
+	 * The user must chooose a value that is not conflicting with

WARNING:REPEATED_WORD: Possible repeated word: 'the'
#2837: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:32719:
+	 * conflict with the the CoS to VNIC steering rules in this mode.

WARNING:REPEATED_WORD: Possible repeated word: 'the'
#2896: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:44277:
+	 * When set to 1, indicates the the FW supports the Centralized

WARNING:REPEATED_WORD: Possible repeated word: 'the'
#2904: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:44284:
+	 * When set to 1, indicates the the FW supports the Detached

WARNING:TYPO_SPELLING: 'seesion' may be misspelled - perhaps 'session'?
#3078: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:45272:
+	 * Indicates if the shared session has been created. Shared seesion

WARNING:REPEATED_WORD: Possible repeated word: 'the'
#3153: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:46854:
+	 * When set to 1, indicates the the FW supports the Centralized

WARNING:REPEATED_WORD: Possible repeated word: 'the'
#3161: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:46861:
+	 * When set to 1, indicates the the FW supports the Detached

WARNING:LONG_LINE_COMMENT: line length of 134 exceeds 100 columns
#3333: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50307:
+	/* The Directory Entry Type (valid values are defined in the bnxnvm_directory_type enum defined in the file bnxnvm_defs.h). */

WARNING:LONG_LINE_COMMENT: line length of 118 exceeds 100 columns
#3345: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50319:
+	 * Length of data to write, in bytes. May be less than or equal to the allocated size for the directory entry.

WARNING:LONG_LINE_COMMENT: line length of 122 exceeds 100 columns
#3346: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50320:
+	 * The data length stored in the directory entry will be updated to reflect this value once the write is complete.

WARNING:LONG_LINE_COMMENT: line length of 164 exceeds 100 columns
#3374: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50351:
+	 * The requested length of the allocated NVM for the item, in bytes. This value may be greater than or equal to the specified data length (dir_data_length).

WARNING:LONG_LINE_COMMENT: line length of 123 exceeds 100 columns
#3382: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50353:
+	 * The response will contain the actual allocated item length, which may be greater than the requested item length.

WARNING:LONG_LINE_COMMENT: line length of 153 exceeds 100 columns
#3383: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50354:
+	 * The purpose for allocating more than the required number of bytes for an item's data is to pre-allocate extra storage (padding) to accommodate

WARNING:LONG_LINE_COMMENT: line length of 137 exceeds 100 columns
#3384: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50355:
+	 * the potential future growth of an item (e.g. upgraded firmware with a size increase, log growth, expanded configuration data).

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#3389: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50360:
+	 * Only valid for batch mode. For non-batch writes 'dont care'.

WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#3394: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50365:
+	 * Only valid for batch mode. For non-batch writes 'dont care'.

WARNING:LONG_LINE_COMMENT: line length of 160 exceeds 100 columns
#3408: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50382:
+	 * Length of the allocated NVM for the item, in bytes. The value may be greater than or equal to the specified data length or the requested item length.

WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns
#3409: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50383:
+	 * The actual item length used when creating a new directory entry will be a multiple of an NVM block size.

WARNING:LONG_LINE_COMMENT: line length of 133 exceeds 100 columns
#3421: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50727:
+	/* Available size that can be used, in bytes.  Available size is the NVRAM size take away the used size and reserved size. */

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#3433: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50869:
+	/* The Directory Entry Extension flags (see BNX_DIR_EXT_* for extension flag definitions). */

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#3445: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:51038:
+	 * If set to 1, then unspecified images, images not in the package file, will be safely deleted.

WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#3482: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:51430:
+	/* When this bit is 1, flush internal cache after this write operation (see hwrm_nvm_flush command.) */

total: 0 errors, 53 warnings, 0 checks, 3423 lines checked


More information about the test-report mailing list