[dpdk-test-report] |WARNING| pw99652 [PATCH] net/bnxt: remove code to initialize SRAM slice node

[dpdklab at iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/99652

_apply patch failure_

Submitter: Ajit Khaparde <ajit.khaparde at broadcom.com>
Date: Saturday, September 25 2021 14:24:01 
Applied on: CommitID:2700326085033fd13339a8de31f58a95d1ee9c3f
Apply patch set 99652 failed:

Checking patch drivers/net/bnxt/tf_core/tf_sram_mgr.c...
error: while searching for:
	return rc;
}

/**
 * Initialize slice list
 */
static void
tf_sram_init_slice_list(struct tf_sram_slice_list *slice_list,
			enum tf_sram_slice_size slice_size)
{
	slice_list->head = NULL;
	slice_list->tail = NULL;
	slice_list->cnt = 0;
	slice_list->size = slice_size;
}

/**
 * Get the block count
 */

error: patch failed: drivers/net/bnxt/tf_core/tf_sram_mgr.c:407
error: while searching for:
tf_sram_mgr_bind(void **sram_handle)
{
	int rc = 0;
	enum tf_sram_bank_id bank_id;
	enum tf_sram_slice_size slice_size;
	struct tf_sram *sram;
	struct tf_sram_slice_list *slice_list;
	enum tf_dir dir;
	struct tfp_calloc_parms cparms;

	TF_CHECK_PARMS1(sram_handle);

error: patch failed: drivers/net/bnxt/tf_core/tf_sram_mgr.c:568
error: while searching for:
		return rc;
	}
	sram = (struct tf_sram *)cparms.mem_va;

	/* For each direction
	 */
	for (dir = 0; dir < TF_DIR_MAX; dir++) {
		/* For each bank
		 */
		for (bank_id = TF_SRAM_BANK_ID_0;
		     bank_id < TF_SRAM_BANK_ID_MAX;
		     bank_id++) {
			/* Create each sized slice empty list
			 */
			for (slice_size = TF_SRAM_SLICE_SIZE_8B;
			     slice_size < TF_SRAM_SLICE_SIZE_MAX;
			     slice_size++) {
				rc = tf_sram_get_slice_list(sram, &slice_list,
							    slice_size, dir,
							    bank_id);
				if (rc) {
					/* Log error */
					TFP_DRV_LOG(ERR,
						  "No SRAM slice list, rc:%s\n",
						  strerror(-rc));
					return rc;
				}
				tf_sram_init_slice_list(slice_list, slice_size);
			}
		}
	}

	*sram_handle = sram;

	return rc;
}


error: patch failed: drivers/net/bnxt/tf_core/tf_sram_mgr.c:589
Applying patch drivers/net/bnxt/tf_core/tf_sram_mgr.c with 3 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
diff a/drivers/net/bnxt/tf_core/tf_sram_mgr.c b/drivers/net/bnxt/tf_core/tf_sram_mgr.c	(rejected hunks)
@@ -407,19 +407,6 @@ tf_sram_is_slice_allocated_in_block(struct tf_sram_block *block,
 	return rc;
 }
 
-/**
- * Initialize slice list
- */
-static void
-tf_sram_init_slice_list(struct tf_sram_slice_list *slice_list,
-			enum tf_sram_slice_size slice_size)
-{
-	slice_list->head = NULL;
-	slice_list->tail = NULL;
-	slice_list->cnt = 0;
-	slice_list->size = slice_size;
-}
-
 /**
  * Get the block count
  */
@@ -568,11 +555,7 @@ int
 tf_sram_mgr_bind(void **sram_handle)
 {
 	int rc = 0;
-	enum tf_sram_bank_id bank_id;
-	enum tf_sram_slice_size slice_size;
 	struct tf_sram *sram;
-	struct tf_sram_slice_list *slice_list;
-	enum tf_dir dir;
 	struct tfp_calloc_parms cparms;
 
 	TF_CHECK_PARMS1(sram_handle);
@@ -589,37 +572,7 @@ tf_sram_mgr_bind(void **sram_handle)
 		return rc;
 	}
 	sram = (struct tf_sram *)cparms.mem_va;
-
-	/* For each direction
-	 */
-	for (dir = 0; dir < TF_DIR_MAX; dir++) {
-		/* For each bank
-		 */
-		for (bank_id = TF_SRAM_BANK_ID_0;
-		     bank_id < TF_SRAM_BANK_ID_MAX;
-		     bank_id++) {
-			/* Create each sized slice empty list
-			 */
-			for (slice_size = TF_SRAM_SLICE_SIZE_8B;
-			     slice_size < TF_SRAM_SLICE_SIZE_MAX;
-			     slice_size++) {
-				rc = tf_sram_get_slice_list(sram, &slice_list,
-							    slice_size, dir,
-							    bank_id);
-				if (rc) {
-					/* Log error */
-					TFP_DRV_LOG(ERR,
-						  "No SRAM slice list, rc:%s\n",
-						  strerror(-rc));
-					return rc;
-				}
-				tf_sram_init_slice_list(slice_list, slice_size);
-			}
-		}
-	}
-
 	*sram_handle = sram;
-
 	return rc;
 }
 

https://lab.dpdk.org/results/dashboard/patchsets/18959/

UNH-IOL DPDK Community Lab