[dpdk-test-report] |WARNING| pw99562-99563 [PATCH] [v3, 2/2] net/iavf: support IPv4/L4 checksum RSS offload

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Wed Oct 6 12:59:48 CEST 2021


Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/99562

_apply patch failure_

Submitter: Alvin Zhang <alvinx.zhang at intel.com>
Date: Friday, September 24 2021 09:57:29 
Applied on: CommitID:2700326085033fd13339a8de31f58a95d1ee9c3f
Apply patch set 99562-99563 failed:

Checking patch drivers/common/iavf/virtchnl.h...
error: while searching for:
	VIRTCHNL_PROTO_HDR_IPV4_DSCP,
	VIRTCHNL_PROTO_HDR_IPV4_TTL,
	VIRTCHNL_PROTO_HDR_IPV4_PROT,
	/* IPV6 */
	VIRTCHNL_PROTO_HDR_IPV6_SRC =
		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV6),

error: patch failed: drivers/common/iavf/virtchnl.h:1571
Applying patch drivers/common/iavf/virtchnl.h with 1 reject...
Rejected hunk #1.
diff a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h	(rejected hunks)
@@ -1571,6 +1571,7 @@ enum virtchnl_proto_hdr_field {
 	VIRTCHNL_PROTO_HDR_IPV4_DSCP,
 	VIRTCHNL_PROTO_HDR_IPV4_TTL,
 	VIRTCHNL_PROTO_HDR_IPV4_PROT,
+	VIRTCHNL_PROTO_HDR_IPV4_CHKSUM,
 	/* IPV6 */
 	VIRTCHNL_PROTO_HDR_IPV6_SRC =
 		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_IPV6),
Checking patch doc/guides/rel_notes/release_21_11.rst...
error: while searching for:
  * Implement support for tunnel offload.
  * Updated HWRM API to version 1.10.2.44

* **Updated Intel ice driver.**

  * Added 1PPS out support by a devargs.

error: patch failed: doc/guides/rel_notes/release_21_11.rst:73
Checking patch drivers/net/iavf/iavf_hash.c...
error: while searching for:

/* IPv4 outer */
#define IAVF_RSS_TYPE_OUTER_IPV4	(ETH_RSS_ETH | ETH_RSS_IPV4 | \
					 ETH_RSS_FRAG_IPV4)
#define IAVF_RSS_TYPE_OUTER_IPV4_UDP	(IAVF_RSS_TYPE_OUTER_IPV4 | \
					 ETH_RSS_NONFRAG_IPV4_UDP)
#define IAVF_RSS_TYPE_OUTER_IPV4_TCP	(IAVF_RSS_TYPE_OUTER_IPV4 | \
					 ETH_RSS_NONFRAG_IPV4_TCP)
#define IAVF_RSS_TYPE_OUTER_IPV4_SCTP	(IAVF_RSS_TYPE_OUTER_IPV4 | \
					 ETH_RSS_NONFRAG_IPV4_SCTP)
/* IPv6 outer */
#define IAVF_RSS_TYPE_OUTER_IPV6	(ETH_RSS_ETH | ETH_RSS_IPV6)
#define IAVF_RSS_TYPE_OUTER_IPV6_FRAG	(IAVF_RSS_TYPE_OUTER_IPV6 | \
					 ETH_RSS_FRAG_IPV6)
#define IAVF_RSS_TYPE_OUTER_IPV6_UDP	(IAVF_RSS_TYPE_OUTER_IPV6 | \
					 ETH_RSS_NONFRAG_IPV6_UDP)
#define IAVF_RSS_TYPE_OUTER_IPV6_TCP	(IAVF_RSS_TYPE_OUTER_IPV6 | \
					 ETH_RSS_NONFRAG_IPV6_TCP)
#define IAVF_RSS_TYPE_OUTER_IPV6_SCTP	(IAVF_RSS_TYPE_OUTER_IPV6 | \
					 ETH_RSS_NONFRAG_IPV6_SCTP)
/* VLAN IPV4 */
#define IAVF_RSS_TYPE_VLAN_IPV4		(IAVF_RSS_TYPE_OUTER_IPV4 | \
					 ETH_RSS_S_VLAN | ETH_RSS_C_VLAN)

error: patch failed: drivers/net/iavf/iavf_hash.c:342
error: while searching for:
			} else {
				hdr->field_selector = 0;
			}
			break;
		case VIRTCHNL_PROTO_HDR_IPV4_FRAG:
			if (rss_type &

error: patch failed: drivers/net/iavf/iavf_hash.c:800
error: while searching for:
			} else {
				hdr->field_selector = 0;
			}
			break;
		case VIRTCHNL_PROTO_HDR_IPV6:
			if (rss_type &

error: patch failed: drivers/net/iavf/iavf_hash.c:812
error: while searching for:
			} else {
				hdr->field_selector = 0;
			}
			break;
		case VIRTCHNL_PROTO_HDR_TCP:
			if (rss_type &

error: patch failed: drivers/net/iavf/iavf_hash.c:863
error: while searching for:
			} else {
				hdr->field_selector = 0;
			}
			break;
		case VIRTCHNL_PROTO_HDR_SCTP:
			if (rss_type &

error: patch failed: drivers/net/iavf/iavf_hash.c:879
error: while searching for:
			} else {
				hdr->field_selector = 0;
			}
			break;
		case VIRTCHNL_PROTO_HDR_S_VLAN:
			if (!(rss_type & ETH_RSS_S_VLAN))

error: patch failed: drivers/net/iavf/iavf_hash.c:895
Applying patch doc/guides/rel_notes/release_21_11.rst with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/iavf/iavf_hash.c with 6 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.
Rejected hunk #5.
Rejected hunk #6.
diff a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst	(rejected hunks)
@@ -73,6 +73,10 @@ New Features
   * Implement support for tunnel offload.
   * Updated HWRM API to version 1.10.2.44
 
+* **Updated Intel iavf driver.**
+
+  * Added IPv4 and L4(TCP/UDP/SCTP) checksum hash support in RSS flow.
+
 * **Updated Intel ice driver.**
 
   * Added 1PPS out support by a devargs.
diff a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c	(rejected hunks)
@@ -342,23 +342,30 @@ struct virtchnl_proto_hdrs ipv4_ecpri_tmplt = {
 
 /* IPv4 outer */
 #define IAVF_RSS_TYPE_OUTER_IPV4	(ETH_RSS_ETH | ETH_RSS_IPV4 | \
-					 ETH_RSS_FRAG_IPV4)
+					 ETH_RSS_FRAG_IPV4 | \
+					 ETH_RSS_IPV4_CHKSUM)
 #define IAVF_RSS_TYPE_OUTER_IPV4_UDP	(IAVF_RSS_TYPE_OUTER_IPV4 | \
-					 ETH_RSS_NONFRAG_IPV4_UDP)
+					 ETH_RSS_NONFRAG_IPV4_UDP | \
+					 ETH_RSS_L4_CHKSUM)
 #define IAVF_RSS_TYPE_OUTER_IPV4_TCP	(IAVF_RSS_TYPE_OUTER_IPV4 | \
-					 ETH_RSS_NONFRAG_IPV4_TCP)
+					 ETH_RSS_NONFRAG_IPV4_TCP | \
+					 ETH_RSS_L4_CHKSUM)
 #define IAVF_RSS_TYPE_OUTER_IPV4_SCTP	(IAVF_RSS_TYPE_OUTER_IPV4 | \
-					 ETH_RSS_NONFRAG_IPV4_SCTP)
+					 ETH_RSS_NONFRAG_IPV4_SCTP | \
+					 ETH_RSS_L4_CHKSUM)
 /* IPv6 outer */
 #define IAVF_RSS_TYPE_OUTER_IPV6	(ETH_RSS_ETH | ETH_RSS_IPV6)
 #define IAVF_RSS_TYPE_OUTER_IPV6_FRAG	(IAVF_RSS_TYPE_OUTER_IPV6 | \
 					 ETH_RSS_FRAG_IPV6)
 #define IAVF_RSS_TYPE_OUTER_IPV6_UDP	(IAVF_RSS_TYPE_OUTER_IPV6 | \
-					 ETH_RSS_NONFRAG_IPV6_UDP)
+					 ETH_RSS_NONFRAG_IPV6_UDP | \
+					 ETH_RSS_L4_CHKSUM)
 #define IAVF_RSS_TYPE_OUTER_IPV6_TCP	(IAVF_RSS_TYPE_OUTER_IPV6 | \
-					 ETH_RSS_NONFRAG_IPV6_TCP)
+					 ETH_RSS_NONFRAG_IPV6_TCP | \
+					 ETH_RSS_L4_CHKSUM)
 #define IAVF_RSS_TYPE_OUTER_IPV6_SCTP	(IAVF_RSS_TYPE_OUTER_IPV6 | \
-					 ETH_RSS_NONFRAG_IPV6_SCTP)
+					 ETH_RSS_NONFRAG_IPV6_SCTP | \
+					 ETH_RSS_L4_CHKSUM)
 /* VLAN IPV4 */
 #define IAVF_RSS_TYPE_VLAN_IPV4		(IAVF_RSS_TYPE_OUTER_IPV4 | \
 					 ETH_RSS_S_VLAN | ETH_RSS_C_VLAN)
@@ -800,6 +807,10 @@ struct virtchnl_proto_hdrs ipv4_ecpri_tmplt = {
 			} else {
 				hdr->field_selector = 0;
 			}
+
+			if (rss_type & ETH_RSS_IPV4_CHKSUM)
+				REFINE_PROTO_FLD(ADD, IPV4_CHKSUM);
+
 			break;
 		case VIRTCHNL_PROTO_HDR_IPV4_FRAG:
 			if (rss_type &
@@ -812,6 +823,10 @@ struct virtchnl_proto_hdrs ipv4_ecpri_tmplt = {
 			} else {
 				hdr->field_selector = 0;
 			}
+
+			if (rss_type & ETH_RSS_IPV4_CHKSUM)
+				REFINE_PROTO_FLD(ADD, IPV4_CHKSUM);
+
 			break;
 		case VIRTCHNL_PROTO_HDR_IPV6:
 			if (rss_type &
@@ -863,6 +878,9 @@ struct virtchnl_proto_hdrs ipv4_ecpri_tmplt = {
 			} else {
 				hdr->field_selector = 0;
 			}
+
+			if (rss_type & ETH_RSS_L4_CHKSUM)
+				REFINE_PROTO_FLD(ADD, UDP_CHKSUM);
 			break;
 		case VIRTCHNL_PROTO_HDR_TCP:
 			if (rss_type &
@@ -879,6 +897,9 @@ struct virtchnl_proto_hdrs ipv4_ecpri_tmplt = {
 			} else {
 				hdr->field_selector = 0;
 			}
+
+			if (rss_type & ETH_RSS_L4_CHKSUM)
+				REFINE_PROTO_FLD(ADD, TCP_CHKSUM);
 			break;
 		case VIRTCHNL_PROTO_HDR_SCTP:
 			if (rss_type &
@@ -895,6 +916,9 @@ struct virtchnl_proto_hdrs ipv4_ecpri_tmplt = {
 			} else {
 				hdr->field_selector = 0;
 			}
+
+			if (rss_type & ETH_RSS_L4_CHKSUM)
+				REFINE_PROTO_FLD(ADD, SCTP_CHKSUM);
 			break;
 		case VIRTCHNL_PROTO_HDR_S_VLAN:
 			if (!(rss_type & ETH_RSS_S_VLAN))

https://lab.dpdk.org/results/dashboard/patchsets/18939/

UNH-IOL DPDK Community Lab


More information about the test-report mailing list