[dpdk-test-report] |WARNING| pw98119 [RFC PATCH v5 5/5] app/test: add tests for PIE
checkpatch at dpdk.org
checkpatch at dpdk.org
Tue Sep 7 09:34:36 CEST 2021
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98119
_coding style issues_
WARNING:LONG_LINE: line length of 137 exceeds 100 columns
#183: FILE: app/test/test_pie.c:30:
+ (milliseconds) */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#183: FILE: app/test/test_pie.c:30:
+ uint16_t *dp_update_interval; /**< Update interval for drop probability
+ (milliseconds) */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#183: FILE: app/test/test_pie.c:30:
+ (milliseconds) */
WARNING:LONG_LINE: line length of 143 exceeds 100 columns
#194: FILE: app/test/test_pie.c:41:
+ up the queue */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#194: FILE: app/test/test_pie.c:41:
+ uint32_t q_ramp_up; /**< Num of enqueues to ramp
+ up the queue */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#194: FILE: app/test/test_pie.c:41:
+ up the queue */
WARNING:LONG_LINE: line length of 143 exceeds 100 columns
#196: FILE: app/test/test_pie.c:43:
+ not enqueued */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#196: FILE: app/test/test_pie.c:43:
+ double drop_tolerance; /**< Drop tolerance of packets
+ not enqueued */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#196: FILE: app/test/test_pie.c:43:
+ not enqueued */
WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#200: FILE: app/test/test_pie.c:47:
+ RTE_PIE */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#200: FILE: app/test/test_pie.c:47:
+struct test_var { /**< Test variables used for testing
+ RTE_PIE */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#200: FILE: app/test/test_pie.c:47:
+ RTE_PIE */
WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#209: FILE: app/test/test_pie.c:56:
+struct test_config { /**< Master test structure for RTE_PIE */
WARNING:LONG_LINE: line length of 124 exceeds 100 columns
#213: FILE: app/test/test_pie.c:60:
+ for result output */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#213: FILE: app/test/test_pie.c:60:
+ const char *htxt; /**< Header txt display
+ for result output */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#213: FILE: app/test/test_pie.c:60:
+ for result output */
WARNING:LONG_LINE: line length of 125 exceeds 100 columns
#215: FILE: app/test/test_pie.c:62:
+ for RTE_PIE config */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#215: FILE: app/test/test_pie.c:62:
+ struct test_rte_pie_config *tconfig; /**< Test structure
+ for RTE_PIE config */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#215: FILE: app/test/test_pie.c:62:
+ for RTE_PIE config */
WARNING:LONG_LINE: line length of 126 exceeds 100 columns
#218: FILE: app/test/test_pie.c:65:
+ for testing RTE_PIE */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#218: FILE: app/test/test_pie.c:65:
+ struct test_var *tvar; /**< Test variables used
+ for testing RTE_PIE */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#218: FILE: app/test/test_pie.c:65:
+ for testing RTE_PIE */
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct test_config *' should also have an identifier name
#230: FILE: app/test/test_pie.c:77:
+ enum test_result (*testfn)(struct test_config *);
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#243: FILE: app/test/test_pie.c:90:
+static double inv_cycles_per_byte = 0;
ERROR:SPACING: spaces required around that '>' (ctx:VxV)
#285: FILE: app/test/test_pie.c:132:
+ if (p->clk_avgc>0) {
^
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: app/test/test_pie.c:148:
+ return pie->active;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#306: FILE: app/test/test_pie.c:153:
+ uint16_t active)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#306: FILE: app/test/test_pie.c:153:
+ uint16_t active)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#310: FILE: app/test/test_pie.c:157:
+ pie->active = active;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#321: FILE: app/test/test_pie.c:168:
+ return pie->drop_prob;$
WARNING:LONG_LINE: line length of 138 exceeds 100 columns
#341: FILE: app/test/test_pie.c:188:
+ double tolerance)
ERROR:CODE_INDENT: code indent should use tabs where possible
#348: FILE: app/test/test_pie.c:195:
+^I *diff = 0.0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#350: FILE: app/test/test_pie.c:197:
+^I *diff = (abs_diff / drop_prob) * 100.0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#351: FILE: app/test/test_pie.c:198:
+^I if (*diff > tolerance) {$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#351: FILE: app/test/test_pie.c:198:
+ if (*diff > tolerance) {
+ ret = 0;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#352: FILE: app/test/test_pie.c:199:
+^I ret = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#353: FILE: app/test/test_pie.c:200:
+^I }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#354: FILE: app/test/test_pie.c:201:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#354: FILE: app/test/test_pie.c:201:
+ }$
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#364: FILE: app/test/test_pie.c:211:
+ unsigned i = 0;
ERROR:SPACING: space prohibited after that open parenthesis '('
#367: FILE: app/test/test_pie.c:214:
+ init_port_ts( tcfg->tvar->clk_freq );
ERROR:SPACING: space prohibited before that close parenthesis ')'
#367: FILE: app/test/test_pie.c:214:
+ init_port_ts( tcfg->tvar->clk_freq );
ERROR:CODE_INDENT: code indent should use tabs where possible
#396: FILE: app/test/test_pie.c:243:
+ uint32_t i = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#396: FILE: app/test/test_pie.c:243:
+ uint32_t i = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#398: FILE: app/test/test_pie.c:245:
+ for (i = 0; i < attempts; i++) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#398: FILE: app/test/test_pie.c:245:
+ for (i = 0; i < attempts; i++) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#399: FILE: app/test/test_pie.c:246:
+ int ret = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#399: FILE: app/test/test_pie.c:246:
+ int ret = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#401: FILE: app/test/test_pie.c:248:
+ //$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#401: FILE: app/test/test_pie.c:248:
+ //$
ERROR:C99_COMMENTS: do not use C99 // comments
#401: FILE: app/test/test_pie.c:248:
+ //
ERROR:CODE_INDENT: code indent should use tabs where possible
#402: FILE: app/test/test_pie.c:249:
+ // enqueue$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#402: FILE: app/test/test_pie.c:249:
+ // enqueue$
ERROR:C99_COMMENTS: do not use C99 // comments
#402: FILE: app/test/test_pie.c:249:
+ // enqueue
ERROR:CODE_INDENT: code indent should use tabs where possible
#403: FILE: app/test/test_pie.c:250:
+ //$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#403: FILE: app/test/test_pie.c:250:
+ //$
ERROR:C99_COMMENTS: do not use C99 // comments
#403: FILE: app/test/test_pie.c:250:
+ //
ERROR:CODE_INDENT: code indent should use tabs where possible
#404: FILE: app/test/test_pie.c:251:
+ ret = rte_pie_enqueue(pie_cfg, pie, *qlen, pkt_len,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#404: FILE: app/test/test_pie.c:251:
+ ret = rte_pie_enqueue(pie_cfg, pie, *qlen, pkt_len,$
WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#405: FILE: app/test/test_pie.c:252:
+ get_port_ts());
ERROR:CODE_INDENT: code indent should use tabs where possible
#406: FILE: app/test/test_pie.c:253:
+^I^I //$
ERROR:C99_COMMENTS: do not use C99 // comments
#406: FILE: app/test/test_pie.c:253:
+ //
ERROR:CODE_INDENT: code indent should use tabs where possible
#407: FILE: app/test/test_pie.c:254:
+^I^I // check if target actual queue size has been reached$
ERROR:C99_COMMENTS: do not use C99 // comments
#407: FILE: app/test/test_pie.c:254:
+ // check if target actual queue size has been reached
ERROR:CODE_INDENT: code indent should use tabs where possible
#408: FILE: app/test/test_pie.c:255:
+^I^I //$
ERROR:C99_COMMENTS: do not use C99 // comments
#408: FILE: app/test/test_pie.c:255:
+ //
ERROR:CODE_INDENT: code indent should use tabs where possible
#409: FILE: app/test/test_pie.c:256:
+ if (ret == 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#409: FILE: app/test/test_pie.c:256:
+ if (ret == 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 40)
#409: FILE: app/test/test_pie.c:256:
+ if (ret == 0) {
+ return 0;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#409: FILE: app/test/test_pie.c:256:
+ if (ret == 0) {
+ return 0;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#411: FILE: app/test/test_pie.c:258:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#411: FILE: app/test/test_pie.c:258:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#412: FILE: app/test/test_pie.c:259:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#412: FILE: app/test/test_pie.c:259:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#413: FILE: app/test/test_pie.c:260:
+ //$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#413: FILE: app/test/test_pie.c:260:
+ //$
ERROR:C99_COMMENTS: do not use C99 // comments
#413: FILE: app/test/test_pie.c:260:
+ //
ERROR:CODE_INDENT: code indent should use tabs where possible
#414: FILE: app/test/test_pie.c:261:
+ // no success$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#414: FILE: app/test/test_pie.c:261:
+ // no success$
ERROR:C99_COMMENTS: do not use C99 // comments
#414: FILE: app/test/test_pie.c:261:
+ // no success
ERROR:CODE_INDENT: code indent should use tabs where possible
#415: FILE: app/test/test_pie.c:262:
+ //$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#415: FILE: app/test/test_pie.c:262:
+ //$
ERROR:C99_COMMENTS: do not use C99 // comments
#415: FILE: app/test/test_pie.c:262:
+ //
ERROR:CODE_INDENT: code indent should use tabs where possible
#416: FILE: app/test/test_pie.c:263:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#416: FILE: app/test/test_pie.c:263:
+ return -1;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#423: FILE: app/test/test_pie.c:270:
+ struct rte_pie *pie,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#423: FILE: app/test/test_pie.c:270:
+ struct rte_pie *pie,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#424: FILE: app/test/test_pie.c:271:
+ uint32_t *qlen,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#424: FILE: app/test/test_pie.c:271:
+ uint32_t *qlen,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#425: FILE: app/test/test_pie.c:272:
+ uint32_t num_ops,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#425: FILE: app/test/test_pie.c:272:
+ uint32_t num_ops,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#426: FILE: app/test/test_pie.c:273:
+ uint32_t *enqueued,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#426: FILE: app/test/test_pie.c:273:
+ uint32_t *enqueued,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#427: FILE: app/test/test_pie.c:274:
+ uint32_t *dropped)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#427: FILE: app/test/test_pie.c:274:
+ uint32_t *dropped)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#429: FILE: app/test/test_pie.c:276:
+ uint32_t i = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#429: FILE: app/test/test_pie.c:276:
+ uint32_t i = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#431: FILE: app/test/test_pie.c:278:
+ for (i = 0; i < num_ops; i++) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#431: FILE: app/test/test_pie.c:278:
+ for (i = 0; i < num_ops; i++) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#432: FILE: app/test/test_pie.c:279:
+ int ret = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#432: FILE: app/test/test_pie.c:279:
+ int ret = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#434: FILE: app/test/test_pie.c:281:
+ /**$
ERROR:CODE_INDENT: code indent should use tabs where possible
#435: FILE: app/test/test_pie.c:282:
+ * enqueue$
ERROR:CODE_INDENT: code indent should use tabs where possible
#436: FILE: app/test/test_pie.c:283:
+ */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#437: FILE: app/test/test_pie.c:284:
+ ret = rte_pie_enqueue(pie_cfg, pie, *qlen, sizeof(uint32_t),$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#437: FILE: app/test/test_pie.c:284:
+ ret = rte_pie_enqueue(pie_cfg, pie, *qlen, sizeof(uint32_t),$
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#438: FILE: app/test/test_pie.c:285:
+ get_port_ts());
ERROR:CODE_INDENT: code indent should use tabs where possible
#439: FILE: app/test/test_pie.c:286:
+ if (ret == 0)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#439: FILE: app/test/test_pie.c:286:
+ if (ret == 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#440: FILE: app/test/test_pie.c:287:
+ (*enqueued)++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#440: FILE: app/test/test_pie.c:287:
+ (*enqueued)++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#441: FILE: app/test/test_pie.c:288:
+ else$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#441: FILE: app/test/test_pie.c:288:
+ else$
ERROR:CODE_INDENT: code indent should use tabs where possible
#442: FILE: app/test/test_pie.c:289:
+ (*dropped)++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#442: FILE: app/test/test_pie.c:289:
+ (*dropped)++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#443: FILE: app/test/test_pie.c:290:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#443: FILE: app/test/test_pie.c:290:
+ }$
ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#451: FILE: app/test/test_pie.c:298:
+static uint32_t ft_q[] ={0};
^
ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#452: FILE: app/test/test_pie.c:299:
+static uint32_t ft_dropped[] ={0};
^
ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#453: FILE: app/test/test_pie.c:300:
+static uint32_t ft_enqueued[] ={0};
^
ERROR:SPACING: spaces required around that '!=' (ctx:WxV)
#558: FILE: app/test/test_pie.c:405:
+ if (drop_prob !=0) {
^
ERROR:SPACING: spaces required around that '!=' (ctx:WxV)
#563: FILE: app/test/test_pie.c:410:
+ if (drop_rate !=0) {
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#573: FILE: app/test/test_pie.c:420:
+^I (double)tcfg->tqueue->drop_tolerance, active);$
WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#585: FILE: app/test/test_pie.c:432:
+ 900, 1200, 1500, 3000};
ERROR:CODE_INDENT: code indent should use tabs where possible
#672: FILE: app/test/test_pie.c:519:
+^I (double)tcfg->tqueue->drop_tolerance);$
ERROR:SPACING: spaces required around that '!=' (ctx:WxV)
#781: FILE: app/test/test_pie.c:628:
+ if (drop_prob !=0) {
^
ERROR:SPACING: spaces required around that '!=' (ctx:WxV)
#786: FILE: app/test/test_pie.c:633:
+ if (drop_rate !=0) {
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#796: FILE: app/test/test_pie.c:643:
+^I (double)tcfg->tqueue->drop_tolerance, active);$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#852: FILE: app/test/test_pie.c:699:
+ * ^Iaka$
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#891: FILE: app/test/test_pie.c:738:
+ if (ret == 0) {
[...]
+ else {
[...]
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#894: FILE: app/test/test_pie.c:741:
+ }
+ else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#1053: FILE: app/test/test_pie.c:900:
+^I ^I*tcfg->tvar->dropped,$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1053: FILE: app/test/test_pie.c:900:
+^I ^I*tcfg->tvar->dropped,$
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#1087: FILE: app/test/test_pie.c:934:
+ uint32_t *num_tests, uint32_t *num_pass)
WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#1092: FILE: app/test/test_pie.c:939:
+ "-------------------------------------------";
WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#1094: FILE: app/test/test_pie.c:941:
+ "<pass>-------------------------------------";
WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#1096: FILE: app/test/test_pie.c:943:
+ "<fail>-------------------------------------";
WARNING:RETURN_VOID: void function return statements are not generally useful
#1110: FILE: app/test/test_pie.c:957:
+ return;
+}
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1166: FILE: app/test/test_pie.c:1013:
+ return 0;$
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1191: FILE: app/test/test_pie.c:1038:
+ if (test_invalid_parameters() < 0) {
+ return -1;
+ }
total: 66 errors, 74 warnings, 1200 lines checked
More information about the test-report
mailing list