[dpdk-test-report] |WARNING| pw98241 [PATCH v3 3/8] bpf: add function to convert classic BPF to DPDK BPF

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 8 06:51:32 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98241

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#451: FILE: lib/bpf/bpf_convert.c:343:
+#define BPF_EMIT_JMP							\
+			do {						\
+				if (target >= len)			\
+					goto err;			\
+				insn->off = addrs ? addrs[target] - addrs[i] - 1 : 0; \
+				/* Adjust pc relative offset for 2nd or 3rd insn. */ \
+				insn->off -= insn - tmp_insns;		\
+			} while (0)

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#582: FILE: lib/bpf/bpf_convert.c:474:
+#if 0

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#592: FILE: lib/bpf/bpf_convert.c:484:
+#if 0

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#628: FILE: lib/bpf/bpf_convert.c:520:
+	assert (*new_len == new_flen);

total: 0 errors, 4 warnings, 628 lines checked


More information about the test-report mailing list