[dpdk-test-report] |WARNING| pw98244 [PATCH v3 6/8] app/dumpcap: add new packet capture application

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 8 06:53:26 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98244

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#163: FILE: app/dumpcap/main.c:62:
+static unsigned dump_bpf;

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#614: FILE: app/dumpcap/main.c:513:
+	const char *args[] = {

WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#719: FILE: app/dumpcap/main.c:618:
+		fd = open(output_name, O_WRONLY | O_CREAT, mode);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#739: FILE: app/dumpcap/main.c:638:
+		return pcapng;
+	} else {

total: 0 errors, 4 warnings, 855 lines checked


More information about the test-report mailing list