[dpdk-test-report] |WARNING| pw98628 [PATCH 20/24] pipeline: export pipeline instructions to file

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98628

_coding style issues_


ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#71: FILE: lib/pipeline/rte_swx_pipeline.c:9776:
+	switch (instr->type) {
+		case INSTR_RX: return "INSTR_RX";
[...]
+		case INSTR_TX: return "INSTR_TX";
+		case INSTR_TX_I: return "INSTR_TX_I";
[...]
+		case INSTR_HDR_EXTRACT: return "INSTR_HDR_EXTRACT";
+		case INSTR_HDR_EXTRACT2: return "INSTR_HDR_EXTRACT2";
+		case INSTR_HDR_EXTRACT3: return "INSTR_HDR_EXTRACT3";
+		case INSTR_HDR_EXTRACT4: return "INSTR_HDR_EXTRACT4";
+		case INSTR_HDR_EXTRACT5: return "INSTR_HDR_EXTRACT5";
+		case INSTR_HDR_EXTRACT6: return "INSTR_HDR_EXTRACT6";
+		case INSTR_HDR_EXTRACT7: return "INSTR_HDR_EXTRACT7";
+		case INSTR_HDR_EXTRACT8: return "INSTR_HDR_EXTRACT8";
[...]
+		case INSTR_HDR_EXTRACT_M: return "INSTR_HDR_EXTRACT_M";
[...]
+		case INSTR_HDR_LOOKAHEAD: return "INSTR_HDR_LOOKAHEAD";
[...]
+		case INSTR_HDR_EMIT: return "INSTR_HDR_EMIT";
+		case INSTR_HDR_EMIT_TX: return "INSTR_HDR_EMIT_TX";
+		case INSTR_HDR_EMIT2_TX: return "INSTR_HDR_EMIT2_TX";
+		case INSTR_HDR_EMIT3_TX: return "INSTR_HDR_EMIT3_TX";
+		case INSTR_HDR_EMIT4_TX: return "INSTR_HDR_EMIT4_TX";
+		case INSTR_HDR_EMIT5_TX: return "INSTR_HDR_EMIT5_TX";
+		case INSTR_HDR_EMIT6_TX: return "INSTR_HDR_EMIT6_TX";
+		case INSTR_HDR_EMIT7_TX: return "INSTR_HDR_EMIT7_TX";
+		case INSTR_HDR_EMIT8_TX: return "INSTR_HDR_EMIT8_TX";
[...]
+		case INSTR_HDR_VALIDATE: return "INSTR_HDR_VALIDATE";
+		case INSTR_HDR_INVALIDATE: return "INSTR_HDR_INVALIDATE";
[...]
+		case INSTR_MOV: return "INSTR_MOV";
+		case INSTR_MOV_MH: return "INSTR_MOV_MH";
+		case INSTR_MOV_HM: return "INSTR_MOV_HM";
+		case INSTR_MOV_HH: return "INSTR_MOV_HH";
+		case INSTR_MOV_I: return "INSTR_MOV_I";
[...]
+		case INSTR_DMA_HT: return "INSTR_DMA_HT";
+		case INSTR_DMA_HT2: return "INSTR_DMA_HT2";
+		case INSTR_DMA_HT3: return "INSTR_DMA_HT3";
+		case INSTR_DMA_HT4: return "INSTR_DMA_HT4";
+		case INSTR_DMA_HT5: return "INSTR_DMA_HT5";
+		case INSTR_DMA_HT6: return "INSTR_DMA_HT6";
+		case INSTR_DMA_HT7: return "INSTR_DMA_HT7";
+		case INSTR_DMA_HT8: return "INSTR_DMA_HT8";
[...]
+		case INSTR_ALU_ADD: return "INSTR_ALU_ADD";
+		case INSTR_ALU_ADD_MH: return "INSTR_ALU_ADD_MH";
+		case INSTR_ALU_ADD_HM: return "INSTR_ALU_ADD_HM";
+		case INSTR_ALU_ADD_HH: return "INSTR_ALU_ADD_HH";
+		case INSTR_ALU_ADD_MI: return "INSTR_ALU_ADD_MI";
+		case INSTR_ALU_ADD_HI: return "INSTR_ALU_ADD_HI";
[...]
+		case INSTR_ALU_SUB: return "INSTR_ALU_SUB";
+		case INSTR_ALU_SUB_MH: return "INSTR_ALU_SUB_MH";
+		case INSTR_ALU_SUB_HM: return "INSTR_ALU_SUB_HM";
+		case INSTR_ALU_SUB_HH: return "INSTR_ALU_SUB_HH";
+		case INSTR_ALU_SUB_MI: return "INSTR_ALU_SUB_MI";
+		case INSTR_ALU_SUB_HI: return "INSTR_ALU_SUB_HI";
[...]
+		case INSTR_ALU_CKADD_FIELD: return "INSTR_ALU_CKADD_FIELD";
+		case INSTR_ALU_CKADD_STRUCT20: return "INSTR_ALU_CKADD_STRUCT20";
+		case INSTR_ALU_CKADD_STRUCT: return "INSTR_ALU_CKADD_STRUCT";
+		case INSTR_ALU_CKSUB_FIELD: return "INSTR_ALU_CKSUB_FIELD";
[...]
+		case INSTR_ALU_AND: return "INSTR_ALU_AND";
+		case INSTR_ALU_AND_MH: return "INSTR_ALU_AND_MH";
+		case INSTR_ALU_AND_HM: return "INSTR_ALU_AND_HM";
+		case INSTR_ALU_AND_HH: return "INSTR_ALU_AND_HH";
+		case INSTR_ALU_AND_I: return "INSTR_ALU_AND_I";
[...]
+		case INSTR_ALU_OR: return "INSTR_ALU_OR";
+		case INSTR_ALU_OR_MH: return "INSTR_ALU_OR_MH";
+		case INSTR_ALU_OR_HM: return "INSTR_ALU_OR_HM";
+		case INSTR_ALU_OR_HH: return "INSTR_ALU_OR_HH";
+		case INSTR_ALU_OR_I: return "INSTR_ALU_OR_I";
[...]
+		case INSTR_ALU_XOR: return "INSTR_ALU_XOR";
+		case INSTR_ALU_XOR_MH: return "INSTR_ALU_XOR_MH";
+		case INSTR_ALU_XOR_HM: return "INSTR_ALU_XOR_HM";
+		case INSTR_ALU_XOR_HH: return "INSTR_ALU_XOR_HH";
+		case INSTR_ALU_XOR_I: return "INSTR_ALU_XOR_I";
[...]
+		case INSTR_ALU_SHL: return "INSTR_ALU_SHL";
+		case INSTR_ALU_SHL_MH: return "INSTR_ALU_SHL_MH";
+		case INSTR_ALU_SHL_HM: return "INSTR_ALU_SHL_HM";
+		case INSTR_ALU_SHL_HH: return "INSTR_ALU_SHL_HH";
+		case INSTR_ALU_SHL_MI: return "INSTR_ALU_SHL_MI";
+		case INSTR_ALU_SHL_HI: return "INSTR_ALU_SHL_HI";
[...]
+		case INSTR_ALU_SHR: return "INSTR_ALU_SHR";
+		case INSTR_ALU_SHR_MH: return "INSTR_ALU_SHR_MH";
+		case INSTR_ALU_SHR_HM: return "INSTR_ALU_SHR_HM";
+		case INSTR_ALU_SHR_HH: return "INSTR_ALU_SHR_HH";
+		case INSTR_ALU_SHR_MI: return "INSTR_ALU_SHR_MI";
+		case INSTR_ALU_SHR_HI: return "INSTR_ALU_SHR_HI";
[...]
+		case INSTR_REGPREFETCH_RH: return "INSTR_REGPREFETCH_RH";
+		case INSTR_REGPREFETCH_RM: return "INSTR_REGPREFETCH_RM";
+		case INSTR_REGPREFETCH_RI: return "INSTR_REGPREFETCH_RI";
[...]
+		case INSTR_REGRD_HRH: return "INSTR_REGRD_HRH";
+		case INSTR_REGRD_HRM: return "INSTR_REGRD_HRM";
+		case INSTR_REGRD_HRI: return "INSTR_REGRD_HRI";
+		case INSTR_REGRD_MRH: return "INSTR_REGRD_MRH";
+		case INSTR_REGRD_MRM: return "INSTR_REGRD_MRM";
+		case INSTR_REGRD_MRI: return "INSTR_REGRD_MRI";
[...]
+		case INSTR_REGWR_RHH: return "INSTR_REGWR_RHH";
+		case INSTR_REGWR_RHM: return "INSTR_REGWR_RHM";
+		case INSTR_REGWR_RHI: return "INSTR_REGWR_RHI";
+		case INSTR_REGWR_RMH: return "INSTR_REGWR_RMH";
+		case INSTR_REGWR_RMM: return "INSTR_REGWR_RMM";
+		case INSTR_REGWR_RMI: return "INSTR_REGWR_RMI";
+		case INSTR_REGWR_RIH: return "INSTR_REGWR_RIH";
+		case INSTR_REGWR_RIM: return "INSTR_REGWR_RIM";
+		case INSTR_REGWR_RII: return "INSTR_REGWR_RII";
[...]
+		case INSTR_REGADD_RHH: return "INSTR_REGADD_RHH";
+		case INSTR_REGADD_RHM: return "INSTR_REGADD_RHM";
+		case INSTR_REGADD_RHI: return "INSTR_REGADD_RHI";
+		case INSTR_REGADD_RMH: return "INSTR_REGADD_RMH";
+		case INSTR_REGADD_RMM: return "INSTR_REGADD_RMM";
+		case INSTR_REGADD_RMI: return "INSTR_REGADD_RMI";
+		case INSTR_REGADD_RIH: return "INSTR_REGADD_RIH";
+		case INSTR_REGADD_RIM: return "INSTR_REGADD_RIM";
+		case INSTR_REGADD_RII: return "INSTR_REGADD_RII";
[...]
+		case INSTR_METPREFETCH_H: return "INSTR_METPREFETCH_H";
+		case INSTR_METPREFETCH_M: return "INSTR_METPREFETCH_M";
+		case INSTR_METPREFETCH_I: return "INSTR_METPREFETCH_I";
[...]
+		case INSTR_METER_HHM: return "INSTR_METER_HHM";
+		case INSTR_METER_HHI: return "INSTR_METER_HHI";
+		case INSTR_METER_HMM: return "INSTR_METER_HMM";
+		case INSTR_METER_HMI: return "INSTR_METER_HMI";
+		case INSTR_METER_MHM: return "INSTR_METER_MHM";
+		case INSTR_METER_MHI: return "INSTR_METER_MHI";
+		case INSTR_METER_MMM: return "INSTR_METER_MMM";
+		case INSTR_METER_MMI: return "INSTR_METER_MMI";
+		case INSTR_METER_IHM: return "INSTR_METER_IHM";
+		case INSTR_METER_IHI: return "INSTR_METER_IHI";
+		case INSTR_METER_IMM: return "INSTR_METER_IMM";
+		case INSTR_METER_IMI: return "INSTR_METER_IMI";
[...]
+		case INSTR_TABLE: return "INSTR_TABLE";
+		case INSTR_TABLE_AF: return "INSTR_TABLE_AF";
+		case INSTR_SELECTOR: return "INSTR_SELECTOR";
+		case INSTR_LEARNER: return "INSTR_LEARNER";
+		case INSTR_LEARNER_AF: return "INSTR_LEARNER_AF";
[...]
+		case INSTR_LEARNER_LEARN: return "INSTR_LEARNER_LEARN";
+		case INSTR_LEARNER_FORGET: return "INSTR_LEARNER_FORGET";
[...]
+		case INSTR_EXTERN_OBJ: return "INSTR_EXTERN_OBJ";
+		case INSTR_EXTERN_FUNC: return "INSTR_EXTERN_FUNC";
[...]
+		case INSTR_JMP: return "INSTR_JMP";
+		case INSTR_JMP_VALID: return "INSTR_JMP_VALID";
+		case INSTR_JMP_INVALID: return "INSTR_JMP_INVALID";
+		case INSTR_JMP_HIT: return "INSTR_JMP_HIT";
+		case INSTR_JMP_MISS: return "INSTR_JMP_MISS";
+		case INSTR_JMP_ACTION_HIT: return "INSTR_JMP_ACTION_HIT";
+		case INSTR_JMP_ACTION_MISS: return "INSTR_JMP_ACTION_MISS";
+		case INSTR_JMP_EQ: return "INSTR_JMP_EQ";
+		case INSTR_JMP_EQ_MH: return "INSTR_JMP_EQ_MH";
+		case INSTR_JMP_EQ_HM: return "INSTR_JMP_EQ_HM";
+		case INSTR_JMP_EQ_HH: return "INSTR_JMP_EQ_HH";
+		case INSTR_JMP_EQ_I: return "INSTR_JMP_EQ_I";
+		case INSTR_JMP_NEQ: return "INSTR_JMP_NEQ";
+		case INSTR_JMP_NEQ_MH: return "INSTR_JMP_NEQ_MH";
+		case INSTR_JMP_NEQ_HM: return "INSTR_JMP_NEQ_HM";
+		case INSTR_JMP_NEQ_HH: return "INSTR_JMP_NEQ_HH";
+		case INSTR_JMP_NEQ_I: return "INSTR_JMP_NEQ_I";
+		case INSTR_JMP_LT: return "INSTR_JMP_LT";
+		case INSTR_JMP_LT_MH: return "INSTR_JMP_LT_MH";
+		case INSTR_JMP_LT_HM: return "INSTR_JMP_LT_HM";
+		case INSTR_JMP_LT_HH: return "INSTR_JMP_LT_HH";
+		case INSTR_JMP_LT_MI: return "INSTR_JMP_LT_MI";
+		case INSTR_JMP_LT_HI: return "INSTR_JMP_LT_HI";
+		case INSTR_JMP_GT: return "INSTR_JMP_GT";
+		case INSTR_JMP_GT_MH: return "INSTR_JMP_GT_MH";
+		case INSTR_JMP_GT_HM: return "INSTR_JMP_GT_HM";
+		case INSTR_JMP_GT_HH: return "INSTR_JMP_GT_HH";
+		case INSTR_JMP_GT_MI: return "INSTR_JMP_GT_MI";
+		case INSTR_JMP_GT_HI: return "INSTR_JMP_GT_HI";
[...]
+		case INSTR_RETURN: return "INSTR_RETURN";
[...]
+		default: return "INSTR_UNKNOWN";

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#533: FILE: lib/pipeline/rte_swx_pipeline.c:10238:
+	if (instr->type == INSTR_ALU_ADD_MI ||
[...]
+	    imm = 1;

WARNING:RETURN_VOID: void function return statements are not generally useful
#672: FILE: lib/pipeline/rte_swx_pipeline.c:10377:
+	return;
+}

WARNING:RETURN_VOID: void function return statements are not generally useful
#772: FILE: lib/pipeline/rte_swx_pipeline.c:10477:
+	return;
+}

total: 1 errors, 3 warnings, 1112 lines checked