[dpdk-test-report] |WARNING| pw99779 [PATCH 06/11] net/dpaa2: add function to generate HW hash key
checkpatch at dpdk.org
checkpatch at dpdk.org
Mon Sep 27 14:27:50 CEST 2021
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/99779
_coding style issues_
ERROR:C99_COMMENTS: do not use C99 // comments
#117: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:42:
+ // mix
ERROR:C99_COMMENTS: do not use C99 // comments
#118: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:43:
+ input ^= input >> 16; // xor lower
ERROR:C99_COMMENTS: do not use C99 // comments
#119: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:44:
+ input ^= input << 16; // move original lower to upper
ERROR:C99_COMMENTS: do not use C99 // comments
#121: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:46:
+ // printf("%08x
",input);
ERROR:C99_COMMENTS: do not use C99 // comments
#123: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:48:
+ for (int i = 0; i < 32; i += 4)// sbox stage
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#123: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:48:
+ for (int i = 0; i < 32; i += 4)// sbox stage
ERROR:C99_COMMENTS: do not use C99 // comments
#126: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:51:
+ // permutation
ERROR:C99_COMMENTS: do not use C99 // comments
#137: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:62:
+ // mix
ERROR:C99_COMMENTS: do not use C99 // comments
#138: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:63:
+ input ^= input >> 16; // xor lower
ERROR:C99_COMMENTS: do not use C99 // comments
#139: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:64:
+ input ^= input << 16; // move original lower to upper
ERROR:C99_COMMENTS: do not use C99 // comments
#141: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:66:
+ for (int i = 0; i < 32; i += 4) // sbox stage
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#141: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:66:
+ for (int i = 0; i < 32; i += 4) // sbox stage
ERROR:C99_COMMENTS: do not use C99 // comments
#204: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:129:
+ // (a,b)
ERROR:C99_COMMENTS: do not use C99 // comments
#205: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:130:
+ // (b,a^b)=(X,Y)
ERROR:C99_COMMENTS: do not use C99 // comments
#206: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:131:
+ // (X^Y,X)
ERROR:C99_COMMENTS: do not use C99 // comments
#209: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:134:
+ input ^= input << 16; // (X^Y,Y)
ERROR:C99_COMMENTS: do not use C99 // comments
#210: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:135:
+ input ^= input >> 16; // (X^Y,X)
ERROR:C99_COMMENTS: do not use C99 // comments
#212: FILE: drivers/net/dpaa2/base/dpaa2_tlu_hash.c:137:
+ //printf("aaa %08x
", stage(input));
total: 18 errors, 0 warnings, 0 checks, 187 lines checked
Warning in drivers/net/dpaa2/base/dpaa2_tlu_hash.c:
Declaring a variable inside for()
More information about the test-report
mailing list