|WARNING| pw109518 [PATCH v2] common/sff_module: add telemetry command to dump module EEPROM

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 8 12:28:25 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109518

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#866: FILE: drivers/common/sff_module/sff_8472.c:33:
+ * This is the offset at which the A2 page is in the EEPROM $

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1592: FILE: drivers/common/sff_module/sff_8636.c:452:
+		printf("%s 40G OTN (OTU3B/OTU3C)
", pfx);

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1592: FILE: drivers/common/sff_module/sff_8636.c:452:
+		printf("%s 40G OTN (OTU3B/OTU3C)
", pfx);

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1593: FILE: drivers/common/sff_module/sff_8636.c:453:
+		add_item_string(items, name_string, "40G OTN (OTU3B/OTU3C)");

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1593: FILE: drivers/common/sff_module/sff_8636.c:453:
+		add_item_string(items, name_string, "40G OTN (OTU3B/OTU3C)");

WARNING:TYPO_SPELLING: 'gurantee' may be misspelled - perhaps 'guarantee'?
#2022: FILE: drivers/common/sff_module/sff_8636.c:882:
+	 * of page 3, will provide the gurantee for existence of alarms

WARNING:TYPO_SPELLING: 'Celcius' may be misspelled - perhaps ''?
#3336: FILE: drivers/common/sff_module/sff_common.h:167:
+	/* SFP Temp in 16-bit signed 1/256 Celcius */

ERROR:CODE_INDENT: code indent should use tabs where possible
#3534: FILE: drivers/common/sff_module/sff_telemetry.h:19:
+        char name[SFF_ITEM_NAME_SIZE];    /* The item name. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3534: FILE: drivers/common/sff_module/sff_telemetry.h:19:
+        char name[SFF_ITEM_NAME_SIZE];    /* The item name. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3535: FILE: drivers/common/sff_module/sff_telemetry.h:20:
+        char value[SFF_ITEM_VALUE_SIZE];  /* The item value. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3535: FILE: drivers/common/sff_module/sff_telemetry.h:20:
+        char value[SFF_ITEM_VALUE_SIZE];  /* The item value. */$

total: 3 errors, 8 warnings, 3389 lines checked


More information about the test-report mailing list