|WARNING| pw109824 [PATCH 19/24] net/cnxk: optimize Rx fast path for security pkts

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Apr 19 08:03:02 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109824

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#401: FILE: drivers/net/cnxk/cn10k_rx.h:953:
+#define NIX_PUSH_META_TO_FREE(_mbuf, _laddr, _loff_p)                          \
+	do {                                                                   \
+		*(uint64_t *)((_laddr) + (*(_loff_p) << 3)) = (uint64_t)_mbuf; \
+		*(_loff_p) = *(_loff_p) + 1;                                   \
+		/* Mark meta mbuf as put */                                    \
+		RTE_MEMPOOL_CHECK_COOKIES(_mbuf->pool, (void **)&_mbuf, 1, 0); \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_loff_p' - possible side-effects?
#401: FILE: drivers/net/cnxk/cn10k_rx.h:953:
+#define NIX_PUSH_META_TO_FREE(_mbuf, _laddr, _loff_p)                          \
+	do {                                                                   \
+		*(uint64_t *)((_laddr) + (*(_loff_p) << 3)) = (uint64_t)_mbuf; \
+		*(_loff_p) = *(_loff_p) + 1;                                   \
+		/* Mark meta mbuf as put */                                    \
+		RTE_MEMPOOL_CHECK_COOKIES(_mbuf->pool, (void **)&_mbuf, 1, 0); \
+	} while (0)

total: 0 errors, 0 warnings, 2 checks, 607 lines checked


More information about the test-report mailing list