|WARNING| pw114643 [PATCH 20/21] net/softnic: add pipeline mirroring CLI command

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Aug 4 19:03:04 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114643

_coding style issues_


WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#84: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2116:
+ * ^Itruncate <truncation_length>$

CHECK:BRACES: braces {} should be used on all arms of this statement
#144: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2176:
+	if (!strcmp(tokens[8], "fast"))
[...]
+	else if (!strcmp(tokens[8], "slow"))
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#148: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2180:
+	else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 4'
#178: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:2487:
+		if ((n_tokens >= 4) &&
+			!strcmp(tokens[2], "mirror") &&
+			!strcmp(tokens[3], "session")) {

total: 0 errors, 1 warnings, 3 checks, 108 lines checked


More information about the test-report mailing list