|WARNING| pw114637 [PATCH 14/21] net/softnic: add pipeline selector table CLI commands

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Aug 4 19:03:26 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114637

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#561: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1423:
+		if ((n_tokens >= 6) &&
+			!strcmp(tokens[2], "selector") &&
+			!strcmp(tokens[4], "group") &&
+			!strcmp(tokens[5], "add")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 6'
#570: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1432:
+		if ((n_tokens >= 6) &&
+			!strcmp(tokens[2], "selector") &&
+			!strcmp(tokens[4], "group") &&
+			!strcmp(tokens[5], "delete")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#579: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1441:
+		if ((n_tokens >= 7) &&
+			!strcmp(tokens[2], "selector") &&
+			!strcmp(tokens[4], "group") &&
+			!strcmp(tokens[5], "member") &&
+			!strcmp(tokens[6], "add")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 7'
#589: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1451:
+		if ((n_tokens >= 7) &&
+			!strcmp(tokens[2], "selector") &&
+			!strcmp(tokens[4], "group") &&
+			!strcmp(tokens[5], "member") &&
+			!strcmp(tokens[6], "delete")) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens >= 5'
#599: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1461:
+		if ((n_tokens >= 5) &&
+			!strcmp(tokens[2], "selector") &&
+			!strcmp(tokens[4], "show")) {

total: 0 errors, 0 warnings, 5 checks, 529 lines checked


More information about the test-report mailing list