|WARNING| pw114948 [RFC 2/2] vhost: add egress API for port mirroring datapath

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Aug 14 15:20:57 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114948

_coding style issues_


ERROR:INITIALISED_STATIC: do not initialise statics to 0
#318: FILE: lib/vhost/virtio_net.c:4018:
+	static uint64_t total = 0;

WARNING:LONG_LINE: line length of 144 exceeds 100 columns
#360: FILE: lib/vhost/virtio_net.c:4060:
+			if ((((uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset) & 0xFFF) ^ ((uint64_t)mirror_hpa & 0xFFF)) != 0 && flag == 0)

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#360: FILE: lib/vhost/virtio_net.c:4060:
+			if ((((uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset) & 0xFFF) ^ ((uint64_t)mirror_hpa & 0xFFF)) != 0 && flag == 0)
+			{

WARNING:LONG_LINE: line length of 173 exceeds 100 columns
#363: FILE: lib/vhost/virtio_net.c:4063:
+				VHOST_LOG_DATA(ERR, "%lu.........mbuf=%p mirror_hpa=%p.
", total, (void *)(uintptr_t)rte_pktmbuf_iova_offset(cur, mbuf_offset), mirror_hpa);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#621: FILE: lib/vhost/virtio_net.c:4321:
+		ret = vq->async_ops.transfer_data(dev->vid, queue_id, tdes, 0, nr_async_burst, true);

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#807: FILE: lib/vhost/virtio_net.c:4507:
+#if 0

total: 2 errors, 4 warnings, 764 lines checked
Warning in lib/vhost/virtio_net.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t


More information about the test-report mailing list